Changeset 10162

Timestamp:

Feb 11, 2010, 1:37:59 AM (12 years ago)

Author:

charles

Message:

(trunk daemon) #2890 "Add option to specify logfile in transmission-daemon" -- implemented for 1.90

Location:

trunk/daemon

Files:

• daemon.c (modified) (9 diffs)
• transmission-daemon.1 (modified) (2 diffs)

trunk/daemon/daemon.c

@@ -72 +72 @@
     { 942, "no-incomplete-dir", "Don't store incomplete torrents in a different location", NULL, 0, NULL },
     { 'd', "dump-settings", "Dump the settings and exit", "d", 0, NULL },
+    { 'e', "logfile", "Dump the log messages to this filename", "e", 1, "<filename>" },
     { 'f', "foreground", "Run in the foreground instead of daemonizing", "f", 0, NULL },
     { 'g', "config-dir", "Where to look for configuration files", "g", 1, "<path>" },
@@ -229 +230 @@
 
 static void
-printMessage( tr_bool foreground, int level, const char * name, const char * message, const char * file, int line )
-{
-#ifdef HAVE_SYSLOG
-    if( foreground )
+printMessage( FILE * logfile, int level, const char * name, const char * message, const char * file, int line )
+{
+    if( logfile != NULL )
     {
         char timestr[64];
         tr_getLogTimeStr( timestr, sizeof( timestr ) );
         if( name )
-            fprintf( stderr, "[%s] %s %s (%s:%d)\n", timestr, name, message, file, line );
+            fprintf( logfile, "[%s] %s %s (%s:%d)\n", timestr, name, message, file, line );
         else
-            fprintf( stderr, "[%s] %s (%s:%d)\n", timestr, message, file, line );
-    }
+            fprintf( logfile, "[%s] %s (%s:%d)\n", timestr, message, file, line );
+    }
+#ifdef HAVE_SYSLOG
     else /* daemon... write to syslog */
     {
@@ -257 +258 @@
             syslog( priority, "%s (%s:%d)", message, file, line );
     }
-#else
-    {
-        char timestr[64];
-        tr_getLogTimeStr( timestr, sizeof( timestr ) );
-        if( name )
-            fprintf( stderr, "[%s] %s %s (%s:%d)\n", timestr, name, message, file, line );
-        else
-            fprintf( stderr, "[%s] %s (%s:%d)\n", timestr, message, file, line );
-    }
 #endif
 }
 
 static void
-pumpLogMessages( tr_bool foreground )
+pumpLogMessages( FILE * logfile )
 {
     const tr_msg_list * l;
@@ -276 +268 @@
 
     for( l=list; l!=NULL; l=l->next )
-        printMessage( foreground, l->level, l->name, l->message, l->file, l->line );
+        printMessage( logfile, l->level, l->name, l->message, l->file, l->line );
 
     tr_freeMessageList( list );
@@ -293 +285 @@
     const char * configDir = NULL;
     dtr_watchdir * watchdir = NULL;
+    FILE * logfile = NULL;
 
     signal( SIGINT, gotsig );
@@ -330 +323 @@
             case 'd': dumpSettings = TRUE;
                       break;
+            case 'e': logfile = fopen( optarg, "a+" );
+                      if( logfile == NULL )
+                          fprintf( stderr, "Couldn't open \"%s\": %s\n", optarg, tr_strerror( errno ) );
+                      break;
             case 'f': foreground = TRUE;
                       break;
@@ -394 +391 @@
     }
 
+    if( foreground && !logfile )
+        logfile = stderr;
+
     if( !loaded )
     {
-        printMessage( foreground, TR_MSG_ERR, MY_NAME, "Error loading config file -- exiting.", __FILE__, __LINE__ );
+        printMessage( logfile, TR_MSG_ERR, MY_NAME, "Error loading config file -- exiting.", __FILE__, __LINE__ );
         return -1;
     }
@@ -412 +412 @@
         char buf[256];
         tr_snprintf( buf, sizeof( buf ), "Failed to dameonize: %s", tr_strerror( errno ) );
-        printMessage( foreground, TR_MSG_ERR, MY_NAME, buf, __FILE__, __LINE__ );
+        printMessage( logfile, TR_MSG_ERR, MY_NAME, buf, __FILE__, __LINE__ );
         exit( 1 );
     }
@@ -458 +458 @@
         tr_wait_msec( 1000 ); /* sleep one second */
         dtr_watchdir_update( watchdir );
-        pumpLogMessages( foreground );
+        pumpLogMessages( logfile );
     }
 

trunk/daemon/transmission-daemon.1

@@ -27 +27 @@
 .Op Fl V
 .Op Fl w Ar download-dir
+.Op Fl e Ar logfile
 .Ek
 .Sh DESCRIPTION
@@ -115 +116 @@
 .It Fl w Fl -download-dir
 Where to store downloaded data.
+.It Fl e Fl -logfile
+Where to store transmission's log messages.
 .El
 .Sh ENVIRONMENT