Changeset 10870 for branches

Timestamp:

Jun 26, 2010, 5:19:02 PM (12 years ago)

Author:

Longinus00

Message:

(2.0x web) Improve upon r10773 fix for #3296

Location:

branches/2.0x/web/javascript

Files:

• torrent.js (modified) (1 diff)
• transmission.js (modified) (1 diff)

branches/2.0x/web/javascript/torrent.js

@@ -89 +89 @@
                 top_e._torrent = this;
                 var element = $(top_e);
-                $(element).bind('dblclick', function(e) { transmission.toggleInspector(); });
+                $(element).bind('dblclick', function(e) { transmission.toggleInspector(); });
                 element._torrent = this;
+                element._id = this._id;
                 this._element = element;
                 this._controller = controller;

branches/2.0x/web/javascript/transmission.js

@@ -1566 +1566 @@
                                 var e = torrent.element();
                                 if( e ) {
-                                        var row_index = tr.getTorrentIndex(tr._rows, torrent);
-                                        //if torrent is not currently visible then delete a hidden row
-                                        //otherwise the row model gets corrupted because no row gets deleted
-                                        if( row_index == null ) row_index = tr._rows.length - 1;
+                                        var row_index;
+                                        for( var i=0, row; row = tr._rows[i]; ++i ) {
+                                                if( row._id == torrent._id )
+                                                {
+                                                        row_index = i;
+                                                        e = tr._rows[row_index];
+                                                        break;
+                                                }
+                                        }
                                         delete e._torrent; //remove circular refernce to help IE garbage collect
                                         tr._rows.splice(row_index, 1)