Changeset 11106

Timestamp:

Aug 4, 2010, 5:23:25 AM (12 years ago)

Author:

Longinus00

Message:

(2.0x) #3185: Number on drop-down menu "Activity" - "Active" seems does not follow a change in torrent status correctly

Location:

branches/2.0x

Files:

• gtk/details.c (modified) (1 diff)
• gtk/filter.c (modified) (4 diffs)
• gtk/tr-core.c (modified) (11 diffs)
• gtk/tr-core.h (modified) (1 diff)
• libtransmission/transmission.h (modified) (1 diff)

branches/2.0x/gtk/details.c

@@ -2153 +2153 @@
             di->trackers = NULL;
             di->tracker_buffer = NULL;
-            tr_core_torrent_changed( di->core, tr_torrentId( tor ) );
         }
 

branches/2.0x/gtk/filter.c

@@ -590 +590 @@
     ACTIVITY_FILTER_ACTIVE,
     ACTIVITY_FILTER_PAUSED,
+    ACTIVITY_FILTER_FINISHED,
     ACTIVITY_FILTER_QUEUED,
     ACTIVITY_FILTER_VERIFYING,
@@ -634 +635 @@
             return st->activity == TR_STATUS_STOPPED;
 
+        case ACTIVITY_FILTER_FINISHED:
+            return st->finished == TRUE;
+
         case ACTIVITY_FILTER_QUEUED:
-            return FALSE;
+            return st->activity == TR_STATUS_CHECK_WAIT;
 
         case ACTIVITY_FILTER_VERIFYING:
-            return ( st->activity == TR_STATUS_CHECK_WAIT )
-                || ( st->activity == TR_STATUS_CHECK );
+            return st->activity == TR_STATUS_CHECK ;
 
         case ACTIVITY_FILTER_ERROR:
@@ -646 +649 @@
         default: /* ACTIVITY_FILTER_ALL */
             return TRUE;
-
     }
 }
@@ -721 +723 @@
         { ACTIVITY_FILTER_SEEDING, N_( "Seeding" ), GTK_STOCK_GO_UP },
         { ACTIVITY_FILTER_PAUSED, N_( "Paused" ), GTK_STOCK_MEDIA_PAUSE },
+        { ACTIVITY_FILTER_FINISHED, N_( "Finished" ), NULL },
         { ACTIVITY_FILTER_QUEUED, N_( "Queued" ), NULL },
         { ACTIVITY_FILTER_VERIFYING, N_( "Verifying" ), GTK_STOCK_REFRESH },

branches/2.0x/gtk/tr-core.c

@@ -483 +483 @@
 }
 
+static char *
+torrentTrackerString( tr_torrent * tor )
+{
+    int i;
+    GString * str = g_string_new( NULL );
+    const tr_info * inf = tr_torrentInfo( tor );
+
+    for( i = 0; i < inf->trackerCount; ++i )
+    {
+        const tr_tracker_info * t = &inf->trackers[i];
+        g_string_append( str, t->announce );
+    }
+
+    return g_string_free( str, FALSE );
+}
+
 #ifdef HAVE_GIO
 
@@ -710 +726 @@
                       G_TYPE_DOUBLE,    /* tr_stat.pieceUploadSpeed */
                       G_TYPE_DOUBLE,    /* tr_stat.pieceDownloadSpeed */
-                      G_TYPE_INT };     /* tr_stat.status */
+                      G_TYPE_INT,       /* tr_stat.activity */
+                      G_TYPE_UCHAR,     /* tr_stat.finished */
+                      G_TYPE_CHAR,      /* tr_priority_t */
+                      G_TYPE_STRING };  /* concatenated trackers string */
 
     p = self->priv = G_TYPE_INSTANCE_GET_PRIVATE( self,
@@ -844 +863 @@
     tr_torrent *    tor = tr_torrent_handle( gtor );
     char *          collated = doCollate( inf->name );
+    char *          trackers = torrentTrackerString( tor );
     GtkListStore *  store = GTK_LIST_STORE( tr_core_model( self ) );
     GtkTreeIter     unused;
@@ -855 +875 @@
                                        MC_SPEED_DOWN,    st->pieceDownloadSpeed,
                                        MC_ACTIVITY,      st->activity,
+                                       MC_FINISHED,      st->finished,
+                                       MC_PRIORITY,      tr_torrentGetPriority( tor ),
+                                       MC_TRACKERS,      trackers,
                                        -1 );
 
@@ -863 +886 @@
     g_object_unref( G_OBJECT( gtor ) );
     g_free( collated );
+    g_free( trackers );
 }
 
@@ -1243 +1267 @@
 {
     int oldActivity, newActivity;
+    tr_bool oldFinished, newFinished;
+    tr_priority_t oldPriority, newPriority;
+    char * oldTrackers, * newTrackers;
     double oldUpSpeed, newUpSpeed;
     double oldDownSpeed, newDownSpeed;
     const tr_stat * st;
     TrTorrent * gtor;
+    tr_torrent * tor;
 
     /* get the old states */
@@ -1252 +1280 @@
                         MC_TORRENT, &gtor,
                         MC_ACTIVITY, &oldActivity,
+                        MC_FINISHED, &oldFinished,
+                        MC_PRIORITY, &oldPriority,
+                        MC_TRACKERS, &oldTrackers,
                         MC_SPEED_UP, &oldUpSpeed,
                         MC_SPEED_DOWN, &oldDownSpeed,
@@ -1257 +1288 @@
 
     /* get the new states */
-    st = tr_torrentStat( tr_torrent_handle( gtor ) );
+    tor = tr_torrent_handle( gtor );
+    st = tr_torrentStat( tor );
     newActivity = st->activity;
+    newFinished = st->finished;
+    newPriority = tr_torrentGetPriority( tor );
+    newTrackers = torrentTrackerString( tor );
     newUpSpeed = st->pieceUploadSpeed;
     newDownSpeed = st->pieceDownloadSpeed;
@@ -1265 +1300 @@
        so don't do it unless something's actually changed... */
     if( ( newActivity != oldActivity ) ||
+        || ( newFinished != oldFinished )
+        || ( newPriority != oldPriority )
+        || tr_strcmp( oldTrackers, newTrackers )
         ( (int)(newUpSpeed*10.0) != (int)(oldUpSpeed*10.0) ) ||
         ( (int)(newDownSpeed*10.0) != (int)(oldDownSpeed*10.0) ) )
@@ -1270 +1308 @@
         gtk_list_store_set( GTK_LIST_STORE( model ), iter,
                             MC_ACTIVITY, newActivity,
+                            MC_FINISHED, newFinished,
+                            MC_PRIORITY, newPriority,
+                            MC_TRACKERS, newTrackers,
                             MC_SPEED_UP, newUpSpeed,
                             MC_SPEED_DOWN, newDownSpeed,
@@ -1277 +1318 @@
     /* cleanup */
     g_object_unref( gtor );
+    g_free( newTrackers );
+    g_free( oldTrackers );
     return FALSE;
 }

branches/2.0x/gtk/tr-core.h

@@ -214 +214 @@
     MC_SPEED_DOWN,
     MC_ACTIVITY,
+    MC_FINISHED,
+    MC_PRIORITY,
+    MC_TRACKERS,
     MC_ROW_COUNT
 };

branches/2.0x/libtransmission/transmission.h

@@ -1717 +1717 @@
     char errorString[512];
 
-    /** When tr_stat.status is TR_STATUS_CHECK or TR_STATUS_CHECK_WAIT,
+    /** When tr_stat.activity is TR_STATUS_CHECK or TR_STATUS_CHECK_WAIT,
         this is the percentage of how much of the files has been
         verified.  When it gets to 1, the verify process is done.
         Range is [0..1]
-        @see tr_stat.status */
+        @see tr_stat.activity */
     float    recheckProgress;