Changeset 11258

Timestamp:

Sep 23, 2010, 5:05:40 PM (12 years ago)

Author:

charles

Message:

(trunk gtk) fix a minor UMR error that Valgrind found

File:

• trunk/gtk/tr-core.c (modified) (1 diff)

trunk/gtk/tr-core.c

@@ -1590 +1590 @@
 readResponseIdle( void * vresponse )
 {
-    GByteArray * response;
     tr_benc top;
     int64_t intVal;
-    int tag;
-    struct pending_request_data * data;
-
-    response = vresponse;
+    GByteArray * response = vresponse;
+
     tr_jsonParse( NULL, response->data, response->len, &top, NULL );
-    tr_bencDictFindInt( &top, "tag", &intVal );
-    tag = (int)intVal;
-
-    data = g_hash_table_lookup( pendingRequests, &tag );
-    if( data && data->responseFunc )
-        (*data->responseFunc)(data->core, &top, data->responseFuncUserData );
+
+    if( tr_bencDictFindInt( &top, "tag", &intVal ) )
+    {
+        const int tag = (int)intVal;
+        struct pending_request_data * data = g_hash_table_lookup( pendingRequests, &tag );
+        if( data ) {
+            if( data->responseFunc )
+                (*data->responseFunc)(data->core, &top, data->responseFuncUserData );
+            g_hash_table_remove( pendingRequests, &tag );
+        }
+    }
 
     tr_bencFree( &top );
-    g_hash_table_remove( pendingRequests, &tag );
     g_byte_array_free( response, TRUE );
     return FALSE;