Changeset 11334

Timestamp:

Oct 17, 2010, 10:28:28 PM (12 years ago)

Author:

charles

Message:

(trunk libT) #3584 "minor valgrind warning in makemeta.c" -- fixed.

File:

• trunk/libtransmission/makemeta.c (modified) (2 diffs)

trunk/libtransmission/makemeta.c

@@ -295 +295 @@
              tr_benc *                        uninitialized_path )
 {
-    const char * pch, *prev;
-    size_t       topLen;
-    int          n;
+    size_t offset;
 
     /* get the file size */
@@ -303 +301 @@
 
     /* how much of file->filename to walk past */
-    topLen = strlen( topFile );
-    if( topLen>0 && topFile[topLen-1]!=TR_PATH_DELIMITER )
-        ++topLen; /* +1 for the path delimiter */
+    offset = strlen( topFile );
+    if( offset>0 && topFile[offset-1]!=TR_PATH_DELIMITER )
+        ++offset; /* +1 for the path delimiter */
 
     /* build the path list */
-    n = 1;
-    for( pch = file->filename + topLen; *pch; ++pch )
-        if( *pch == TR_PATH_DELIMITER )
-            ++n;
-    tr_bencInitList( uninitialized_path, n );
-    for( prev = pch = file->filename + topLen; ; ++pch )
-    {
-        char buf[TR_PATH_MAX];
-
-        if( *pch && *pch != TR_PATH_DELIMITER )
-            continue;
-
-        memcpy( buf, prev, pch - prev );
-        buf[pch - prev] = '\0';
-
-        tr_bencListAddStr( uninitialized_path, buf );
-
-        prev = pch + 1;
-        if( !*pch )
-            break;
+    tr_bencInitList( uninitialized_path, 0 );
+    if( strlen(file->filename) > offset ) {
+        char * filename = tr_strdup( file->filename + offset );
+        char * walk = filename;
+        const char * token;
+        while(( token = strsep( &walk, TR_PATH_DELIMITER_STR )))
+            tr_bencListAddStr( uninitialized_path, token );
+        tr_free( filename );
     }
 }