Changeset 11783

Timestamp:

Jan 29, 2011, 6:59:23 PM (12 years ago)

Author:

jordan

Message:

(trunk libT) #3950 "use libevent's cached gettimeofday() value when appropriate" -- fixed.

Location:

trunk/libtransmission

Files:

• peer-io.c (modified) (4 diffs)
• peer-mgr.c (modified) (2 diffs)
• session.c (modified) (1 diff)
• session.h (modified) (1 diff)

trunk/libtransmission/peer-io.c

@@ -87 +87 @@
 };
 
+
 /***
 ****
@@ -100 +101 @@
         const unsigned int payload = MIN( next->length, bytes_transferred );
         const unsigned int overhead = guessPacketOverhead( payload );
-        const uint64_t now = tr_time_msec( );
+        const uint64_t now = tr_sessionGetTimeMsec( io->session );
 
         tr_bandwidthUsed( &io->bandwidth, TR_UP, payload, next->isPieceData, now );
@@ -140 +141 @@
     if( io->canRead )
     {
+        const uint64_t now = tr_sessionGetTimeMsec( io->session );
+
         tr_sessionLock( session );
 
@@ -149 +152 @@
             const size_t used = oldLen - evbuffer_get_length( io->inbuf );
             const unsigned int overhead = guessPacketOverhead( used );
-            const uint64_t now = tr_time_msec( );
 
             assert( tr_isPeerIo( io ) );

trunk/libtransmission/peer-mgr.c

@@ -2751 +2751 @@
 rechokePulse( int foo UNUSED, short bar UNUSED, void * vmgr )
 {
-    uint64_t now;
     tr_torrent * tor = NULL;
     tr_peerMgr * mgr = vmgr;
+    const uint64_t now = tr_sessionGetTimeMsec( mgr->session );
+
     managerLock( mgr );
 
-    now = tr_time_msec( );
     while(( tor = tr_torrentNext( mgr->session, tor ))) {
         if( tor->isRunning ) {
@@ -3114 +3114 @@
     tr_peerMgr * mgr = vmgr;
     const time_t now_sec = tr_time( );
-    const uint64_t now_msec = tr_time_msec( );
+    const uint64_t now_msec = tr_sessionGetTimeMsec( mgr->session );
 
     /**

trunk/libtransmission/session.c

@@ -2559 +2559 @@
     session->curl_easy_config_func = func;
 }
+
+/***
+****
+***/
+
+uint64_t
+tr_sessionGetTimeMsec( tr_session * session )
+{
+    struct timeval tv;
+
+    if( event_base_gettimeofday_cached( session->event_base, &tv ) )
+    {
+        return tr_time_msec( );
+    }
+    else
+    {
+        /* event_base_gettimeofday_cached() might be implemented using
+           clock_gettime(CLOCK_MONOTONIC), so calculate the offset to
+           real time... */
+        static uint64_t offset;
+        static tr_bool offset_calculated = FALSE;
+
+        const uint64_t val = (uint64_t) tv.tv_sec * 1000 + ( tv.tv_usec / 1000 );
+
+        if( !offset_calculated )
+        {
+            offset = tr_time_msec() - val;
+            offset_calculated = TRUE;
+        }
+
+        return val + offset;
+    }
+}

trunk/libtransmission/session.h

@@ -306 +306 @@
 
 
+/**
+ * Tries to use libevent's cached timeval so we can avoid excessive calls
+ * to gettimeofday().
+ *
+ * This isn't for all uses, but should be reasonably accurate when called
+ * near the beginning of a libevent callback.
+ */
+uint64_t tr_sessionGetTimeMsec( tr_session * session );
+
+
 #endif