Changeset 11837


Ignore:
Timestamp:
Feb 6, 2011, 6:50:35 PM (11 years ago)
Author:
jordan
Message:

(trunk gtk) #3866 "Popup menu for file list manipulation" -- removing from the 2.20 milestone

Looking over the 2.20 tickets, this one keeps sticking out. A popup menu may be useful if the "delete files" ticket is accepted in 2.30, but for this release (2.20) it doesn't really add anything new. One lesson from the 2.1x cycle was that features are a harder to remove than to add. So I'm going to hold off on adding this feature until it has a clear raison d'être.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/gtk/file-list.c

    r11804 r11837  
    681681}
    682682
     683#if 0
    683684static void
    684685fileMenuSetDownload( GtkWidget * item, gpointer gdata )
     
    772773                    event ? event->time : gtk_get_current_event_time( ) );
    773774}
     775#endif
    774776
    775777static gboolean
     
    878880        handled = onViewPathToggled( treeview, col, path, data );
    879881    }
     882#if 0
    880883    else if( event->type == GDK_BUTTON_PRESS && event->button == 3
    881884             && getAndSelectEventPath( treeview, event, &col, &path ) )
     
    888891        }
    889892    }
     893#endif
    890894
    891895    gtk_tree_path_free( path );
     
    893897}
    894898
     899#if 0
    895900static gboolean
    896901onViewPopupMenu( GtkWidget * w, gpointer gdata )
     
    899904    return TRUE;
    900905}
     906#endif
    901907
    902908GtkWidget *
     
    927933    g_signal_connect( view, "button-press-event",
    928934                      G_CALLBACK( onViewButtonPressed ), data );
     935#if 0
    929936    g_signal_connect( view, "popup-menu",
    930937                      G_CALLBACK( onViewPopupMenu ), data );
     938#endif
    931939    g_signal_connect( view, "row_activated",
    932940                      G_CALLBACK( onRowActivated ), data );
Note: See TracChangeset for help on using the changeset viewer.