Changeset 12419 for trunk/libtransmission/rpcimpl.c

Timestamp:

May 9, 2011, 4:13:14 AM (11 years ago)

Author:

jordan

Message:

(trunk libT) torrent-get CPU optimization.

Move the tr_torrentStat() call outside of the addField() loop so that it's only called once instead of N times.

File:

• trunk/libtransmission/rpcimpl.c (modified) (2 diffs)

trunk/libtransmission/rpcimpl.c

@@ -464 +464 @@
 
 static void
-addField( const tr_torrent * tor, tr_benc * d, const char * key )
-{
-    const tr_info * inf = tr_torrentInfo( tor );
-    const tr_stat * st = tr_torrentStat( (tr_torrent*)tor );
+addField( const tr_torrent * const tor,
+          const tr_info    * const inf,
+          const tr_stat    * const st,
+          tr_benc          * const d,
+          const char       * const key )
+{
     const size_t keylen = strlen( key );
 
@@ -635 +637 @@
 
 static void
-addInfo( const tr_torrent * tor,
-         tr_benc *          d,
-         tr_benc *          fields )
-{
-    int          i;
-    const int    n = tr_bencListSize( fields );
+addInfo( const tr_torrent * tor, tr_benc * d, tr_benc * fields )
+{
     const char * str;
+    const int n = tr_bencListSize( fields );
 
     tr_bencInitDict( d, n );
 
-    for( i = 0; i < n; ++i )
-        if( tr_bencGetStr( tr_bencListChild( fields, i ), &str ) )
-            addField( tor, d, str );
+    if( n > 0 )
+    {
+        int i;
+        const tr_info const * inf = tr_torrentInfo( tor );
+        const tr_stat const * st = tr_torrentStat( (tr_torrent*)tor );
+
+        for( i=0; i<n; ++i )
+            if( tr_bencGetStr( tr_bencListChild( fields, i ), &str ) )
+                addField( tor, inf, st, d, str );
+    }
 }