Changeset 12420

Timestamp:

May 9, 2011, 4:16:49 AM (10 years ago)

Author:

jordan

Message:

(trunk libT) CPU optimization in tr_bandwidthClamp().

Don't call tr_time_msec() if it's not necessary. This was one of the top CPU sinks in profiling, so removing it is a nice improvement in cases when it's not necessary, such as when speed limiting is disabled.

File:

• trunk/libtransmission/bandwidth.c (modified) (3 diffs)

trunk/libtransmission/bandwidth.c

@@ -323 +323 @@
 static unsigned int
 bandwidthClamp( const tr_bandwidth  * b,
-                const uint64_t        now,
+                uint64_t              now,
                 tr_direction          dir,
                 unsigned int          byteCount )
@@ -340 +340 @@
             if( byteCount > 0 )
             {
-                double current = tr_bandwidthGetRawSpeed_Bps( b, now, TR_DOWN );
-                double desired = tr_bandwidthGetDesiredSpeed_Bps( b, TR_DOWN );
-                double r = desired >= 1 ? current / desired : 0;
+                double current;
+                double desired;
+                double r;
+
+                if( now == 0 )
+                    now = tr_time_msec( );
+
+                current = tr_bandwidthGetRawSpeed_Bps( b, now, TR_DOWN );
+                desired = tr_bandwidthGetDesiredSpeed_Bps( b, TR_DOWN );
+                r = desired >= 1 ? current / desired : 0;
 
                      if( r > 1.0 ) byteCount = 0;
@@ -361 +368 @@
                    unsigned int          byteCount )
 {
-    const uint64_t now_msec = tr_time_msec( );
-    return bandwidthClamp( b, now_msec, dir, byteCount );
+    return bandwidthClamp( b, 0, dir, byteCount );
 }