Changeset 12805

Timestamp:

Aug 30, 2011, 9:27:30 PM (12 years ago)

Author:

jordan

Message:

(trunk web) in tr.refilter(), instead of calling the expensive tr.getSelectedRows(), use a cheaper jQuery equivalent.

Location:

trunk/web/javascript

Files:

• torrent-row.js (modified) (1 diff)
• transmission.js (modified) (4 diffs)

trunk/web/javascript/torrent-row.js

@@ -346 +346 @@
 ****/
 
-function TorrentRow(view, controller, torrent, selected)
-{
-        this.initialize(view, controller, torrent, selected);
+function TorrentRow(view, controller, torrent)
+{
+        this.initialize(view, controller, torrent);
 }
 TorrentRow.prototype =
 {
-        initialize: function(view, controller, torrent, selected) {
+        initialize: function(view, controller, torrent) {
                 this._view = view;
                 this._element = view.createRow();
                 this.setTorrent(controller, torrent);
-                if (selected)
-                        this.setSelected(selected);
                 this.render(controller);
 

trunk/web/javascript/transmission.js

@@ -1950 +1950 @@
         refilter: function(rebuildEverything)
         {
-                var i, e, id, t, row, tmp, sel, rows, clean_rows, dirty_rows,
+                var i, e, id, t, row, tmp, rows, clean_rows, dirty_rows,
                     sort_mode = this[Prefs._SortMethod],
                     sort_direction = this[Prefs._SortDirection],
@@ -1957 +1957 @@
                     filter_tracker = this.filterTracker,
                     renderer = this.torrentRenderer,
-                    list = this._torrent_list;
+                    list = this._torrent_list,
+                    old_sel_count = $(list).children('.selected').length;
+
 
                 clearTimeout(this.refilterTimer);
                 delete this.refilterTimer;
-
-                // build a temporary lookup table of selected torrent ids
-                sel = { };
-                for (i=0; row=this._rows[i]; ++i)
-                        if (row.isSelected())
-                                sel[row.getTorrentId()] = row;
 
                 if (rebuildEverything) {
@@ -2008 +2004 @@
                         t = this._torrents[id];
                         if (t && t.test(filter_mode, filter_text, filter_tracker)) {
-                                var s = t.getId() in sel;
-                                row = new TorrentRow(renderer, this, t, s);
+                                row = new TorrentRow(renderer, this, t);
                                 row.getElement().row = row;
                                 dirty_rows.push(row);
@@ -2064 +2059 @@
                 this.updateStatusbar();
                 this.refreshFilterButton();
-                if (Object.keys(sel).length !== this.getSelectedRows().length)
+                if (old_sel_count !== $(list).children('.selected').length)
                         this.selectionChanged();
         },