Changeset 12837

Timestamp:

Sep 3, 2011, 7:15:03 PM (12 years ago)

Author:

jordan

Message:

avoid unnecessary callback closures in the inspector.

File:

• trunk/web/javascript/inspector.js (modified) (5 diffs)

trunk/web/javascript/inspector.js

@@ -38 +38 @@
     },
 
-    onTabClicked = function (ev, tab) {
+    onTabClicked = function (ev) {
+        var tab = ev.currentTarget;
+
         if (isMobileDevice)
             ev.stopPropagation();
@@ -204 +206 @@
         var i, row, rows=[], t=data.file_torrent;
         if (!t)
-                return;
+            return;
         for (i=0; row=data.file_rows[i]; ++i)
             if (row.isEditable() && (t.getFile(i).wanted !== s))
@@ -213 +215 @@
 
     changeFileCommand = function(rows, command) {
-        var torrentId = data.file_torrent.getId();
-        var rowIndices = $.map(rows.slice(0),function (row) {return row.getIndex();});
+        var torrentId = data.file_torrent.getId();
+        var rowIndices = $.map(rows.slice(0),function (row) {return row.getIndex();});
         data.controller.changeFileCommand(torrentId, rowIndices, command);
     },
 
-    onFileWantedToggled = function(row, want) {
+    onFileWantedToggled = function(ev, row, want) {
         changeFileCommand([row], want?'files-wanted':'files-unwanted');
     },
 
-    onFilePriorityToggled = function(row, priority) {
+    onFilePriorityToggled = function(ev, row, priority) {
         var command;
         switch(priority) {
@@ -261 +263 @@
             row = data.file_rows[i] = new FileRow(tor, i);
             fragment.appendChild(row.getElement());
-                    $(row).bind('wantedToggled',function(e,row,want) {onFileWantedToggled(row,want);});
-                    $(row).bind('priorityToggled',function(e,row,priority) {onFilePriorityToggled(row,priority);});
+                    $(row).bind('wantedToggled',onFileWantedToggled);
+                    $(row).bind('priorityToggled',onFilePriorityToggled);
         }
 
@@ -451 +453 @@
         data.controller = controller;
 
-        $('.inspector_tab').click(function (e) {onTabClicked(e, this);});
-        $('#files_select_all').live('click', function(e) { filesSelectAllClicked(); });
-        $('#files_deselect_all').live('click', function(e) { filesDeselectAllClicked(); });
+        $('.inspector_tab').click(onTabClicked);
+        $('#files_select_all').click(filesSelectAllClicked);
+        $('#files_deselect_all').click(filesDeselectAllClicked);
 
         data.elements.info_page      = $('#inspector_tab_info_container')[0];