Changeset 1322

Timestamp:

Jan 9, 2007, 1:09:23 AM (15 years ago)

Author:

livings124

Message:

simplify queueing core a bit...will make things easier later

Location:

trunk/macosx

Files:

• Controller.h (modified) (1 diff)
• Controller.m (modified) (11 diffs)
• Torrent.m (modified) (3 diffs)

trunk/macosx/Controller.h

@@ -173 +173 @@
 - (void) setQuickRatioGlobal: (id) sender;
 
+#warning simplify?
 - (void) checkWaitingForStopped: (NSNotification *) notification;
-- (void) checkToStartWaiting: (Torrent *) finishedTorrent;
 - (void) torrentStartSettingChange: (NSNotification *) notification;
 - (void) globalStartSettingChange: (NSNotification *) notification;
 
 - (void) torrentStoppedForRatio: (NSNotification *) notification;
-
-- (void) attemptToStartAuto: (Torrent *) torrent;
-- (void) attemptToStartMultipleAuto: (NSArray *) torrents;
+- (void) updateTorrentsInQueue;
 
 - (void) changeAutoImport;

trunk/macosx/Controller.m

@@ -598 +598 @@
         [torrent setDownloadFolder: folder];
         [torrent update];
-        [self attemptToStartAuto: torrent];
         
         [fTorrents addObject: torrent];
@@ -604 +603 @@
     }
 
-    [self updateUI: nil];
-    [self applyFilter: nil];
-    
-    [self updateTorrentHistory];
+    [self updateTorrentsInQueue];
 }
 
@@ -662 +658 @@
         [torrent setDownloadFolder: [[openPanel filenames] objectAtIndex: 0]];
         [torrent update];
-        [self attemptToStartAuto: torrent];
         
         [fTorrents addObject: torrent];
         
-        [self updateUI: nil];
-        [self applyFilter: nil];
+        [self updateTorrentsInQueue];
     }
     
@@ -792 +786 @@
         [torrent setWaitToStart: YES];
     
-    [self attemptToStartMultipleAuto: torrents];
-    
-    [self updateUI: nil];
-    [self applyFilter: nil];
-    [self updateTorrentHistory];
+    [self updateTorrentsInQueue];
 }
 
@@ -1157 +1147 @@
     [fInfoController updateInfoStats];
     
-    [self applyFilter: nil];
-    [self checkToStartWaiting: torrent];
+    [self updateTorrentsInQueue];
     
     if ([fDefaults boolForKey: @"PlayDownloadSound"])
@@ -1578 +1567 @@
 - (void) checkWaitingForStopped: (NSNotification *) notification
 {
-    [self checkToStartWaiting: [notification object]];
+    [self updateTorrentsInQueue];
     
     [self updateUI: nil];
@@ -1585 +1574 @@
 }
 
-- (void) checkToStartWaiting: (Torrent *) finishedTorrent
-{
-    //don't try to start a transfer if there should be none waiting
-    if (![fDefaults boolForKey: @"Queue"])
-        return;
-
-    int desiredActive = [fDefaults integerForKey: @"QueueDownloadNumber"];
-    
-    NSEnumerator * enumerator = [fTorrents objectEnumerator];
-    Torrent * torrent, * torrentToStart = nil;
-    while ((torrent = [enumerator nextObject]))
-    {
-        //ignore the torrent just stopped
-        if (torrent == finishedTorrent)
-            continue;
-    
-        if ([torrent isActive])
-        {
-            if (![torrent isSeeding] && ![torrent isError])
-            {
-                desiredActive--;
-                if (desiredActive <= 0)
-                    return;
-            }
-        }
-        else
-        {
-            //use as next if it is waiting to start and either no previous or order value is lower
-            if ([torrent waitingToStart] && (!torrentToStart
-                || [[torrentToStart orderValue] compare: [torrent orderValue]] == NSOrderedDescending))
-                torrentToStart = torrent;
-        }
-    }
-    
-    //since it hasn't returned, the queue amount has not been met
-    if (torrentToStart)
-    {
-        [torrentToStart startTransfer];
-        
-        [self updateUI: nil];
-        [self applyFilter: nil];
-        [self updateTorrentHistory];
-    }
-}
-
 - (void) torrentStartSettingChange: (NSNotification *) notification
 {
-    [self attemptToStartMultipleAuto: [notification object]];
-
-    [self updateUI: nil];
-    [self applyFilter: nil];
-    [self updateTorrentHistory];
+    [self updateTorrentsInQueue];
 }
 
 - (void) globalStartSettingChange: (NSNotification *) notification
 {
-    [self attemptToStartMultipleAuto: fTorrents];
-    
-    [self updateUI: nil];
-    [self applyFilter: nil];
-    [self updateTorrentHistory];
+    [self updateTorrentsInQueue];
 }
 
@@ -1667 +1603 @@
 - (void) attemptToStartAuto: (Torrent *) torrent
 {
-    [self attemptToStartMultipleAuto: [NSArray arrayWithObject: torrent]];
+    [self updateTorrentsInQueue];
 }
 
 //will try to start, taking into consideration the start preference
-- (void) attemptToStartMultipleAuto: (NSArray *) torrents
+- (void) updateTorrentsInQueue
 {
     if (![fDefaults boolForKey: @"Queue"])
     {
-        NSEnumerator * enumerator = [torrents objectEnumerator];
+        NSEnumerator * enumerator = [fTorrents objectEnumerator];
         Torrent * torrent;
         while ((torrent = [enumerator nextObject]))
@@ -1698 +1634 @@
     
     //sort torrents by order value
-    NSArray * sortedTorrents;
-    if ([torrents count] > 1 && desiredActive > 0)
-    {
-        NSSortDescriptor * orderDescriptor = [[[NSSortDescriptor alloc] initWithKey:
-                                                    @"orderValue" ascending: YES] autorelease];
-        NSArray * descriptors = [[NSArray alloc] initWithObjects: orderDescriptor, nil];
-        
-        sortedTorrents = [torrents sortedArrayUsingDescriptors: descriptors];
-        [descriptors release];
-    }
-    else
-        sortedTorrents = torrents;
+    NSSortDescriptor * orderDescriptor = [[[NSSortDescriptor alloc] initWithKey:
+                                                @"orderValue" ascending: YES] autorelease];
+    NSArray * descriptors = [[NSArray alloc] initWithObjects: orderDescriptor, nil];
+        
+    NSArray * sortedTorrents = [fTorrents sortedArrayUsingDescriptors: descriptors];
+    [descriptors release];
 
     enumerator = [sortedTorrents objectEnumerator];
@@ -1721 +1651 @@
             {
                 [torrent startTransfer];
-                desiredActive--;
+                if ([torrent isActive])
+                    desiredActive--;
             }
             else
@@ -1729 +1660 @@
         }
     }
+    
+    [self updateUI: nil];
+    [self applyFilter: nil];
+    [self updateTorrentHistory];
 }
 

trunk/macosx/Torrent.m

@@ -259 +259 @@
         }
         
+        fStat = tr_torrentStat(fHandle);
         [[NSNotificationCenter defaultCenter] postNotificationName: @"TorrentFinishedDownloading" object: self];
     }
@@ -447 +448 @@
     
     if (![self isActive] && [self alertForVolumeAvailable] && [self alertForRemainingDiskSpace])
+    {
         tr_torrentStart(fHandle);
+        [self update];
+    }
 }
 
@@ -459 +463 @@
     
         tr_torrentStop(fHandle);
+        [self update];
 
         if (!wasSeeding)