Changeset 13433 for trunk/macosx/QuickLookPlugin/GeneratePreviewForURL.m

Timestamp:

Aug 12, 2012, 8:14:26 PM (10 years ago)

Author:

livings124

Message:

better spacing of the file/tracker/webseed list in Quick Look

File:

• trunk/macosx/QuickLookPlugin/GeneratePreviewForURL.m (modified) (3 diffs)

trunk/macosx/QuickLookPlugin/GeneratePreviewForURL.m

@@ -59 +59 @@
     
     const NSUInteger width = 32;
-    [htmlString appendFormat: @"<h2><img class=\"icon\" src=\"%@\" width=\"%ld\" height=\"%ld\">%@</h2>", generateIconData(fileTypeString, width, allImgProps), width, width, name];
+    [htmlString appendFormat: @"<h2><img class=\"icon\" src=\"%@\" width=\"%ld\" height=\"%ld\" />%@</h2>", generateIconData(fileTypeString, width, allImgProps), width, width, name];
     
     NSString * fileSizeString = [NSString stringForFileSize: inf.totalSize];
@@ -93 +93 @@
     }
     
-    [htmlString appendString: @"<hr/>"];
+    NSMutableArray * lists = [NSMutableArray array];
     
     if (inf.webseedCount > 0)
     {
-        [htmlString appendString: @"<br><br><table>"];
+        NSMutableString * listSection = [NSMutableString string];
+        [listSection appendString: @"<table>"];
         
         NSString * headerTitleString = inf.webseedCount == 1 ? NSLocalizedString(@"1 Web Seed", "quicklook web seed header") : [NSString stringWithFormat: NSLocalizedString(@"%@ Web Seeds", "quicklook web seed header"), [NSString formattedUInteger: inf.webseedCount]];
-        [htmlString appendFormat: @"<tr><th>%@</th></tr>", headerTitleString];
+        [listSection appendFormat: @"<tr><th>%@</th></tr>", headerTitleString];
         
         for (int i = 0; i < inf.webseedCount; ++i)
-            [htmlString appendFormat: @"<tr><td>%s<td></tr>", inf.webseeds[i]];
+            [listSection appendFormat: @"<tr><td>%s<td></tr>", inf.webseeds[i]];
         
-        [htmlString appendString:@"</table>"];
+        [listSection appendString:@"</table>"];
+        
+        [lists addObject: listSection];
     }
     
     if (inf.trackerCount > 0)
     {
-        [htmlString appendString: @"<br><br><table>"];
+        NSMutableString * listSection = [NSMutableString string];
+        [listSection appendString: @"<table>"];
         
         NSString * headerTitleString = inf.trackerCount == 1 ? NSLocalizedString(@"1 Tracker", "quicklook tracker header") : [NSString stringWithFormat: NSLocalizedString(@"%@ Trackers", "quicklook tracker header"), [NSString formattedUInteger: inf.trackerCount]];
-        [htmlString appendFormat: @"<tr><th>%@</th></tr>", headerTitleString];
+        [listSection appendFormat: @"<tr><th>%@</th></tr>", headerTitleString];
         
 #warning handle tiers?
         for (int i = 0; i < inf.trackerCount; ++i)
-            [htmlString appendFormat: @"<tr><td>%s<td></tr>", inf.trackers[i].announce];
+            [listSection appendFormat: @"<tr><td>%s<td></tr>", inf.trackers[i].announce];
         
-        [htmlString appendString:@"</table>"];
+        [listSection appendString:@"</table>"];
+        
+        [lists addObject: listSection];
     }
     
     if (inf.isMultifile)
     {
-        [htmlString appendString: @"<br><br><table>"];
+        NSMutableString * listSection = [NSMutableString string];
+        [listSection appendString: @"<table>"];
         
         NSString * fileTitleString = inf.fileCount == 1 ? NSLocalizedString(@"1 File", "quicklook file header") : [NSString stringWithFormat: NSLocalizedString(@"%@ Files", "quicklook file header"), [NSString formattedUInteger: inf.fileCount]];
-        [htmlString appendFormat: @"<tr><th>%@</th></tr>", fileTitleString];
+        [listSection appendFormat: @"<tr><th>%@</th></tr>", fileTitleString];
         
 #warning display size?
@@ -139 +146 @@
             
             const NSUInteger width = 16;
-            [htmlString appendFormat: @"<tr><td><img class=\"icon\" src=\"%@\" width=\"%ld\" height=\"%ld\">%@<td></tr>", generateIconData([shortenedFilePath pathExtension], width, allImgProps), width, width, shortenedFilePath];
+            [listSection appendFormat: @"<tr><td><img class=\"icon\" src=\"%@\" width=\"%ld\" height=\"%ld\" />%@<td></tr>", generateIconData([shortenedFilePath pathExtension], width, allImgProps), width, width, shortenedFilePath];
         }
         
-        [htmlString appendString:@"</table>"];
+        [listSection appendString:@"</table>"];
+        
+        [lists addObject: listSection];
     }
+    
+    if ([lists count] > 0)
+        [htmlString appendFormat: @"<hr/><br>%@", [lists componentsJoinedByString: @"<br><br>"]];
     
     [htmlString appendString: @"</body></html>"];