Changeset 13718 for trunk/qt/torrent-model.cc

Timestamp:

Dec 29, 2012, 9:05:05 PM (9 years ago)

Author:

jordan

Message:

In TorrentModel?.updateTorrents(), don't call getIds() if we don't need them

File:

• trunk/qt/torrent-model.cc (modified) (2 diffs)

trunk/qt/torrent-model.cc

@@ -139 +139 @@
 {
     QList<Torrent*> newTorrents;
-    QSet<int> oldIds( getIds( ) );
+    QSet<int> oldIds;
     QSet<int> addIds;
     QSet<int> newIds;
     int updatedCount = 0;
+
+    if ( isCompleteList )
+      oldIds = getIds( );
 
     if( tr_variantIsList( torrents ) )
@@ -247 +250 @@
 
 QSet<int>
-TorrentModel :: getIds( ) const
-{
-    QSet<int> ids;
-    foreach( const Torrent * tor, myTorrents )
-        ids.insert( tor->id( ) );
-    return ids;
+TorrentModel :: getIds () const
+{
+  QSet<int> ids;
+
+  ids.reserve (myTorrents.size());
+  foreach (const Torrent * tor, myTorrents)
+    ids.insert (tor->id());
+
+  return ids;
 }