Changeset 13881

Timestamp:

Jan 27, 2013, 6:19:33 AM (9 years ago)

Author:

jordan

Message:

(libT) #5259 'Minor memory leak in tr_torrentDeleteLocalData()' -- fixed.

File:

• trunk/libtransmission/torrent.c (modified) (1 diff)

trunk/libtransmission/torrent.c

@@ -2831 +2831 @@
             for (;;) {
                 char * parent = tr_dirname (dir);
-                if (tr_is_same_file (top, parent) || !strcmp (top, parent)) {
-                    if (tr_ptrArrayFindSorted (&folders, dir, vstrcmp) == NULL) {
-                        tr_ptrArrayInsertSorted (&folders, tr_strdup (dir), vstrcmp);
-                    }
-                    break;
-                }
-                tr_free (dir);
+                const bool done_walking = tr_is_same_file (top, parent) || !strcmp (top, parent);
+                if (done_walking && tr_ptrArrayFindSorted (&folders, dir, vstrcmp))
+                  tr_ptrArrayInsertSorted (&folders, dir, vstrcmp); /* folders assumes ownership of dir */
+                else
+                  tr_free (dir);
                 dir = parent;
+                if (done_walking)
+                  break;
             }
         }