Changeset 13939

Timestamp:

Feb 3, 2013, 12:31:44 PM (8 years ago)

Author:

jordan

Message:

(qt) plug a handful of minor memory leaks

Location:

trunk/qt

Files:

• filterbar.cc (modified) (6 diffs)
• mainwin.cc (modified) (6 diffs)

trunk/qt/filterbar.cc

@@ -227 +227 @@
 {
   FilterBarComboBox * c = new FilterBarComboBox (this);
-  FilterBarComboBoxDelegate * delegate = new FilterBarComboBoxDelegate (0, c);
+  FilterBarComboBoxDelegate * delegate = new FilterBarComboBoxDelegate (this, c);
   c->setItemDelegate (delegate);
 
@@ -234 +234 @@
   QIcon blankIcon (blankPixmap);
 
-  QStandardItemModel * model = new QStandardItemModel;
+  QStandardItemModel * model = new QStandardItemModel (this);
 
   QStandardItem * row = new QStandardItem (tr ("All"));
@@ -393 +393 @@
 {
   FilterBarComboBox * c = new FilterBarComboBox (this);
-  FilterBarComboBoxDelegate * delegate = new FilterBarComboBoxDelegate (0, c);
+  FilterBarComboBoxDelegate * delegate = new FilterBarComboBoxDelegate (this, c);
   c->setItemDelegate (delegate);
 
@@ -427 +427 @@
   const int hmargin = qMax (int (HIG::PAD), style ()->pixelMetric (QStyle::PM_LayoutHorizontalSpacing));
 
-  myCountLabel = new QLabel;
+  myCountLabel = new QLabel (this);
   h->setSpacing (0);
   h->setContentsMargins (2, 2, 2, 2);
@@ -437 +437 @@
   h->addSpacing (hmargin);
 
-  myTrackerModel = new QStandardItemModel;
+  myTrackerModel = new QStandardItemModel (this);
   myTrackerCombo = createTrackerCombo (myTrackerModel);
   h->addWidget (myTrackerCombo, 1);
@@ -446 +446 @@
   connect (myLineEdit, SIGNAL (textChanged (QString)), this, SLOT (onTextChanged (QString)));
 
-  QPushButton * p = new QPushButton;
+  QPushButton * p = new QPushButton (this);
   QIcon icon = QIcon::fromTheme ("edit-clear", style ()->standardIcon (QStyle::SP_DialogCloseButton));
   int iconSize = style ()->pixelMetric (QStyle::PM_SmallIconSize);

trunk/qt/mainwin.cc

@@ -233 +233 @@
   connect (myAltSpeedAction, SIGNAL (triggered ()), this, SLOT (toggleSpeedMode ()));
 
-  QMenu * menu = new QMenu ();
+  QMenu * menu = new QMenu (this);
   menu->addAction (ui.action_OpenFile);
   menu->addAction (ui.action_AddURL);
@@ -430 +430 @@
     a->addAction (ui.action_SessionRatio);
     a->addAction (ui.action_SessionTransfer);
-    m = new QMenu ();
+    m = new QMenu (this);
     m->addAction (ui.action_TotalRatio);
     m->addAction (ui.action_TotalTransfer);
@@ -462 +462 @@
   stockRatios << 0.25 << 0.50 << 0.75 << 1 << 1.5 << 2 << 3;
 
-  menu = new QMenu;
+  menu = new QMenu (this);
   sub = menu->addMenu (tr ("Limit Download Speed"));
 
@@ -1458 +1458 @@
   menu->addAction (ui.action_OpenFolder);
 
-  QAction * sep = new QAction (this);
+  QAction * sep = new QAction (menu);
   sep->setSeparator (true);
   menu->addAction (sep);
@@ -1471 +1471 @@
   menu->addAction (ui.action_Pause);
 
-  sep = new QAction (this);
+  sep = new QAction (menu);
   sep->setSeparator (true);
   menu->addAction (sep);
@@ -1478 +1478 @@
   menu->addAction (ui.action_CopyMagnetToClipboard);
 
-  sep = new QAction (this);
+  sep = new QAction (menu);
   sep->setSeparator (true);
   menu->addAction (sep);