Changeset 14009

Timestamp:

Feb 10, 2013, 7:36:13 PM (8 years ago)

Author:

jordan

Message:

(libT) restore the RPC download-dir-free-space argument to avoid unscheduled breakage. Document the timetable for its removal in rpc-spec.txt.

Location:

trunk

Files:

• extras/rpc-spec.txt (modified) (1 diff)
• libtransmission/quark.c (modified) (1 diff)
• libtransmission/quark.h (modified) (1 diff)
• libtransmission/rpc-test.c (modified) (1 diff)
• libtransmission/rpcimpl.c (modified) (3 diffs)

trunk/extras/rpc-spec.txt

@@ -759 +759 @@
          |         | yes       |                      | new method "torrent-start-now"
    ------+---------+-----------+--------------------------+-------------------------------
-   15    | 2.80    |        NO | session-get          | removed arg "download-dir-free-space"
-         |         | yes       | torrent-get          | new arg "etaIdle"
+   15    | 2.80    | yes       | torrent-get          | new arg "etaIdle"
          |         | yes       | torrent-rename-path  | new method
          |         | yes       | free-space           | new method
 
+5.1.  Upcoming Breakage
+
+   These features will be removed three months after 2.80's release:
+
+   1. session-get's 'download-dir-free-space' argument will be removed.
+      Its functionality has been superceded by the 'free-space' method.
+
+   2. HTTP POSTs to http://server:port/transmission/upload will fail.
+      It's been superceded by http://server:port/transmission/upload2.
+      Example in https://trac.transmissionbt.com/changeset/14005/#file8
+      NB: not to be confused with section 3.4's torrent-add method.
+      /upload and /upload2 are undocumented features to help web clients
+      upload .torrent files.

trunk/libtransmission/quark.c

@@ -79 +79 @@
   { "doneDate", 8 },
   { "download-dir", 12 },
+  { "download-dir-free-space", 23 },
   { "download-queue-enabled", 22 },
   { "download-queue-size", 19 },

trunk/libtransmission/quark.h

@@ -89 +89 @@
   TR_KEY_doneDate,
   TR_KEY_download_dir,
+  TR_KEY_download_dir_free_space,
   TR_KEY_download_queue_enabled,
   TR_KEY_download_queue_size,

trunk/libtransmission/rpc-test.c

@@ -107 +107 @@
   check (tr_variantDictFind (args, TR_KEY_dht_enabled) != NULL);
   check (tr_variantDictFind (args, TR_KEY_download_dir) != NULL);
+  check (tr_variantDictFind (args, TR_KEY_download_dir_free_space) != NULL);
   check (tr_variantDictFind (args, TR_KEY_download_queue_enabled) != NULL);
   check (tr_variantDictFind (args, TR_KEY_download_queue_size) != NULL);

trunk/libtransmission/rpcimpl.c

@@ -27 +27 @@
 #include "fdlimit.h"
 #include "log.h"
+#include "platform.h" /* tr_device_info_get_free_space() */
 #include "rpcimpl.h"
 #include "session.h"
@@ -1883 +1884 @@
 static const char*
 sessionGet (tr_session               * s,
-            tr_variant                  * args_in UNUSED,
-            tr_variant                  * args_out,
+            tr_variant               * args_in UNUSED,
+            tr_variant               * args_out,
             struct tr_rpc_idle_data  * idle_data UNUSED)
 {
@@ -1904 +1905 @@
     tr_variantDictAddStr  (d, TR_KEY_config_dir, tr_sessionGetConfigDir (s));
     tr_variantDictAddStr  (d, TR_KEY_download_dir, tr_sessionGetDownloadDir (s));
+    tr_variantDictAddInt  (d, TR_KEY_download_dir_free_space, tr_device_info_get_free_space (s->downloadDir));
     tr_variantDictAddBool (d, TR_KEY_download_queue_enabled, tr_sessionGetQueueEnabled (s, TR_DOWN));
     tr_variantDictAddInt  (d, TR_KEY_download_queue_size, tr_sessionGetQueueSize (s, TR_DOWN));