Changeset 14009


Ignore:
Timestamp:
Feb 10, 2013, 7:36:13 PM (8 years ago)
Author:
jordan
Message:

(libT) restore the RPC download-dir-free-space argument to avoid unscheduled breakage. Document the timetable for its removal in rpc-spec.txt.

Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/extras/rpc-spec.txt

    r13991 r14009  
    759759         |         | yes       |                      | new method "torrent-start-now"
    760760   ------+---------+-----------+--------------------------+-------------------------------
    761    15    | 2.80    |        NO | session-get          | removed arg "download-dir-free-space"
    762          |         | yes       | torrent-get          | new arg "etaIdle"
     761   15    | 2.80    | yes       | torrent-get          | new arg "etaIdle"
    763762         |         | yes       | torrent-rename-path  | new method
    764763         |         | yes       | free-space           | new method
    765764
     7655.1.  Upcoming Breakage
     766
     767   These features will be removed three months after 2.80's release:
     768
     769   1. session-get's 'download-dir-free-space' argument will be removed.
     770      Its functionality has been superceded by the 'free-space' method.
     771
     772   2. HTTP POSTs to http://server:port/transmission/upload will fail.
     773      It's been superceded by http://server:port/transmission/upload2.
     774      Example in https://trac.transmissionbt.com/changeset/14005/#file8
     775      NB: not to be confused with section 3.4's torrent-add method.
     776      /upload and /upload2 are undocumented features to help web clients
     777      upload .torrent files.
  • trunk/libtransmission/quark.c

    r13991 r14009  
    7979  { "doneDate", 8 },
    8080  { "download-dir", 12 },
     81  { "download-dir-free-space", 23 },
    8182  { "download-queue-enabled", 22 },
    8283  { "download-queue-size", 19 },
  • trunk/libtransmission/quark.h

    r13991 r14009  
    8989  TR_KEY_doneDate,
    9090  TR_KEY_download_dir,
     91  TR_KEY_download_dir_free_space,
    9192  TR_KEY_download_queue_enabled,
    9293  TR_KEY_download_queue_size,
  • trunk/libtransmission/rpc-test.c

    r13991 r14009  
    107107  check (tr_variantDictFind (args, TR_KEY_dht_enabled) != NULL);
    108108  check (tr_variantDictFind (args, TR_KEY_download_dir) != NULL);
     109  check (tr_variantDictFind (args, TR_KEY_download_dir_free_space) != NULL);
    109110  check (tr_variantDictFind (args, TR_KEY_download_queue_enabled) != NULL);
    110111  check (tr_variantDictFind (args, TR_KEY_download_queue_size) != NULL);
  • trunk/libtransmission/rpcimpl.c

    r13991 r14009  
    2727#include "fdlimit.h"
    2828#include "log.h"
     29#include "platform.h" /* tr_device_info_get_free_space() */
    2930#include "rpcimpl.h"
    3031#include "session.h"
     
    18831884static const char*
    18841885sessionGet (tr_session               * s,
    1885             tr_variant                  * args_in UNUSED,
    1886             tr_variant                  * args_out,
     1886            tr_variant               * args_in UNUSED,
     1887            tr_variant               * args_out,
    18871888            struct tr_rpc_idle_data  * idle_data UNUSED)
    18881889{
     
    19041905    tr_variantDictAddStr  (d, TR_KEY_config_dir, tr_sessionGetConfigDir (s));
    19051906    tr_variantDictAddStr  (d, TR_KEY_download_dir, tr_sessionGetDownloadDir (s));
     1907    tr_variantDictAddInt  (d, TR_KEY_download_dir_free_space, tr_device_info_get_free_space (s->downloadDir));
    19061908    tr_variantDictAddBool (d, TR_KEY_download_queue_enabled, tr_sessionGetQueueEnabled (s, TR_DOWN));
    19071909    tr_variantDictAddInt  (d, TR_KEY_download_queue_size, tr_sessionGetQueueSize (s, TR_DOWN));
Note: See TracChangeset for help on using the changeset viewer.