Changeset 14130

Timestamp:

Jul 20, 2013, 3:37:13 PM (9 years ago)

Author:

jordan

Message:

add tr_sessionGetTorrents(), a private utility to avoid code duplication in libtransmission

Location:

trunk/libtransmission

Files:

• rpcimpl.c (modified) (1 diff)
• session.c (modified) (4 diffs)
• session.h (modified) (1 diff)
• torrent.c (modified) (2 diffs)

trunk/libtransmission/rpcimpl.c

@@ -182 +182 @@
   else /* all of them */
     {
-      tr_torrent * tor = NULL;
-      const int n = tr_sessionCountTorrents (session);
-      torrents = tr_new0 (tr_torrent *, n);
-      while ((tor = tr_torrentNext (session, tor)))
-        torrents[torrentCount++] = tor;
+      torrents = tr_sessionGetTorrents (session, &torrentCount);
     }
 

trunk/libtransmission/session.c

@@ -1741 +1741 @@
 }
 
+tr_torrent **
+tr_sessionGetTorrents (tr_session * session, int * setme_n)
+{
+  int i;
+  int n;
+  tr_torrent ** torrents;
+  tr_torrent * tor;
+
+  assert (tr_isSession (session));
+  assert (setme_n != NULL);
+
+  n = tr_sessionCountTorrents (session);
+  *setme_n = n;
+
+  torrents = tr_new (tr_torrent *, n);
+  tor = NULL;
+  for (i=0; i<n; ++i)
+    torrents[i] = tor = tr_torrentNext (session, tor);
+
+  return torrents;
+} 
+
 static int
 compareTorrentByCur (const void * va, const void * vb)
@@ -1790 +1812 @@
    * if we can't get them all closed in a reasonable amount of time,
    * at least we get the most important ones first. */
-  tor = NULL;
-  n = session->torrentCount;
-  torrents = tr_new (tr_torrent *, session->torrentCount);
-  for (i=0; i<n; ++i)
-    torrents[i] = tor = tr_torrentNext (session, tor);
+  torrents = tr_sessionGetTorrents (session, &n);
   qsort (torrents, n, sizeof (tr_torrent*), compareTorrentByCur);
   for (i=0; i<n; ++i)
@@ -2806 +2824 @@
 {
   size_t i;
+  size_t n;
   tr_torrent * tor;
   struct TorrentAndPosition * candidates;
@@ -2813 +2832 @@
 
   /* build an array of the candidates */
-  candidates = tr_new (struct TorrentAndPosition, session->torrentCount);
+  n = tr_sessionCountTorrents (session);
+  candidates = tr_new (struct TorrentAndPosition, n);
   i = 0;
   tor = NULL;

trunk/libtransmission/session.h

@@ -264 +264 @@
 int tr_sessionCountTorrents (const tr_session * session);
 
+tr_torrent ** tr_sessionGetTorrents (tr_session * session, int * setme_n);
+
 enum
 {

trunk/libtransmission/torrent.c

@@ -3391 +3391 @@
 queueIsSequenced (tr_session * session)
 {
-  int i ;
-  int n ;
-  bool is_sequenced = true;
+  int i;
+  int n;
+  bool is_sequenced;
   tr_torrent * tor;
-  tr_torrent ** tmp = tr_new (tr_torrent *, session->torrentCount);
-
-  /* get all the torrents */
+  tr_torrent ** torrents;
+
   n = 0;
-  tor = NULL;
-  while ((tor = tr_torrentNext (session, tor)))
-    tmp[n++] = tor;
-
-  /* sort them by position */
-  qsort (tmp, n, sizeof (tr_torrent *), compareTorrentByQueuePosition);
+  torrents = tr_sessionGetTorrents (session, &n);
+  qsort (torrents, n, sizeof (tr_torrent *), compareTorrentByQueuePosition);
 
 #if 0
@@ -3414 +3409 @@
 
   /* test them */
+  is_sequenced = true;
   for (i=0; is_sequenced && i<n; ++i)
-    if (tmp[i]->queuePosition != i)
+    if (torrents[i]->queuePosition != i)
       is_sequenced = false;
 
-  tr_free (tmp);
+  tr_free (torrents);
   return is_sequenced;
 }