Changeset 14151

Timestamp:

Jul 29, 2013, 4:19:15 AM (9 years ago)

Author:

jordan

Message:

(trunk libT) #5444 'underflow in bitfield.c's set_all_true()' -- fixed

Location:

trunk/libtransmission

Files:

• bitfield.c (modified) (1 diff)
• completion.h (modified) (1 diff)

trunk/libtransmission/bitfield.c

@@ -180 +180 @@
   const size_t n = get_bytes_needed (bit_count);
 
-  memset (array, val, n-1);
-
-  array[n-1] = val << (n*8 - bit_count);
+  if (n > 0)
+    {
+      memset (array, val, n-1);
+
+      array[n-1] = val << (n*8 - bit_count);
+    }
 }
 

trunk/libtransmission/completion.h

@@ -92 +92 @@
 static inline bool tr_cpHasAll (const tr_completion * cp)
 {
-    return tr_bitfieldHasAll (&cp->blockBitfield);
+    return tr_torrentHasMetadata (cp->tor)
+        && tr_bitfieldHasAll (&cp->blockBitfield);
 }
 
 static inline bool tr_cpHasNone (const tr_completion * cp)
 {
-    return tr_bitfieldHasNone (&cp->blockBitfield);
+    return !tr_torrentHasMetadata (cp->tor)
+        || tr_bitfieldHasNone (&cp->blockBitfield);
 }