Changeset 14380


Ignore:
Timestamp:
Dec 13, 2014, 9:04:10 AM (8 years ago)
Author:
mikedld
Message:

Strip needless const& specifiers on SIGNAL and SLOT arguments (Qt client)

Location:
trunk/qt
Files:
10 edited

Legend:

Unmodified
Added
Removed
  • trunk/qt/details.cc

    r14379 r14380  
    12861286  myTrackerView->setAlternatingRowColors (true);
    12871287  myTrackerView->setItemDelegate (myTrackerDelegate = new TrackerDelegate ());
    1288   connect (myTrackerView->selectionModel (), SIGNAL (selectionChanged (const QItemSelection&, const QItemSelection&)), this, SLOT (onTrackerSelectionChanged ()));
     1288  connect (myTrackerView->selectionModel (), SIGNAL (selectionChanged (QItemSelection, QItemSelection)), this, SLOT (onTrackerSelectionChanged ()));
    12891289  h->addWidget (myTrackerView, 1);
    12901290
     
    13851385  myFileTreeView = new FileTreeView ();
    13861386
    1387   connect (myFileTreeView, SIGNAL (     priorityChanged (const QSet<int>&, int)),
    1388            this,           SLOT ( onFilePriorityChanged (const QSet<int>&, int)));
    1389 
    1390   connect (myFileTreeView, SIGNAL (     wantedChanged (const QSet<int>&, bool)),
    1391            this,           SLOT ( onFileWantedChanged (const QSet<int>&, bool)));
    1392 
    1393   connect (myFileTreeView, SIGNAL (pathEdited (const QString&, const QString&)),
    1394            this,           SLOT (onPathEdited (const QString&, const QString&)));
    1395 
    1396   connect (myFileTreeView, SIGNAL (openRequested (const QString&)),
    1397            this,           SLOT (onOpenRequested (const QString&)));
     1387  connect (myFileTreeView, SIGNAL (     priorityChanged (QSet<int>, int)),
     1388           this,           SLOT ( onFilePriorityChanged (QSet<int>, int)));
     1389
     1390  connect (myFileTreeView, SIGNAL (     wantedChanged (QSet<int>, bool)),
     1391           this,           SLOT ( onFileWantedChanged (QSet<int>, bool)));
     1392
     1393  connect (myFileTreeView, SIGNAL (pathEdited (QString, QString)),
     1394           this,           SLOT (onPathEdited (QString, QString)));
     1395
     1396  connect (myFileTreeView, SIGNAL (openRequested (QString)),
     1397           this,           SLOT (onOpenRequested (QString)));
    13981398
    13991399  return myFileTreeView;
  • trunk/qt/file-tree.cc

    r14379 r14380  
    893893    }
    894894
    895   connect (this, SIGNAL(clicked(const QModelIndex&)),
    896            this, SLOT(onClicked(const QModelIndex&)));
    897 
    898   connect (this, SIGNAL(doubleClicked(const QModelIndex&)),
    899            this, SLOT(onDoubleClicked(const QModelIndex&)));
    900 
    901   connect (&myModel, SIGNAL(priorityChanged(const QSet<int>&, int)),
    902            this,     SIGNAL(priorityChanged(const QSet<int>&, int)));
    903 
    904   connect (&myModel, SIGNAL(wantedChanged(const QSet<int>&, bool)),
    905            this,     SIGNAL(wantedChanged(const QSet<int>&, bool)));
    906 
    907   connect (&myModel, SIGNAL(pathEdited(const QString&, const QString&)),
    908            this,     SIGNAL(pathEdited(const QString&, const QString&)));
    909 
    910   connect (&myModel, SIGNAL (openRequested (const QString&)),
    911            this,     SLOT (onOpenRequested (const QString&)),
     895  connect (this, SIGNAL(clicked(QModelIndex)),
     896           this, SLOT(onClicked(QModelIndex)));
     897
     898  connect (this, SIGNAL(doubleClicked(QModelIndex)),
     899           this, SLOT(onDoubleClicked(QModelIndex)));
     900
     901  connect (&myModel, SIGNAL(priorityChanged(QSet<int>, int)),
     902           this,     SIGNAL(priorityChanged(QSet<int>, int)));
     903
     904  connect (&myModel, SIGNAL(wantedChanged(QSet<int>, bool)),
     905           this,     SIGNAL(wantedChanged(QSet<int>, bool)));
     906
     907  connect (&myModel, SIGNAL(pathEdited(QString, QString)),
     908           this,     SIGNAL(pathEdited(QString, QString)));
     909
     910  connect (&myModel, SIGNAL (openRequested (QString)),
     911           this,     SLOT (onOpenRequested (QString)),
    912912           Qt::QueuedConnection);
    913913}
  • trunk/qt/filterbar.cc

    r14379 r14380  
    462462  connect (myActivityCombo, SIGNAL (currentIndexChanged (int)), this, SLOT (onActivityIndexChanged (int)));
    463463  connect (myTrackerCombo, SIGNAL (currentIndexChanged (int)), this, SLOT (onTrackerIndexChanged (int)));
    464   connect (&myFilter, SIGNAL (rowsInserted (const QModelIndex&,int,int)), this, SLOT (refreshCountLabel ()));
    465   connect (&myFilter, SIGNAL (rowsRemoved (const QModelIndex&,int,int)), this, SLOT (refreshCountLabel ()));
     464  connect (&myFilter, SIGNAL (rowsInserted (QModelIndex, int, int)), this, SLOT (refreshCountLabel ()));
     465  connect (&myFilter, SIGNAL (rowsRemoved (QModelIndex, int, int)), this, SLOT (refreshCountLabel ()));
    466466  connect (&myTorrents, SIGNAL (modelReset ()), this, SLOT (onTorrentModelReset ()));
    467   connect (&myTorrents, SIGNAL (rowsInserted (const QModelIndex&,int,int)), this, SLOT (onTorrentModelRowsInserted (const QModelIndex&,int,int)));
    468   connect (&myTorrents, SIGNAL (rowsRemoved (const QModelIndex&,int,int)), this, SLOT (onTorrentModelRowsRemoved (const QModelIndex&,int,int)));
    469   connect (&myTorrents, SIGNAL (dataChanged (const QModelIndex&,const QModelIndex&)), this, SLOT (onTorrentModelDataChanged (const QModelIndex&,const QModelIndex&)));
     467  connect (&myTorrents, SIGNAL (rowsInserted (QModelIndex, int, int)), this, SLOT (onTorrentModelRowsInserted (QModelIndex, int, int)));
     468  connect (&myTorrents, SIGNAL (rowsRemoved (QModelIndex, int, int)), this, SLOT (onTorrentModelRowsRemoved (QModelIndex, int, int)));
     469  connect (&myTorrents, SIGNAL (dataChanged (QModelIndex, QModelIndex)), this, SLOT (onTorrentModelDataChanged (QModelIndex, QModelIndex)));
    470470  connect (myRecountTimer, SIGNAL (timeout ()), this, SLOT (recount ()));
    471471
  • trunk/qt/freespace-label.cc

    r14378 r14380  
    3434  connect (&myTimer, SIGNAL(timeout()), this, SLOT(onTimer()));
    3535
    36   connect (&mySession, SIGNAL(executed(int64_t, const QString&, tr_variant *)),
    37            this,       SLOT(onSessionExecuted(int64_t, const QString&, tr_variant *)));
     36  connect (&mySession, SIGNAL(executed(int64_t, QString, tr_variant *)),
     37           this,       SLOT(onSessionExecuted(int64_t, QString, tr_variant *)));
    3838
    3939  setPath (path);
  • trunk/qt/mainwin.cc

    r14379 r14380  
    185185  connect (ui.action_SessionDialog, SIGNAL (triggered ()), mySessionDialog, SLOT (show ()));
    186186
    187   connect (ui.listView, SIGNAL (activated (const QModelIndex&)), ui.action_Properties, SLOT (trigger ()));
     187  connect (ui.listView, SIGNAL (activated (QModelIndex)), ui.action_Properties, SLOT (trigger ()));
    188188
    189189  // signals
     
    191191  connect (ui.action_DeselectAll, SIGNAL (triggered ()), ui.listView, SLOT (clearSelection ()));
    192192
    193   connect (&myFilterModel, SIGNAL (rowsInserted (const QModelIndex&,int,int)), this, SLOT (refreshActionSensitivitySoon ()));
    194   connect (&myFilterModel, SIGNAL (rowsRemoved (const QModelIndex&,int,int)), this, SLOT (refreshActionSensitivitySoon ()));
     193  connect (&myFilterModel, SIGNAL (rowsInserted (QModelIndex, int, int)), this, SLOT (refreshActionSensitivitySoon ()));
     194  connect (&myFilterModel, SIGNAL (rowsRemoved (QModelIndex, int, int)), this, SLOT (refreshActionSensitivitySoon ()));
    195195
    196196  connect (ui.action_Quit, SIGNAL (triggered ()), QCoreApplication::instance (), SLOT (quit ()));
     
    199199  myFilterModel.setSourceModel (&myModel);
    200200  connect (&myModel, SIGNAL (modelReset ()), this, SLOT (onModelReset ()));
    201   connect (&myModel, SIGNAL (rowsRemoved (const QModelIndex&,int,int)), this, SLOT (onModelReset ()));
    202   connect (&myModel, SIGNAL (rowsInserted (const QModelIndex&,int,int)), this, SLOT (onModelReset ()));
    203   connect (&myModel, SIGNAL (dataChanged (const QModelIndex&,const QModelIndex&)), this, SLOT (refreshTrayIconSoon ()));
     201  connect (&myModel, SIGNAL (rowsRemoved (QModelIndex, int, int)), this, SLOT (onModelReset ()));
     202  connect (&myModel, SIGNAL (rowsInserted (QModelIndex, int, int)), this, SLOT (onModelReset ()));
     203  connect (&myModel, SIGNAL (dataChanged (QModelIndex, QModelIndex)), this, SLOT (refreshTrayIconSoon ()));
    204204
    205205  ui.listView->setModel (&myFilterModel);
    206   connect (ui.listView->selectionModel (), SIGNAL (selectionChanged (const QItemSelection&,const QItemSelection&)), this, SLOT (refreshActionSensitivitySoon ()));
     206  connect (ui.listView->selectionModel (), SIGNAL (selectionChanged (QItemSelection, QItemSelection)), this, SLOT (refreshActionSensitivitySoon ()));
    207207
    208208  QActionGroup * actionGroup = new QActionGroup (this);
     
    274274  connect (&mySession, SIGNAL (httpAuthenticationRequired ()), this, SLOT (wrongAuthentication ()));
    275275  connect (&mySession, SIGNAL (error (QNetworkReply::NetworkError)), this, SLOT (onError (QNetworkReply::NetworkError)));
    276   connect (&mySession, SIGNAL (errorMessage (const QString)), this, SLOT (errorMessage(const QString)));
     276  connect (&mySession, SIGNAL (errorMessage (QString)), this, SLOT (errorMessage(QString)));
    277277
    278278  if (mySession.isServer ())
     
    11751175  l->addWidget (b, l->rowCount(), 0, 1, -1, Qt::AlignLeft);
    11761176
    1177   connect (d, SIGNAL (filesSelected (const QStringList&)),
    1178            this, SLOT (addTorrents (const QStringList&)));
     1177  connect (d, SIGNAL (filesSelected (QStringList)),
     1178           this, SLOT (addTorrents (QStringList)));
    11791179
    11801180  d->show ();
  • trunk/qt/make-dialog.cc

    r14377 r14380  
    178178  d->setFileMode (QFileDialog::ExistingFile);
    179179  d->setAttribute (Qt::WA_DeleteOnClose);
    180   connect (d, SIGNAL(filesSelected(const QStringList&)),
    181            this, SLOT(onFileSelected(const QStringList&)));
     180  connect (d, SIGNAL(filesSelected(QStringList)),
     181           this, SLOT(onFileSelected(QStringList)));
    182182  d->show ();
    183183}
     
    203203  d->setOption (QFileDialog::ShowDirsOnly);
    204204  d->setAttribute (Qt::WA_DeleteOnClose);
    205   connect (d, SIGNAL(filesSelected(const QStringList&)),
    206            this, SLOT(onFolderSelected(const QStringList&)));
     205  connect (d, SIGNAL(filesSelected(QStringList)),
     206           this, SLOT(onFolderSelected(QStringList)));
    207207  d->show ();
    208208}
     
    230230  d->setOption (QFileDialog::ShowDirsOnly);
    231231  d->setAttribute (Qt::WA_DeleteOnClose);
    232   connect (d, SIGNAL(filesSelected(const QStringList&)),
    233            this, SLOT(onDestinationSelected(const QStringList&)));
     232  connect (d, SIGNAL(filesSelected(QStringList)),
     233           this, SLOT(onDestinationSelected(QStringList)));
    234234  d->show ();
    235235}
  • trunk/qt/options.cc

    r14377 r14380  
    133133      layout->addWidget (e, row, 1);
    134134      l->setBuddy (e);
    135       connect (e, SIGNAL (textEdited (const QString&)), this, SLOT (onDestinationEdited (const QString&)));
     135      connect (e, SIGNAL (textEdited (QString)), this, SLOT (onDestinationEdited (QString)));
    136136    }
    137137
     
    180180  layout->setSpacing (HIG::PAD);
    181181
    182   connect (myTree, SIGNAL (priorityChanged (const QSet<int>&,int)), this, SLOT (onPriorityChanged (const QSet<int>&,int)));
    183   connect (myTree, SIGNAL (wantedChanged (const QSet<int>&,bool)), this, SLOT (onWantedChanged (const QSet<int>&,bool)));
     182  connect (myTree, SIGNAL (priorityChanged (QSet<int>, int)), this, SLOT (onPriorityChanged (QSet<int>, int)));
     183  connect (myTree, SIGNAL (wantedChanged (QSet<int>, bool)), this, SLOT (onWantedChanged (QSet<int>, bool)));
    184184  if (session.isLocal ())
    185185    connect (myVerifyButton, SIGNAL (clicked (bool)), this, SLOT (onVerify ()));
     
    406406      d->setFileMode (QFileDialog::ExistingFile);
    407407      d->setAttribute (Qt::WA_DeleteOnClose);
    408       connect (d, SIGNAL (filesSelected (const QStringList&)), this, SLOT (onFilesSelected (const QStringList&)));
     408      connect (d, SIGNAL (filesSelected (QStringList)), this, SLOT (onFilesSelected (QStringList)));
    409409      d->show ();
    410410    }
     
    434434  d->setFileMode (QFileDialog::Directory);
    435435  d->setAttribute (Qt::WA_DeleteOnClose);
    436   connect (d, SIGNAL (filesSelected (const QStringList&)), this, SLOT (onDestinationsSelected (const QStringList&)));
     436  connect (d, SIGNAL (filesSelected (QStringList)), this, SLOT (onDestinationsSelected (QStringList)));
    437437  d->show ();
    438438}
  • trunk/qt/session.cc

    r14378 r14380  
    306306  connect (&myPrefs, SIGNAL (changed (int)), this, SLOT (updatePref (int)));
    307307
    308   connect (this, SIGNAL (responseReceived (const QByteArray&)),
    309            this, SLOT (onResponseReceived (const QByteArray&)));
     308  connect (this, SIGNAL (responseReceived (QByteArray)),
     309           this, SLOT (onResponseReceived (QByteArray)));
    310310}
    311311
  • trunk/qt/session.h

    r14378 r14380  
    163163    void dataSendProgress ();
    164164    void error (QNetworkReply::NetworkError);
    165     void errorMessage (const QString);
     165    void errorMessage (const QString&);
    166166    void httpAuthenticationRequired ();
    167167
  • trunk/qt/watchdir.cc

    r14377 r14380  
    9090      myWatcher = new QFileSystemWatcher ();
    9191      myWatcher->addPath( path );
    92       connect (myWatcher, SIGNAL(directoryChanged(const QString&)),
    93                this, SLOT(watcherActivated(const QString&)));
     92      connect (myWatcher, SIGNAL(directoryChanged(QString)),
     93               this, SLOT(watcherActivated(QString)));
    9494      //std::cerr << "watching " << qPrintable(path) << " for new .torrent files" << std::endl;
    9595      QTimer::singleShot (0, this, SLOT (rescanAllWatchedDirectories ())); // trigger the watchdir for .torrent files in there already
Note: See TracChangeset for help on using the changeset viewer.