Changeset 14380

Timestamp:

Dec 13, 2014, 9:04:10 AM (8 years ago)

Author:

mikedld

Message:

Strip needless const& specifiers on SIGNAL and SLOT arguments (Qt client)

Location:

trunk/qt

Files:

• details.cc (modified) (2 diffs)
• file-tree.cc (modified) (1 diff)
• filterbar.cc (modified) (1 diff)
• freespace-label.cc (modified) (1 diff)
• mainwin.cc (modified) (5 diffs)
• make-dialog.cc (modified) (3 diffs)
• options.cc (modified) (4 diffs)
• session.cc (modified) (1 diff)
• session.h (modified) (1 diff)
• watchdir.cc (modified) (1 diff)

trunk/qt/details.cc

@@ -1286 +1286 @@
   myTrackerView->setAlternatingRowColors (true);
   myTrackerView->setItemDelegate (myTrackerDelegate = new TrackerDelegate ());
-  connect (myTrackerView->selectionModel (), SIGNAL (selectionChanged (const QItemSelection&, const QItemSelection&)), this, SLOT (onTrackerSelectionChanged ()));
+  connect (myTrackerView->selectionModel (), SIGNAL (selectionChanged (QItemSelection, QItemSelection)), this, SLOT (onTrackerSelectionChanged ()));
   h->addWidget (myTrackerView, 1);
 
@@ -1385 +1385 @@
   myFileTreeView = new FileTreeView ();
 
-  connect (myFileTreeView, SIGNAL (     priorityChanged (const QSet<int>&, int)),
-           this,           SLOT ( onFilePriorityChanged (const QSet<int>&, int)));
-
-  connect (myFileTreeView, SIGNAL (     wantedChanged (const QSet<int>&, bool)),
-           this,           SLOT ( onFileWantedChanged (const QSet<int>&, bool)));
-
-  connect (myFileTreeView, SIGNAL (pathEdited (const QString&, const QString&)),
-           this,           SLOT (onPathEdited (const QString&, const QString&)));
-
-  connect (myFileTreeView, SIGNAL (openRequested (const QString&)),
-           this,           SLOT (onOpenRequested (const QString&)));
+  connect (myFileTreeView, SIGNAL (     priorityChanged (QSet<int>, int)),
+           this,           SLOT ( onFilePriorityChanged (QSet<int>, int)));
+
+  connect (myFileTreeView, SIGNAL (     wantedChanged (QSet<int>, bool)),
+           this,           SLOT ( onFileWantedChanged (QSet<int>, bool)));
+
+  connect (myFileTreeView, SIGNAL (pathEdited (QString, QString)),
+           this,           SLOT (onPathEdited (QString, QString)));
+
+  connect (myFileTreeView, SIGNAL (openRequested (QString)),
+           this,           SLOT (onOpenRequested (QString)));
 
   return myFileTreeView;

trunk/qt/file-tree.cc

@@ -893 +893 @@
     }
 
-  connect (this, SIGNAL(clicked(const QModelIndex&)),
-           this, SLOT(onClicked(const QModelIndex&)));
-
-  connect (this, SIGNAL(doubleClicked(const QModelIndex&)),
-           this, SLOT(onDoubleClicked(const QModelIndex&)));
-
-  connect (&myModel, SIGNAL(priorityChanged(const QSet<int>&, int)),
-           this,     SIGNAL(priorityChanged(const QSet<int>&, int)));
-
-  connect (&myModel, SIGNAL(wantedChanged(const QSet<int>&, bool)),
-           this,     SIGNAL(wantedChanged(const QSet<int>&, bool)));
-
-  connect (&myModel, SIGNAL(pathEdited(const QString&, const QString&)),
-           this,     SIGNAL(pathEdited(const QString&, const QString&)));
-
-  connect (&myModel, SIGNAL (openRequested (const QString&)),
-           this,     SLOT (onOpenRequested (const QString&)),
+  connect (this, SIGNAL(clicked(QModelIndex)),
+           this, SLOT(onClicked(QModelIndex)));
+
+  connect (this, SIGNAL(doubleClicked(QModelIndex)),
+           this, SLOT(onDoubleClicked(QModelIndex)));
+
+  connect (&myModel, SIGNAL(priorityChanged(QSet<int>, int)),
+           this,     SIGNAL(priorityChanged(QSet<int>, int)));
+
+  connect (&myModel, SIGNAL(wantedChanged(QSet<int>, bool)),
+           this,     SIGNAL(wantedChanged(QSet<int>, bool)));
+
+  connect (&myModel, SIGNAL(pathEdited(QString, QString)),
+           this,     SIGNAL(pathEdited(QString, QString)));
+
+  connect (&myModel, SIGNAL (openRequested (QString)),
+           this,     SLOT (onOpenRequested (QString)),
            Qt::QueuedConnection);
 }

trunk/qt/filterbar.cc

@@ -462 +462 @@
   connect (myActivityCombo, SIGNAL (currentIndexChanged (int)), this, SLOT (onActivityIndexChanged (int)));
   connect (myTrackerCombo, SIGNAL (currentIndexChanged (int)), this, SLOT (onTrackerIndexChanged (int)));
-  connect (&myFilter, SIGNAL (rowsInserted (const QModelIndex&,int,int)), this, SLOT (refreshCountLabel ()));
-  connect (&myFilter, SIGNAL (rowsRemoved (const QModelIndex&,int,int)), this, SLOT (refreshCountLabel ()));
+  connect (&myFilter, SIGNAL (rowsInserted (QModelIndex, int, int)), this, SLOT (refreshCountLabel ()));
+  connect (&myFilter, SIGNAL (rowsRemoved (QModelIndex, int, int)), this, SLOT (refreshCountLabel ()));
   connect (&myTorrents, SIGNAL (modelReset ()), this, SLOT (onTorrentModelReset ()));
-  connect (&myTorrents, SIGNAL (rowsInserted (const QModelIndex&,int,int)), this, SLOT (onTorrentModelRowsInserted (const QModelIndex&,int,int)));
-  connect (&myTorrents, SIGNAL (rowsRemoved (const QModelIndex&,int,int)), this, SLOT (onTorrentModelRowsRemoved (const QModelIndex&,int,int)));
-  connect (&myTorrents, SIGNAL (dataChanged (const QModelIndex&,const QModelIndex&)), this, SLOT (onTorrentModelDataChanged (const QModelIndex&,const QModelIndex&)));
+  connect (&myTorrents, SIGNAL (rowsInserted (QModelIndex, int, int)), this, SLOT (onTorrentModelRowsInserted (QModelIndex, int, int)));
+  connect (&myTorrents, SIGNAL (rowsRemoved (QModelIndex, int, int)), this, SLOT (onTorrentModelRowsRemoved (QModelIndex, int, int)));
+  connect (&myTorrents, SIGNAL (dataChanged (QModelIndex, QModelIndex)), this, SLOT (onTorrentModelDataChanged (QModelIndex, QModelIndex)));
   connect (myRecountTimer, SIGNAL (timeout ()), this, SLOT (recount ()));
 

trunk/qt/freespace-label.cc

@@ -34 +34 @@
   connect (&myTimer, SIGNAL(timeout()), this, SLOT(onTimer()));
 
-  connect (&mySession, SIGNAL(executed(int64_t, const QString&, tr_variant *)),
-           this,       SLOT(onSessionExecuted(int64_t, const QString&, tr_variant *)));
+  connect (&mySession, SIGNAL(executed(int64_t, QString, tr_variant *)),
+           this,       SLOT(onSessionExecuted(int64_t, QString, tr_variant *)));
 
   setPath (path);

trunk/qt/mainwin.cc

@@ -185 +185 @@
   connect (ui.action_SessionDialog, SIGNAL (triggered ()), mySessionDialog, SLOT (show ()));
 
-  connect (ui.listView, SIGNAL (activated (const QModelIndex&)), ui.action_Properties, SLOT (trigger ()));
+  connect (ui.listView, SIGNAL (activated (QModelIndex)), ui.action_Properties, SLOT (trigger ()));
 
   // signals
@@ -191 +191 @@
   connect (ui.action_DeselectAll, SIGNAL (triggered ()), ui.listView, SLOT (clearSelection ()));
 
-  connect (&myFilterModel, SIGNAL (rowsInserted (const QModelIndex&,int,int)), this, SLOT (refreshActionSensitivitySoon ()));
-  connect (&myFilterModel, SIGNAL (rowsRemoved (const QModelIndex&,int,int)), this, SLOT (refreshActionSensitivitySoon ()));
+  connect (&myFilterModel, SIGNAL (rowsInserted (QModelIndex, int, int)), this, SLOT (refreshActionSensitivitySoon ()));
+  connect (&myFilterModel, SIGNAL (rowsRemoved (QModelIndex, int, int)), this, SLOT (refreshActionSensitivitySoon ()));
 
   connect (ui.action_Quit, SIGNAL (triggered ()), QCoreApplication::instance (), SLOT (quit ()));
@@ -199 +199 @@
   myFilterModel.setSourceModel (&myModel);
   connect (&myModel, SIGNAL (modelReset ()), this, SLOT (onModelReset ()));
-  connect (&myModel, SIGNAL (rowsRemoved (const QModelIndex&,int,int)), this, SLOT (onModelReset ()));
-  connect (&myModel, SIGNAL (rowsInserted (const QModelIndex&,int,int)), this, SLOT (onModelReset ()));
-  connect (&myModel, SIGNAL (dataChanged (const QModelIndex&,const QModelIndex&)), this, SLOT (refreshTrayIconSoon ()));
+  connect (&myModel, SIGNAL (rowsRemoved (QModelIndex, int, int)), this, SLOT (onModelReset ()));
+  connect (&myModel, SIGNAL (rowsInserted (QModelIndex, int, int)), this, SLOT (onModelReset ()));
+  connect (&myModel, SIGNAL (dataChanged (QModelIndex, QModelIndex)), this, SLOT (refreshTrayIconSoon ()));
 
   ui.listView->setModel (&myFilterModel);
-  connect (ui.listView->selectionModel (), SIGNAL (selectionChanged (const QItemSelection&,const QItemSelection&)), this, SLOT (refreshActionSensitivitySoon ()));
+  connect (ui.listView->selectionModel (), SIGNAL (selectionChanged (QItemSelection, QItemSelection)), this, SLOT (refreshActionSensitivitySoon ()));
 
   QActionGroup * actionGroup = new QActionGroup (this);
@@ -274 +274 @@
   connect (&mySession, SIGNAL (httpAuthenticationRequired ()), this, SLOT (wrongAuthentication ()));
   connect (&mySession, SIGNAL (error (QNetworkReply::NetworkError)), this, SLOT (onError (QNetworkReply::NetworkError)));
-  connect (&mySession, SIGNAL (errorMessage (const QString)), this, SLOT (errorMessage(const QString)));
+  connect (&mySession, SIGNAL (errorMessage (QString)), this, SLOT (errorMessage(QString)));
 
   if (mySession.isServer ())
@@ -1175 +1175 @@
   l->addWidget (b, l->rowCount(), 0, 1, -1, Qt::AlignLeft);
 
-  connect (d, SIGNAL (filesSelected (const QStringList&)),
-           this, SLOT (addTorrents (const QStringList&)));
+  connect (d, SIGNAL (filesSelected (QStringList)),
+           this, SLOT (addTorrents (QStringList)));
 
   d->show ();

trunk/qt/make-dialog.cc

@@ -178 +178 @@
   d->setFileMode (QFileDialog::ExistingFile);
   d->setAttribute (Qt::WA_DeleteOnClose);
-  connect (d, SIGNAL(filesSelected(const QStringList&)),
-           this, SLOT(onFileSelected(const QStringList&)));
+  connect (d, SIGNAL(filesSelected(QStringList)),
+           this, SLOT(onFileSelected(QStringList)));
   d->show ();
 }
@@ -203 +203 @@
   d->setOption (QFileDialog::ShowDirsOnly);
   d->setAttribute (Qt::WA_DeleteOnClose);
-  connect (d, SIGNAL(filesSelected(const QStringList&)),
-           this, SLOT(onFolderSelected(const QStringList&)));
+  connect (d, SIGNAL(filesSelected(QStringList)),
+           this, SLOT(onFolderSelected(QStringList)));
   d->show ();
 }
@@ -230 +230 @@
   d->setOption (QFileDialog::ShowDirsOnly);
   d->setAttribute (Qt::WA_DeleteOnClose);
-  connect (d, SIGNAL(filesSelected(const QStringList&)),
-           this, SLOT(onDestinationSelected(const QStringList&)));
+  connect (d, SIGNAL(filesSelected(QStringList)),
+           this, SLOT(onDestinationSelected(QStringList)));
   d->show ();
 }

trunk/qt/options.cc

@@ -133 +133 @@
       layout->addWidget (e, row, 1);
       l->setBuddy (e);
-      connect (e, SIGNAL (textEdited (const QString&)), this, SLOT (onDestinationEdited (const QString&)));
+      connect (e, SIGNAL (textEdited (QString)), this, SLOT (onDestinationEdited (QString)));
     }
 
@@ -180 +180 @@
   layout->setSpacing (HIG::PAD);
 
-  connect (myTree, SIGNAL (priorityChanged (const QSet<int>&,int)), this, SLOT (onPriorityChanged (const QSet<int>&,int)));
-  connect (myTree, SIGNAL (wantedChanged (const QSet<int>&,bool)), this, SLOT (onWantedChanged (const QSet<int>&,bool)));
+  connect (myTree, SIGNAL (priorityChanged (QSet<int>, int)), this, SLOT (onPriorityChanged (QSet<int>, int)));
+  connect (myTree, SIGNAL (wantedChanged (QSet<int>, bool)), this, SLOT (onWantedChanged (QSet<int>, bool)));
   if (session.isLocal ())
     connect (myVerifyButton, SIGNAL (clicked (bool)), this, SLOT (onVerify ()));
@@ -406 +406 @@
       d->setFileMode (QFileDialog::ExistingFile);
       d->setAttribute (Qt::WA_DeleteOnClose);
-      connect (d, SIGNAL (filesSelected (const QStringList&)), this, SLOT (onFilesSelected (const QStringList&)));
+      connect (d, SIGNAL (filesSelected (QStringList)), this, SLOT (onFilesSelected (QStringList)));
       d->show ();
     }
@@ -434 +434 @@
   d->setFileMode (QFileDialog::Directory);
   d->setAttribute (Qt::WA_DeleteOnClose);
-  connect (d, SIGNAL (filesSelected (const QStringList&)), this, SLOT (onDestinationsSelected (const QStringList&)));
+  connect (d, SIGNAL (filesSelected (QStringList)), this, SLOT (onDestinationsSelected (QStringList)));
   d->show ();
 }

trunk/qt/session.cc

@@ -306 +306 @@
   connect (&myPrefs, SIGNAL (changed (int)), this, SLOT (updatePref (int)));
 
-  connect (this, SIGNAL (responseReceived (const QByteArray&)),
-           this, SLOT (onResponseReceived (const QByteArray&)));
+  connect (this, SIGNAL (responseReceived (QByteArray)),
+           this, SLOT (onResponseReceived (QByteArray)));
 }
 

trunk/qt/session.h

@@ -163 +163 @@
     void dataSendProgress ();
     void error (QNetworkReply::NetworkError);
-    void errorMessage (const QString);
+    void errorMessage (const QString&);
     void httpAuthenticationRequired ();
 

trunk/qt/watchdir.cc

@@ -90 +90 @@
       myWatcher = new QFileSystemWatcher ();
       myWatcher->addPath( path );
-      connect (myWatcher, SIGNAL(directoryChanged(const QString&)),
-               this, SLOT(watcherActivated(const QString&)));
+      connect (myWatcher, SIGNAL(directoryChanged(QString)),
+               this, SLOT(watcherActivated(QString)));
       //std::cerr << "watching " << qPrintable(path) << " for new .torrent files" << std::endl;
       QTimer::singleShot (0, this, SLOT (rescanAllWatchedDirectories ())); // trigger the watchdir for .torrent files in there already