Changeset 14510

Timestamp:

Apr 23, 2015, 7:02:38 PM (6 years ago)

Author:

mikedld

Message:

#5894: Get rid of inline styles in HTML (patch by Ancient; 1st part, slightly modified per IRC discussion)

Location:

trunk/web

Files:

• index.html (modified) (12 diffs)
• style/transmission/common.css (modified) (2 diffs)
• style/transmission/common.scss (modified) (2 diffs)

trunk/web/index.html

@@ -79 +79 @@
                 </div>
 
-                <div id="prefs-dialog" style="display:none;">
+                <div class="hidden" id="prefs-dialog">
                         <ul>
                                 <li id="prefs-tab-general"><a href="#prefs-page-torrents">Torrents</a></li>
@@ -113 +113 @@
                                         <div class="prefs-section">
                                                 <div class="title"><div id="alternative-speed-limits-title">Alternative Speed Limits</div></div>
-                                                <div class="row" style="font-size: smaller; padding-bottom: 4px;">Override normal speed limits manually or at scheduled times</div>
+                                                <div class="row" id="alternative-speed-limits-desc">Override normal speed limits manually or at scheduled times</div>
                                                 <div class="row"><div class="key">Upload (kB/s):</div>
                                                                  <div class="value"><input type="text" type="number" id="alt-speed-up"/></div></div>
@@ -163 +163 @@
                                                 <div class="row"><div class="key"><input type="checkbox" id="blocklist-enabled"/><label for="blocklist-enabled">Enable blocklist:</label></div>
                                                                  <div class="value"><input type="url" id="blocklist-url"/></div></div>
-                                                <div class="row"><div class="key" style="margin-top: 3px; font-size: smaller;">Blocklist has <span id="blocklist-size">?</span> rules</div>
+                                                <div class="row"><div class="key" id="blocklist-info">Blocklist has <span id="blocklist-size">?</span> rules</div>
                                                                  <div class="value"><input type="button" id="blocklist-update-button" value="Update"/></div></div>
                                         </div>
@@ -186 +186 @@
                 </div>
 
-                <div id="torrent_inspector" style="display:none;">
+                <div class="hidden" id="torrent_inspector">
 
                         <div id="inspector-tabs-wrapper">
@@ -223 +223 @@
                         </div><!-- id="inspector_tab_info_container" -->
 
-                        <div style="display:none;" class="inspector-page" id="inspector-page-peers">
+                        <div class="inspector-page hidden" id="inspector-page-peers">
                                 <div id="inspector_peers_list">
                                 </div>
                         </div><!-- id="inspector_tab_peers_container" -->
 
-                        <div style="display:none;" class="inspector-page" id="inspector-page-trackers">
+                        <div class="inspector-page hidden" id="inspector-page-trackers">
                                 <div id="inspector_trackers_list">
                                 </div>
                         </div><!-- id="inspector_tab_trackers_container" -->
 
-                        <div style="display:none;" class="inspector-page" id="inspector-page-files">
+                        <div class="inspector-page hidden" id="inspector-page-files">
                                         <ul id="inspector_file_list">
                                         </ul>
@@ -244 +244 @@
                 </div>
 
-                <div class="dialog_container" id="dialog_container" style="display:none;">
+                <div class="dialog_container hidden" id="dialog_container">
                         <div class="dialog_top_bar"></div>
                         <div class="dialog_window">
@@ -255 +255 @@
                 </div>
 
-                <div id="about-dialog" style="display:none;">
+                <div class="hidden" id="about-dialog">
                         <p id="about-logo"></p>
                         <p id="about-title">Transmission X</p>
@@ -262 +262 @@
                 </div>
 
-                <div id="stats-dialog" style="display:none;">
+                <div class="hidden" id="stats-dialog">
                         <div class="prefs-section">
                                 <div class="title">Current Session</div>
@@ -280 +280 @@
                 </div>
 
-                <div class="dialog_container" id="upload_container" style="display:none;">
+                <div class="dialog_container hidden" id="upload_container">
                         <div class="dialog_top_bar"></div>
                         <div class="dialog_window">
@@ -303 +303 @@
                 </div>
 
-        <div class="dialog_container" id="rename_container" style="display:none;">
+        <div class="dialog_container hidden" id="rename_container">
             <div class="dialog_top_bar"></div>
             <div class="dialog_window">
@@ -317 +317 @@
         </div>
 
-                <div class="dialog_container" id="move_container" style="display:none;">
+                <div class="dialog_container hidden" id="move_container">
                         <div class="dialog_top_bar"></div>
                         <div class="dialog_window">
@@ -344 +344 @@
                                                 <li class="separator"></li>
                                                 <li id="statistics">Statistics</li>
-                                                <li id="toggle_notifications" style="display: none">Notifcations</li>
+                                                <li class="hidden" id="toggle_notifications">Notifcations</li>
                                                 <li class="separator"></li>
                                                 <li>Total Download Rate

trunk/web/style/transmission/common.css

@@ -22 +22 @@
   body a {
     outline: 0; }
+
+.hidden {
+  display: none; }
 
 /***
@@ -345 +348 @@
     padding-left: 18px;
     background: transparent url("images/blue-turtle.png") no-repeat; }
+  .prefs-section #alternative-speed-limits-desc {
+    font-size: smaller;
+    padding-bottom: 4px; }
+  .prefs-section #blocklist-info {
+    font-size: smaller;
+    margin-top: 3px; }
 
 /***

trunk/web/style/transmission/common.scss

@@ -89 +89 @@
         img { border: none; }
         a { outline: 0; }
+}
+
+.hidden {
+        display: none;
 }
 
@@ -466 +470 @@
                 background: transparent url('images/blue-turtle.png') no-repeat;
         }
+
+        #alternative-speed-limits-desc {
+                font-size: smaller;
+                padding-bottom: 4px;
+        }
+
+        #blocklist-info {
+                font-size: smaller;
+                margin-top: 3px;
+        }
 }