Changeset 2024

Timestamp:

Jun 10, 2007, 3:38:58 PM (15 years ago)

Author:

titer

Message:

Bencoded dictionaries are now sorted alphabetically, this should fix
compatibility with some clients, incl. BitTornado?-based ones.
(Reported by roee88 from LH-ABC)

File:

• trunk/libtransmission/bencode.c (modified) (1 diff)

trunk/libtransmission/bencode.c

@@ -391 +391 @@
 {
     benc_val_t * keyval, * itemval;
+    int i;
 
     assert( TYPE_DICT == dict->type );
     assert( dict->val.l.count + 2 <= dict->val.l.alloc );
 
-    keyval  = &dict->val.l.vals[dict->val.l.count];
-    dict->val.l.count++;
-    itemval = &dict->val.l.vals[dict->val.l.count];
-    dict->val.l.count++;
+    /* Keep dictionaries sorted by keys alphabetically.
+       BitTornado-based clients (and maybe others) need this. */
+    for( i = 0; i < dict->val.l.count; i += 2 )
+    {
+        assert( TYPE_STR == dict->val.l.vals[i].type );
+        if( strcmp( key, dict->val.l.vals[i].val.s.s ) < 0 )
+            break;
+    }
+    memmove( &dict->val.l.vals[i+2], &dict->val.l.vals[i],
+             ( dict->val.l.count - i ) * sizeof(benc_val_t) );
+    keyval  = &dict->val.l.vals[i];
+    itemval = &dict->val.l.vals[i+1];
+    dict->val.l.count += 2;
 
     tr_bencInitStr( keyval, key, -1, 1 );