Changeset 254

Timestamp:

May 13, 2006, 5:28:54 PM (15 years ago)

Author:

titer

Message:

Toughens the criteria for banning, tries to make guesses about the peers two got banned for a few pieces because of someone else

File:

• trunk/libtransmission/peer.c (modified) (3 diffs)

trunk/libtransmission/peer.c

@@ -533 +533 @@
 static inline int peerIsBad( tr_peer_t * peer )
 {
-    if( peer->goodPcs >= 5 &&
-        peer->badPcs >= ( peer->goodPcs * 3 ) )
-    {
-        /* need poor success rate if we've successfully downloaded before */
-        return 1;
-    }
-    else if( peer->goodPcs < 5 &&
-             peer->badPcs >= ( 10 + peer->goodPcs ) )
-    {
-        /* need 10 more bad pieces than good before we discard peer */
-        return 1;
-    }
-    return 0;
+    return ( peer->badPcs > 4 + 2 * peer->goodPcs );
+}
+
+static inline int peerIsGood( tr_peer_t * peer )
+{
+    return ( peer->goodPcs > 3 * peer->badPcs );
 }
 
@@ -559 +552 @@
     {
         peer->goodPcs++;
+
+        if( peer->banfield && peerIsGood( peer ) )
+        {
+            /* Assume the peer wasn't responsible for the bad pieces
+               we was banned for */
+            memset( peer->banfield, 0x00, ( tor->info.pieceCount + 7 ) / 8 );
+        }
     }
     else
@@ -564 +564 @@
         peer->badPcs++;
 
+        /* Ban the peer for this piece */
         if( !peer->banfield )
         {