Changeset 2563

Timestamp:

Jul 31, 2007, 12:45:39 AM (16 years ago)

Author:

livings124

Message:

don't allow comment and creator fields to be selected when empty

Location:

trunk

Files:

• Transmission.xcodeproj/project.pbxproj (modified) (1 diff)
• macosx/InfoWindowController.m (modified) (3 diffs)

trunk/Transmission.xcodeproj/project.pbxproj

@@ -321 +321 @@
                 4DFBC2DE09C0970D00D5C571 /* Torrent.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = Torrent.m; path = macosx/Torrent.m; sourceTree = "<group>"; };
                 8D1107310486CEB800E47090 /* Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist; name = Info.plist; path = macosx/Info.plist; sourceTree = "<group>"; };
-                8D1107320486CEB800E47090 /* Transmission.app */ = {isa = PBXFileReference; includeInIndex = 0; lastKnownFileType = wrapper.application; path = Transmission.app; sourceTree = BUILT_PRODUCTS_DIR; };
+                8D1107320486CEB800E47090 /* Transmission.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = Transmission.app; sourceTree = BUILT_PRODUCTS_DIR; };
                 A200B8390A2263BA007BBB1E /* InfoWindowController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = InfoWindowController.h; path = macosx/InfoWindowController.h; sourceTree = "<group>"; };
                 A200B83A0A2263BA007BBB1E /* InfoWindowController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = InfoWindowController.m; path = macosx/InfoWindowController.m; sourceTree = "<group>"; };

trunk/macosx/InfoWindowController.m

@@ -235 +235 @@
         [fSizeField setStringValue: [NSString stringForFileSize: [torrent size]]];
         
-        NSString * hashString = [torrent hashString],
-                * commentString = [torrent comment];
+        NSString * hashString = [torrent hashString];
         [fPiecesField setStringValue: [NSString stringWithFormat: @"%d, %@", [torrent pieceCount],
                                         [NSString stringForFileSize: [torrent pieceSize]]]];
@@ -244 +243 @@
                         ? NSLocalizedString(@"Private Torrent, PEX disabled", "Inspector -> is private torrent")
                         : NSLocalizedString(@"Public Torrent", "Inspector -> is not private torrent")];
+        
+        NSString * commentString = [torrent comment];
         [fCommentView setString: commentString];
         
-        [fCreatorField setStringValue: [torrent creator]];
+        NSString * creatorString = [torrent creator];
+        [fCreatorField setStringValue: creatorString];
         [fDateCreatedField setObjectValue: [torrent dateCreated]];
         
@@ -267 +269 @@
         [fTrackerField setSelectable: YES];
         [fHashField setSelectable: YES];
-        [fCommentView setSelectable: YES];
-        [fCreatorField setSelectable: YES];
+        [fCommentView setSelectable: ![commentString isEqualToString: @""]];
+        [fCreatorField setSelectable: ![creatorString isEqualToString: @""]];
         [fTorrentLocationField setSelectable: YES];
         [fDataLocationField setSelectable: YES];