Changeset 2885

Timestamp:

Aug 20, 2007, 11:37:08 PM (15 years ago)

Author:

charles

Message:

better cleanup on shutdown. don't crash when the torrent doesn't support scrape. (Gimp :)

Location:

trunk/libtransmission

Files:

• tracker.c (modified) (4 diffs)
• trevent.c (modified) (6 diffs)

trunk/libtransmission/tracker.c

@@ -533 +533 @@
     assert( t->addressIndex >= 0 );
     assert( t->addressIndex < t->addressCount );
+
     return &t->addresses[t->addressIndex];
 }
+static int
+trackerSupportsScrape( const Tracker * t )
+{
+    const tr_tracker_info_t * info = getCurrentAddress( t );
+
+    return ( info != NULL )
+        && ( info->scrape != NULL )
+        && ( info->scrape[0] != '\0' );
+}
+
 
 static void
@@ -560 +571 @@
 {
     Torrent * tor = (Torrent *) vtor;
-    tr_ptrArrayInsertSorted( tor->tracker->scrapeQueue, tor, torrentCompare );
-    tr_trackerScrapeSoon( tor->tracker );
+    if( trackerSupportsScrape( tor->tracker ) ) {
+        tr_ptrArrayInsertSorted( tor->tracker->scrapeQueue, tor, torrentCompare );
+        tr_trackerScrapeSoon( tor->tracker );
+    }
     tor->scrapeTag = NULL;
     return FALSE;
@@ -679 +692 @@
 {
     Tracker * t = (Tracker*) vt;
+    const tr_tracker_info_t * address = getCurrentAddress( t );
 
     assert( tr_ptrArrayEmpty( t->scraping ) );
 
-    if( !tr_ptrArrayEmpty( t->scrapeQueue ) )
+    if( trackerSupportsScrape( t ) && !tr_ptrArrayEmpty( t->scrapeQueue ) )
     {
         int i, n, len, addr_len, ask_n;
@@ -690 +704 @@
         struct evhttp_connection *evcon = NULL;
         struct evhttp_request *req = NULL;
-        const tr_tracker_info_t * address = getCurrentAddress( t );
 
         ask_n = n;

trunk/libtransmission/trevent.c

@@ -13 +13 @@
 #include <assert.h>
 #include <errno.h>
-#include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ -36 +35 @@
 /* #define DEBUG */
 #ifdef DEBUG
+#include <stdio.h>
 #undef tr_dbg
 #define tr_dbg( a, b... ) fprintf(stderr, a "\n", ##b )
@@ -47 +47 @@
 {
     int fds[2];
-    int isShuttingDown;
     tr_lock_t * lock;
     tr_handle_t * h;
+    struct event_base * base;
     struct event pipeEvent;
 }
@@ -139 +139 @@
     tr_dbg( "Starting libevent thread" );
 
-    event_init( );
+    eh->base = event_init( );
     event_set_log_callback( logFunc );
 
@@ -146 +146 @@
     event_add( &eh->pipeEvent, NULL );
 
-    while( !eh->isShuttingDown ) {
-        event_dispatch( );
-        tr_wait( 50 ); /* 1/20th of a second */
-    }
+    event_dispatch( );
 
     event_del( &eh->pipeEvent );
     tr_lockFree( eh->lock );
+    event_base_free( eh->base );
     tr_free( eh );
 
@@ -176 +174 @@
     tr_event_handle_t * eh = handle->events;
 
-    eh->isShuttingDown = TRUE;
+    event_base_loopexit( eh->base, NULL );
 }