Changeset 310 for trunk

Timestamp:

Jun 9, 2006, 7:53:35 PM (16 years ago)

Author:

joshe

Message:

Add support to libtransmission and the MacOS X GUI for saving private copies of

torrent files.

Location:

trunk

Files:

• cli/transmissioncli.c (modified) (1 diff)
• gtk/tr_torrent.c (modified) (1 diff)
• libtransmission/fastresume.h (modified) (1 diff)
• libtransmission/inout.c (modified) (1 diff)
• libtransmission/internal.h (modified) (1 diff)
• libtransmission/metainfo.c (modified) (4 diffs)
• libtransmission/metainfo.h (modified) (1 diff)
• libtransmission/platform.c (modified) (2 diffs)
• libtransmission/platform.h (modified) (1 diff)
• libtransmission/transmission.c (modified) (4 diffs)
• libtransmission/transmission.h (modified) (6 diffs)
• libtransmission/utils.c (modified) (1 diff)
• libtransmission/utils.h (modified) (1 diff)
• macosx/Controller.h (modified) (2 diffs)
• macosx/Controller.m (modified) (11 diffs)
• macosx/Defaults.plist (modified) (2 diffs)
• macosx/English.lproj/MainMenu.nib/classes.nib (modified) (1 diff)
• macosx/English.lproj/MainMenu.nib/info.nib (modified) (2 diffs)
• macosx/English.lproj/MainMenu.nib/keyedobjects.nib (modified) (previous)
• macosx/English.lproj/PrefsWindow.nib/classes.nib (modified) (2 diffs)
• macosx/English.lproj/PrefsWindow.nib/info.nib (modified) (2 diffs)
• macosx/English.lproj/PrefsWindow.nib/keyedobjects.nib (modified) (previous)
• macosx/PrefsController.h (modified) (2 diffs)
• macosx/PrefsController.m (modified) (5 diffs)
• macosx/Torrent.h (modified) (3 diffs)
• macosx/Torrent.m (modified) (9 diffs)

trunk/cli/transmissioncli.c

@@ -110 +110 @@
 
     /* Open and parse torrent file */
-    if( !( tor = tr_torrentInit( h, torrentPath, &error ) ) )
+    if( !( tor = tr_torrentInit( h, torrentPath, 0, &error ) ) )
     {
         printf( "Failed opening torrent file `%s'\n", torrentPath );

trunk/gtk/tr_torrent.c

@@ -271 +271 @@
   errcode = -1;
   handle = tr_torrentInit(tr_backend_handle(TR_BACKEND(backend)),
-                          torrent, &errcode);
+                          torrent, 0, &errcode);
   if(NULL == handle) {
     switch(errcode) {

trunk/libtransmission/fastresume.h

@@ -64 +64 @@
 static char * fastResumeFileName( tr_io_t * io )
 {
-    char * ret, * p;
-    int i;
-
-    asprintf( &ret, "%s/resume.%40d", tr_getPrefsDirectory(), 0 );
-
-    p = &ret[ strlen( ret ) - 2 * SHA_DIGEST_LENGTH ];
-    for( i = 0; i < SHA_DIGEST_LENGTH; i++ )
-    {
-        sprintf( p, "%02x", io->tor->info.hash[i] );
-        p += 2;
-    }
+    char * ret;
+
+    asprintf( &ret, "%s/resume.%s", tr_getCacheDirectory(),
+              io->tor->info.hashString );
 
     return ret;

trunk/libtransmission/inout.c

@@ -217 +217 @@
 
         /* Create folders */
-        p = path;
-        while( ( p = strchr( p, '/' ) ) )
+        if( NULL != ( p = strrchr( path, '/' ) ) )
         {
             *p = '\0';
-            if( stat( path, &sb ) )
+            if( tr_mkdir( path ) )
             {
-                /* Folder doesn't exist yet */
-                mkdir( path, 0777 );
-            }
-            else if( ( sb.st_mode & S_IFMT ) != S_IFDIR )
-            {
-                /* Node exists but isn't a folder */
-                printf( "Remove %s, it's in the way.\n", path );
                 free( path );
                 return 1;
             }
             *p = '/';
-            p++;
         }
 

trunk/libtransmission/internal.h

@@ -46 +46 @@
 #include <netinet/in.h>
 #include <fcntl.h>
+#include <assert.h>
 #ifdef BEOS_NETSERVER
 #  define in_port_t uint16_t

trunk/libtransmission/metainfo.c

@@ -35 +35 @@
  *
  **********************************************************************/
-int tr_metainfoParse( tr_info_t * inf, const char * path )
+int tr_metainfoParse( tr_info_t * inf, const char * path,
+                      const char * savedHash, int saveCopy )
 {
     FILE       * file;
@@ -44 +45 @@
     struct stat sb;
 
-    snprintf( inf->torrent, MAX_PATH_LENGTH, "%s", path );
+    assert( NULL == path || NULL == savedHash );
+    /* if savedHash isn't null, saveCopy should be false */
+    assert( NULL == savedHash || !saveCopy );
+
+    if ( NULL != savedHash )
+    {
+        snprintf( inf->torrent, MAX_PATH_LENGTH, "%s/%s",
+                  tr_getTorrentsDirectory(), savedHash );
+        path = inf->torrent;
+    }
 
     if( stat( path, &sb ) )
@@ -98 +108 @@
     SHA1( (uint8_t *) beInfo->begin,
           (long) beInfo->end - (long) beInfo->begin, inf->hash );
-
-    /* No that we got the hash, we won't need this anymore */
+    for( i = 0; i < SHA_DIGEST_LENGTH; i++ )
+    {
+        sprintf( inf->hashString + i * 2, "%02x", inf->hash[i] );
+    }
+
+    if( saveCopy )
+    {
+        /* Save a copy of the torrent file in the private torrent directory */
+        snprintf( inf->torrent, MAX_PATH_LENGTH, "%s/%s",
+                  tr_getTorrentsDirectory(), inf->hashString );
+        file = fopen( inf->torrent, "wb" );
+        if( !file )
+        {
+            fprintf( stderr, "Could not open file (%s) (%s)\n", inf->torrent, strerror(errno) );
+            tr_bencFree( &meta );
+            free( buf );
+            return 1;
+        }
+        fseek( file, 0, SEEK_SET );
+        if( fwrite( buf, sb.st_size, 1, file ) != 1 )
+        {
+            fprintf( stderr, "Write error (%s)\n", inf->torrent );
+            tr_bencFree( &meta );
+            free( buf );
+            fclose( file );
+            return 1;
+        }
+        fclose( file );
+    }
+    else
+    {
+        snprintf( inf->torrent, MAX_PATH_LENGTH, "%s", path );
+    }
+
+    /* We won't need this anymore */
     free( buf );
 
@@ -225 +268 @@
 }
 
+void tr_metainfoRemoveSaved( const char * hashString )
+{
+    char file[MAX_PATH_LENGTH];
+
+    snprintf( file, MAX_PATH_LENGTH, "%s/%s",
+              tr_getTorrentsDirectory(), hashString );
+    unlink(file);
+}
+
 /***********************************************************************
  * strcatUTF8

trunk/libtransmission/metainfo.h

@@ -26 +26 @@
 #define TR_METAINFO_H 1
 
-int tr_metainfoParse( tr_info_t *, const char * );
+int tr_metainfoParse( tr_info_t *, const char * path,
+                      const char * savedHash, int saveCopy );
 
+void tr_metainfoRemoveSaved( const char * hashString );
 #endif

trunk/libtransmission/platform.c

@@ -27 +27 @@
   #include <FindDirectory.h>
 #endif
-#ifdef SYS_DARWIN
-  #include <sys/types.h>
-  #include <dirent.h>
-#endif
+#include <sys/types.h>
+#include <dirent.h>
 
 #include "transmission.h"
+
+static void
+tr_migrateResume( const char *oldDirectory, const char *newDirectory )
+{
+    DIR * dirh;
+    struct dirent * dirp;
+    char oldFile[MAX_PATH_LENGTH];
+    char newFile[MAX_PATH_LENGTH];
+
+    if( ( dirh = opendir( oldDirectory ) ) )
+    {
+        while( ( dirp = readdir( dirh ) ) )
+        {
+            if( strncmp( "resume.", dirp->d_name, 7 ) )
+            {
+                continue;
+            }
+            snprintf( oldFile, MAX_PATH_LENGTH, "%s/%s",
+                      oldDirectory, dirp->d_name );
+            snprintf( newFile, MAX_PATH_LENGTH, "%s/%s",
+                      newDirectory, dirp->d_name );
+            rename( oldFile, newFile );
+        }
+
+        closedir( dirh );
+    }
+}
 
 char * tr_getPrefsDirectory()
@@ -56 +81 @@
 #endif
 
-        mkdir( prefsDirectory, 0755 );
+    tr_mkdir( prefsDirectory );
     init = 1;
 
 #ifdef SYS_DARWIN
-    DIR * dirh;
-    struct dirent * dirp;
     char oldDirectory[MAX_PATH_LENGTH];
-    char oldFile[MAX_PATH_LENGTH];
-    char newFile[MAX_PATH_LENGTH];
     snprintf( oldDirectory, MAX_PATH_LENGTH, "%s/.transmission",
               getenv( "HOME" ) );
-    if( ( dirh = opendir( oldDirectory ) ) )
-    {
-        while( ( dirp = readdir( dirh ) ) )
-        {
-            if( !strcmp( ".", dirp->d_name ) ||
-                !strcmp( "..", dirp->d_name ) )
-            {
-                continue;
-            }
-            snprintf( oldFile, MAX_PATH_LENGTH, "%s/%s",
-                      oldDirectory, dirp->d_name );
-            snprintf( newFile, MAX_PATH_LENGTH, "%s/%s",
-                      prefsDirectory, dirp->d_name );
-            rename( oldFile, newFile );
-        }
-
-        closedir( dirh );
-        rmdir( oldDirectory );
-    }
+    tr_migrateResume( oldDirectory, prefsDirectory );
+    rmdir( oldDirectory );
 #endif
 
     return prefsDirectory;
+}
+
+char * tr_getCacheDirectory()
+{
+    static char cacheDirectory[MAX_PATH_LENGTH];
+    static int  init = 0;
+
+    if( init )
+    {
+        return cacheDirectory;
+    }
+
+#ifdef SYS_BEOS
+    /* XXX hey Bryan, is this fine with you? */
+    snprintf( cacheDirectory, MAX_PATH_LENGTH, "%s/Cache",
+              tr_getPrefsDirectory() );
+#elif defined( SYS_DARWIN )
+    snprintf( cacheDirectory, MAX_PATH_LENGTH, "%s",
+              tr_getPrefsDirectory() );
+#else
+    snprintf( cacheDirectory, MAX_PATH_LENGTH, "%s/cache",
+              tr_getPrefsDirectory() );
+#endif
+
+    tr_mkdir( cacheDirectory );
+    init = 1;
+
+    if( strcmp( tr_getPrefsDirectory(), cacheDirectory ) )
+    {
+        tr_migrateResume( tr_getPrefsDirectory(), cacheDirectory );
+    }
+
+    return cacheDirectory;
+}
+
+char * tr_getTorrentsDirectory()
+{
+    static char torrentsDirectory[MAX_PATH_LENGTH];
+    static int  init = 0;
+
+    if( init )
+    {
+        return torrentsDirectory;
+    }
+
+#ifdef SYS_BEOS
+    /* XXX hey Bryan, is this fine with you? */
+    snprintf( torrentsDirectory, MAX_PATH_LENGTH, "%s/Torrents",
+              tr_getPrefsDirectory() );
+#elif defined( SYS_DARWIN )
+    snprintf( torrentsDirectory, MAX_PATH_LENGTH,
+              "%s/Library/Application Support/Transmission/Torrents",
+              getenv( "HOME" ) );
+#else
+    snprintf( torrentsDirectory, MAX_PATH_LENGTH, "%s/torrents",
+              tr_getPrefsDirectory() );
+#endif
+
+    tr_mkdir( torrentsDirectory );
+    init = 1;
+
+    return torrentsDirectory;
 }
 

trunk/libtransmission/platform.h

@@ -35 +35 @@
 #endif
 
+char * tr_getCacheDirectory();
+char * tr_getTorrentsDirectory();
+
 void tr_threadCreate ( tr_thread_t *, void (*func)(void *), void * arg );
 void tr_threadJoin   ( tr_thread_t * );

trunk/libtransmission/transmission.c

@@ -28 +28 @@
  * Local prototypes
  **********************************************************************/
+static tr_torrent_t * torrentRealInit( tr_handle_t *, tr_torrent_t * tor,
+                                       int flags, int * error );
 static void torrentReallyStop( tr_torrent_t * );
 static void  downloadLoop( void * );
@@ -175 +177 @@
 }
 
+tr_torrent_t * tr_torrentInit( tr_handle_t * h, const char * path,
+                               int flags, int * error )
+{
+    tr_torrent_t  * tor = calloc( sizeof( tr_torrent_t ), 1 );
+    int             saveCopy = ( TR_FSAVEPRIVATE & flags );
+
+    /* Parse torrent file */
+    if( tr_metainfoParse( &tor->info, path, NULL, saveCopy ) )
+    {
+        *error = TR_EINVALID;
+        free( tor );
+        return NULL;
+    }
+
+    return torrentRealInit( h, tor, flags, error );
+}
+
+tr_torrent_t * tr_torrentInitSaved( tr_handle_t * h, const char * hashStr,
+                                    int flags, int * error )
+{
+    tr_torrent_t  * tor = calloc( sizeof( tr_torrent_t ), 1 );
+
+    /* Parse torrent file */
+    if( tr_metainfoParse( &tor->info, NULL, hashStr, 0 ) )
+    {
+        *error = TR_EINVALID;
+        free( tor );
+        return NULL;
+    }
+
+    return torrentRealInit( h, tor, ( TR_FSAVEPRIVATE | flags ), error );
+}
+
 /***********************************************************************
  * tr_torrentInit
@@ -181 +216 @@
  * to fill it.
  **********************************************************************/
-tr_torrent_t * tr_torrentInit( tr_handle_t * h, const char * path,
-                               int * error )
-{
-    tr_torrent_t  * tor, * tor_tmp;
+static tr_torrent_t * torrentRealInit( tr_handle_t * h, tr_torrent_t * tor,
+                                       int flags, int * error )
+{
+    tr_torrent_t  * tor_tmp;
     tr_info_t     * inf;
     int             i;
     char          * s1, * s2;
 
-    tor = calloc( sizeof( tr_torrent_t ), 1 );
-    inf = &tor->info;
-
-    /* Parse torrent file */
-    if( tr_metainfoParse( inf, path ) )
-    {
-        *error = TR_EINVALID;
-        free( tor );
-        return NULL;
-    }
+    inf        = &tor->info;
+    inf->flags = flags;
 
     /* Make sure this torrent is not already open */
@@ -480 +507 @@
     }
     tr_lockUnlock( &tor->lock );
+}
+
+void tr_torrentRemoveSaved( tr_torrent_t * tor ) {
+    tr_metainfoRemoveSaved( tor->info.hashString );
 }
 

trunk/libtransmission/transmission.h

@@ -60 +60 @@
  * tr_getPrefsDirectory
  ***********************************************************************
- * Returns the full path to the directory used by libtransmission to
- * store the resume files. The string belongs to libtransmission, do
- * not free it.
+ * Returns the full path to a directory which can be used to store
+ * preferences. The string belongs to libtransmission, do not free it.
  **********************************************************************/
 char * tr_getPrefsDirectory();
@@ -124 +123 @@
  * valid torrent file, returns an handle and adds it to the list of
  * torrents (but doesn't start it). Returns NULL and sets *error
- * otherwise.
+ * otherwise.  If the TR_FSAVEPRIVATE flag is passed then a private copy
+ * of the torrent file will be saved.
  **********************************************************************/
 #define TR_EINVALID     1
@@ -131 +131 @@
 #define TR_EOTHER       666
 tr_torrent_t * tr_torrentInit( tr_handle_t *, const char * path,
-                               int * error );
+                               int flags, int * error );
+
+/***********************************************************************
+ * tr_torrentInitSaved
+ ***********************************************************************
+ * Opens and parses a torrent file as with tr_torrentInit, only taking
+ * the hash string of a saved torrent file instead of a filename.  There
+ * are currently no valid flags for this function.
+ **********************************************************************/
+tr_torrent_t * tr_torrentInitSaved( tr_handle_t *, const char * hashStr,
+                                    int flags, int * error );
 
 typedef struct tr_info_s tr_info_t;
@@ -202 +212 @@
 
 /***********************************************************************
+ * tr_torrentRemoveSaved
+ ***********************************************************************
+ * Removes the private saved copy of a torrent file for torrents which
+ * the TR_FSAVEPRIVATE flag is set.
+ **********************************************************************/
+void tr_torrentRemoveSaved( tr_torrent_t * );
+
+/***********************************************************************
  * tr_torrentClose
  ***********************************************************************
@@ -208 +226 @@
  **********************************************************************/
 void tr_torrentClose( tr_handle_t *, tr_torrent_t * );
-
 
 /***********************************************************************
@@ -226 +243 @@
     /* General info */
     uint8_t     hash[SHA_DIGEST_LENGTH];
+    char        hashString[2*SHA_DIGEST_LENGTH+1];
     char        name[MAX_PATH_LENGTH];
+
+    /* Flags */
+#define TR_FSAVEPRIVATE 0x01    /* save a private copy of the torrent */
+    int         flags;
 
     /* Tracker info */

trunk/libtransmission/utils.c

@@ -94 +94 @@
     return NULL;
 }
+
+int tr_mkdir( char * path )
+{
+    char      * p, * pp;
+    struct stat sb;
+    int done;
+
+    p = path;
+    while( '/' == *p )
+      p++;
+    pp = p;
+    done = 0;
+    while( ( p = strchr( pp, '/' ) ) || ( p = strchr( pp, '\0' ) ) )
+    {
+        if( '\0' == *p)
+        {
+            done = 1;
+        }
+        else
+        {
+            *p = '\0';
+        }
+        if( stat( path, &sb ) )
+        {
+            /* Folder doesn't exist yet */
+            if( mkdir( path, 0777 ) )
+            {
+                tr_err( "Could not create directory %s (%s)", path,
+                        strerror( errno ) );
+                *p = '/';
+                return 1;
+            }
+        }
+        else if( ( sb.st_mode & S_IFMT ) != S_IFDIR )
+        {
+            /* Node exists but isn't a folder */
+            tr_err( "Remove %s, it's in the way.", path );
+            *p = '/';
+            return 1;
+        }
+        if( done )
+        {
+            break;
+        }
+        *p = '/';
+        p++;
+        pp = p;
+    }
+
+    return 0;
+}

trunk/libtransmission/utils.h

@@ -37 +37 @@
 
 void * tr_memmem( const void *, size_t, const void *, size_t );
+
+/***********************************************************************
+ * tr_mkdir
+ ***********************************************************************
+ * Create a directory and any needed parent directories.
+ * Note that the string passed in must be writable!
+ **********************************************************************/
+int tr_mkdir( char * path );
 
 /***********************************************************************

trunk/macosx/Controller.h

@@ -97 +97 @@
 
 - (void) removeTorrent:                 (id) sender;
-- (void) removeTorrentDeleteTorrent:    (id) sender;
 - (void) removeTorrentDeleteData:       (id) sender;
-- (void) removeTorrentDeleteBoth:       (id) sender;
 - (void) removeTorrentWithIndex:        (NSIndexSet *) indexSet
-                deleteTorrent:          (BOOL) deleteTorrent
                 deleteData:             (BOOL) deleteData;
                 
@@ -107 +104 @@
                         contextInfo: (NSDictionary *) dict;
 - (void) confirmRemoveTorrents: (NSArray *) torrents
-            deleteTorrent: (BOOL) deleteTorrent
             deleteData: (BOOL) deleteData;
 

trunk/macosx/Controller.m

@@ -525 +525 @@
 
 - (void) removeTorrentWithIndex: (NSIndexSet *) indexSet
-                  deleteTorrent: (BOOL) deleteTorrent
                      deleteData: (BOOL) deleteData
 {
@@ -541 +540 @@
         NSDictionary * dict = [[NSDictionary alloc] initWithObjectsAndKeys:
             torrents, @"Torrents",
-            [NSNumber numberWithBool: deleteTorrent], @"DeleteTorrent",
             [NSNumber numberWithBool: deleteData], @"DeleteData",
             nil];
@@ -552 +550 @@
             title = [NSString stringWithFormat: @"Comfirm Removal of \"%@\"",
                         [[fTorrents objectAtIndex: [fTableView selectedRow]] name]];
-            message = @"This torrent is active. Do you really want to remove it?";
+            message = @"This transfer is active."
+                        " Onced removed, continuing the transfer will require the torrent file."
+                        " Do you really want to remove it?";
         }
         else
@@ -559 +559 @@
             if (selected == active)
                 message = [NSString stringWithFormat:
-                    @"There are %d active torrents. Do you really want to remove them?", active];
+                    @"There are %d active transfers.", active];
             else
                 message = [NSString stringWithFormat:
-                    @"There are %d torrents (%d active). Do you really want to remove them?", selected, active];
+                    @"There are %d transfers (%d active).", selected, active];
+            message = [message stringByAppendingString:
+                @" Onced removed, continuing the transfers will require the torrent files."
+                " Do you really want to remove them?"];
         }
 
@@ -573 +576 @@
     {
         [self confirmRemoveTorrents: torrents
-                deleteTorrent: deleteTorrent
                 deleteData: deleteData];
     }
@@ -584 +586 @@
 
     NSArray * torrents = [dict objectForKey: @"Torrents"];
-    BOOL deleteTorrent = [[dict objectForKey: @"DeleteTorrent"] boolValue];
     BOOL deleteData = [[dict objectForKey: @"DeleteData"] boolValue];
     [dict release];
@@ -591 +592 @@
     {
         [self confirmRemoveTorrents: torrents
-            deleteTorrent: deleteTorrent
             deleteData: deleteData];
     }
@@ -599 +599 @@
 
 - (void) confirmRemoveTorrents: (NSArray *) torrents
-            deleteTorrent: (BOOL) deleteTorrent
             deleteData: (BOOL) deleteData
 {
@@ -610 +609 @@
         if( deleteData )
             [torrent trashData];
-            
-        if( deleteTorrent )
-            [torrent trashTorrent];
-
+
+        [torrent removeForever];
         [fTorrents removeObject: torrent];
     }
@@ -626 +623 @@
 - (void) removeTorrent: (id) sender
 {
-    [self removeTorrentWithIndex: [fTableView selectedRowIndexes] deleteTorrent: NO deleteData: NO];
-}
-
-- (void) removeTorrentDeleteTorrent: (id) sender
-{
-    [self removeTorrentWithIndex: [fTableView selectedRowIndexes] deleteTorrent: YES deleteData: NO];
+    [self removeTorrentWithIndex: [fTableView selectedRowIndexes] deleteData: NO];
 }
 
 - (void) removeTorrentDeleteData: (id) sender
 {
-    [self removeTorrentWithIndex: [fTableView selectedRowIndexes] deleteTorrent: NO deleteData: YES];
-}
-
-- (void) removeTorrentDeleteBoth: (id) sender
-{
-    [self removeTorrentWithIndex: [fTableView selectedRowIndexes] deleteTorrent: YES deleteData: YES];
+    [self removeTorrentWithIndex: [fTableView selectedRowIndexes] deleteData: YES];
 }
 
@@ -1208 +1195 @@
 
     //enable remove items
-    if (action == @selector(removeTorrent:)
-        || action == @selector(removeTorrentDeleteTorrent:)
-        || action == @selector(removeTorrentDeleteData:)
-        || action == @selector(removeTorrentDeleteBoth:))
+    if (action == @selector(removeTorrent:) || action == @selector(removeTorrentDeleteData:))
     {
         BOOL active = NO;

trunk/macosx/Defaults.plist

@@ -19 +19 @@
         <key>CheckUpload</key>
         <true/>
+        <key>DeleteOriginalTorrent</key>
+        <false/>
         <key>DownloadChoice</key>
         <string>Constant</string>
@@ -41 +43 @@
         <key>SUScheduledCheckInterval</key>
         <integer>86400</integer>
+        <key>SavePrivateTorrent</key>
+        <true/>
         <key>ShowInspector</key>
         <false/>

trunk/macosx/English.lproj/MainMenu.nib/classes.nib

@@ -10 +10 @@
                 openShowSheet = id; 
                 removeTorrent = id; 
-                removeTorrentDeleteBoth = id; 
                 removeTorrentDeleteData = id; 
-                removeTorrentDeleteTorrent = id; 
                 resumeAllTorrents = id; 
                 resumeTorrent = id; 

trunk/macosx/English.lproj/MainMenu.nib/info.nib

@@ -10 +10 @@
                 <string>344 478 208 99 0 0 1152 842 </string>
                 <key>1480</key>
-                <string>366 548 420 60 0 0 1152 842 </string>
+                <string>423 269 420 60 0 0 1152 842 </string>
                 <key>29</key>
-                <string>154 771 451 44 0 0 1152 842 </string>
+                <string>195 519 451 44 0 0 1152 842 </string>
                 <key>456</key>
-                <string>212 488 144 137 0 0 1152 842 </string>
+                <string>212 488 153 168 0 0 1152 842 </string>
                 <key>581</key>
                 <string>324 628 112 68 0 0 1152 842 </string>
@@ -31 +31 @@
         <array>
                 <integer>21</integer>
-                <integer>1480</integer>
         </array>
         <key>IBSystem Version</key>

trunk/macosx/English.lproj/PrefsWindow.nib/classes.nib

@@ -11 +11 @@
                 setLimit = id; 
                 setLimitCheck = id; 
+                setMoveTorrent = id; 
                 setPort = id; 
                 setRatio = id; 
@@ -23 +24 @@
                 fBadgeDownloadRateCheck = NSButton; 
                 fBadgeUploadRateCheck = NSButton; 
+                fCopyTorrentCheck = NSButton; 
+                fDeleteOriginalTorrentCheck = NSButton; 
                 fDownloadCheck = NSButton; 
                 fDownloadField = NSTextField; 

trunk/macosx/English.lproj/PrefsWindow.nib/info.nib

@@ -8 +8 @@
         <dict>
                 <key>28</key>
-                <string>347 472 462 212 0 0 1152 842 </string>
+                <string>345 472 462 212 0 0 1152 842 </string>
                 <key>41</key>
-                <string>345 461 462 234 0 0 1152 842 </string>
+                <string>345 423 462 310 0 0 1152 842 </string>
                 <key>66</key>
                 <string>347 526 462 104 0 0 1152 842 </string>
@@ -16 +16 @@
         <key>IBFramework Version</key>
         <string>446.1</string>
+        <key>IBOpenObjects</key>
+        <array>
+                <integer>41</integer>
+        </array>
         <key>IBSystem Version</key>
         <string>8I127</string>

trunk/macosx/PrefsController.h

@@ -37 +37 @@
     IBOutlet NSButton       * fQuitCheck, * fRemoveCheck,
                             * fBadgeDownloadRateCheck, * fBadgeUploadRateCheck,
-                            * fAutoStartCheck;                           
+                            * fAutoStartCheck, * fCopyTorrentCheck, * fDeleteOriginalTorrentCheck;
     IBOutlet NSPopUpButton  * fUpdatePopUp;
 
@@ -59 +59 @@
 - (void) checkUpdate;
 - (void) setAutoStart:          (id) sender;
+- (void) setMoveTorrent:        (id) sender;
 - (void) setDownloadLocation:   (id) sender;
 - (void) folderSheetShow:       (id) sender;

trunk/macosx/PrefsController.m

@@ -117 +117 @@
     int uploadLimit = [fDefaults integerForKey: @"UploadLimit"];
     
-    [fUploadCheck setState: checkUpload ? NSOnState : NSOffState];
+    [fUploadCheck setState: checkUpload];
     [fUploadField setIntValue: uploadLimit];
     [fUploadField setEnabled: checkUpload];
@@ -127 +127 @@
     int downloadLimit = [fDefaults integerForKey: @"DownloadLimit"];
     
-    [fDownloadCheck setState: checkDownload ? NSOnState : NSOffState];
+    [fDownloadCheck setState: checkDownload];
     [fDownloadField setIntValue: downloadLimit];
     [fDownloadField setEnabled: checkDownload];
@@ -135 +135 @@
     //set ratio limit
     BOOL ratioCheck = [fDefaults boolForKey: @"RatioCheck"];
-    [fRatioCheck setState: ratioCheck ? NSOnState : NSOffState];
+    [fRatioCheck setState: ratioCheck];
     [fRatioField setEnabled: ratioCheck];
     [fRatioField setFloatValue: [fDefaults floatForKey: @"RatioLimit"]];
     
     //set remove and quit prompts
-    [fQuitCheck setState: [fDefaults boolForKey: @"CheckQuit"] ?
-        NSOnState : NSOffState];
-    [fRemoveCheck setState: [fDefaults boolForKey: @"CheckRemove"] ?
-        NSOnState : NSOffState];
+    [fQuitCheck setState: [fDefaults boolForKey: @"CheckQuit"]];
+    [fRemoveCheck setState: [fDefaults boolForKey: @"CheckRemove"]];
 
     //set dock badging
@@ -151 +149 @@
     //set auto start
     [fAutoStartCheck setState: [fDefaults boolForKey: @"AutoStartDownload"]];
+    
+    //set private torrents
+    BOOL copyTorrents = [fDefaults boolForKey: @"SavePrivateTorrent"];
+    [fCopyTorrentCheck setState: copyTorrents];
+    
+    [fDeleteOriginalTorrentCheck setEnabled: copyTorrents];
+    [fDeleteOriginalTorrentCheck setState: [fDefaults boolForKey: @"DeleteOriginalTorrent"]];
 
     //set update check
@@ -418 +423 @@
 {
     [fDefaults setBool: [sender state] forKey: @"AutoStartDownload"];
+}
+
+- (void) setMoveTorrent: (id) sender
+{
+    int state = [sender state];
+    if (sender == fCopyTorrentCheck)
+    {
+        [fDefaults setBool: state forKey: @"SavePrivateTorrent"];
+        
+        [fDeleteOriginalTorrentCheck setEnabled: state];
+        if (state == NSOffState)
+        {
+            [fDeleteOriginalTorrentCheck setState: NSOffState];
+            [fDefaults setBool: NO forKey: @"DeleteOriginalTorrent"];
+        }
+    }
+    else
+        [fDefaults setBool: state forKey: @"DeleteOriginalTorrent"];
 }
 

trunk/macosx/Torrent.h

@@ -36 +36 @@
     tr_info_t    * fInfo;
     tr_stat_t    * fStat;
+    
     BOOL         fResumeOnWake;
     NSDate       * fDate;
+    
+    BOOL        fPrivateTorrent;
 
     NSUserDefaults  * fDefaults;
@@ -56 +59 @@
 - (void)       getAvailability: (int8_t *) tab size: (int) size;
 
-- (void)       update;
-- (void)       start;
-- (void)       stop;
-- (void)       sleep;
-- (void)       wakeUp;
+- (void)        update;
+- (void)        start;
+- (void)        stop;
+- (void)        removeForever;
+- (void)        sleep;
+- (void)        wakeUp;
 
 - (float)       ratio;
@@ -69 +73 @@
 
 - (void)        reveal;
-- (void)        trashTorrent;
 - (void)        trashData;
 

trunk/macosx/Torrent.m

@@ -29 +29 @@
 @interface Torrent (Private)
 
-- (void) trashPath: (NSString *) path;
 - (id) initWithPath: (NSString *) path lib: (tr_handle_t *) lib date: (NSDate *) date
         stopRatioSetting: (NSNumber *) stopRatioSetting ratioLimit: (NSNumber *) ratioLimit;
+- (id) initWithHash: (NSString *) hashString lib: (tr_handle_t *) lib date: (NSDate *) date
+        stopRatioSetting: (NSNumber *) stopRatioSetting ratioLimit: (NSNumber *) ratioLimit;
+- (id) initForSuccessWithDate: (NSDate *) date stopRatioSetting: (NSNumber *)
+            stopRatioSetting ratioLimit: (NSNumber *) ratioLimit;
+
+- (void) trashPath: (NSString *) path;
 
 @end
@@ -40 +45 @@
 - (id) initWithPath: (NSString *) path lib: (tr_handle_t *) lib
 {
-    return [self initWithPath: path lib: lib
-            date: nil stopRatioSetting: nil
-            ratioLimit: nil];
+    id torrent = [self initWithPath: path lib: lib date: nil
+                    stopRatioSetting: nil ratioLimit: nil];
+                    
+    if (!torrent)
+        return nil;
+
+    if (fPrivateTorrent && [fDefaults boolForKey: @"DeleteOriginalTorrent"])
+        [self trashPath: path];
+    
+    return torrent;
 }
 
 - (id) initWithHistory: (NSDictionary *) history lib: (tr_handle_t *) lib
 {
-    self = [self initWithPath: [history objectForKey: @"TorrentPath"]
+    //load from saved torrent file if set to, otherwise try to load from where torrent file should be
+    NSNumber * privateCopy;
+    if ((privateCopy = [history objectForKey: @"PrivateCopy"]) && [privateCopy boolValue])
+        self = [self initWithHash: [history objectForKey: @"TorrentHash"]
+            lib: lib date: [history objectForKey: @"Date"]
+            stopRatioSetting: [history objectForKey: @"StopRatioSetting"]
+            ratioLimit: [history objectForKey: @"RatioLimit"]];
+    else
+        self = [self initWithPath: [history objectForKey: @"TorrentPath"]
             lib: lib date: [history objectForKey: @"Date"]
             stopRatioSetting: [history objectForKey: @"StopRatioSetting"]
@@ -69 +89 @@
 - (NSDictionary *) history
 {
-    return [NSDictionary dictionaryWithObjectsAndKeys:
-            [self torrentLocation], @"TorrentPath",
-            [self downloadFolder], @"DownloadFolder",
-            [self isActive] ? @"NO" : @"YES", @"Paused",
-            [self date], @"Date",
-            [NSNumber numberWithInt: fStopRatioSetting], @"StopRatioSetting",
-            [NSNumber numberWithFloat: fRatioLimit], @"RatioLimit", nil];
+    NSMutableDictionary * history = [NSMutableDictionary dictionaryWithObjectsAndKeys:
+                    [NSNumber numberWithBool: fPrivateTorrent], @"PrivateCopy",
+                    [self downloadFolder], @"DownloadFolder",
+                    [self isActive] ? @"NO" : @"YES", @"Paused",
+                    [self date], @"Date",
+                    [NSNumber numberWithInt: fStopRatioSetting], @"StopRatioSetting",
+                    [NSNumber numberWithFloat: fRatioLimit], @"RatioLimit", nil];
+            
+    if (fPrivateTorrent)
+        [history setObject: [self hashString] forKey: @"TorrentHash"];
+    else
+        [history setObject: [self torrentLocation] forKey: @"TorrentPath"];
+    
+    return history;
 }
 
@@ -128 +155 @@
     [fProgressString setString: @""];
     if ([self progress] < 1.0)
-        [fProgressString appendFormat: @"%@ of %@ completed (%.2f%%)", [NSString stringForFileSize:
+        [fProgressString appendFormat: @"%@ of %@ (%.2f%%)", [NSString stringForFileSize:
                 [self downloaded]], [NSString stringForFileSize: [self size]], 100 * [self progress]];
     else
@@ -213 +240 @@
 }
 
+- (void) removeForever
+{
+    if (fInfo->flags & TR_FSAVEPRIVATE)
+        tr_torrentRemoveSaved(fHandle);
+}
+
 - (void) sleep
 {
@@ -262 +295 @@
 }
 
-- (void) trashTorrent
-{
-    [self trashPath: [self torrentLocation]];
-}
-
 - (void) trashData
 {
@@ -315 +343 @@
 - (NSString *) hashString
 {
-    NSMutableString * string = [NSMutableString
-        stringWithCapacity: SHA_DIGEST_LENGTH];
-    int i;
-    for( i = 0; i < SHA_DIGEST_LENGTH; i++ )
-    {
-        [string appendFormat: @"%02x", fInfo->hash[i]];
-    }
-    return string;
+    return [NSString stringWithUTF8String: fInfo->hashString];
 }
 
 - (NSString *) torrentLocation
 {
-    return [NSString stringWithUTF8String: fInfo->torrent];;
+    return [NSString stringWithUTF8String: fInfo->torrent];
 }
 
@@ -488 +509 @@
 
     fLib = lib;
+    fDefaults = [NSUserDefaults standardUserDefaults];
+
+    fPrivateTorrent = [fDefaults boolForKey: @"SavePrivateTorrent"];
 
     int error;
-    if (!path || !(fHandle = tr_torrentInit(fLib, [path UTF8String], &error)))
+    if (!path || !(fHandle = tr_torrentInit(fLib, [path UTF8String],
+                    fPrivateTorrent ? TR_FSAVEPRIVATE : 0, & error)))
     {
         [self release];
         return nil;
     }
-    
+
+    return [self initForSuccessWithDate: date stopRatioSetting: stopRatioSetting ratioLimit: ratioLimit];
+}
+
+- (id) initWithHash: (NSString *) hashString lib: (tr_handle_t *) lib date: (NSDate *) date
+        stopRatioSetting: (NSNumber *) stopRatioSetting ratioLimit: (NSNumber *) ratioLimit
+{
+    if (!(self = [super init]))
+        return nil;
+
+    fLib = lib;
+    fDefaults = [NSUserDefaults standardUserDefaults];
+    
+    fPrivateTorrent = YES;
+
+    int error;
+    if (!hashString || !(fHandle = tr_torrentInitSaved(fLib, [hashString UTF8String], TR_FSAVEPRIVATE, & error)))
+    {
+        [self release];
+        return nil;
+    }
+    
+    return [self initForSuccessWithDate: date stopRatioSetting: stopRatioSetting ratioLimit: ratioLimit];
+}
+
+- (id) initForSuccessWithDate: (NSDate *) date stopRatioSetting: (NSNumber *)
+            stopRatioSetting ratioLimit: (NSNumber *) ratioLimit
+{
     fInfo = tr_torrentInfo( fHandle );
-    
-    fDefaults = [NSUserDefaults standardUserDefaults];
 
     fDate = date ? [date retain] : [[NSDate alloc] init];
@@ -518 +568 @@
     return self;
 }
+
 
 - (void) trashPath: (NSString *) path