Changeset 3268

Timestamp:

Oct 2, 2007, 3:33:17 AM (15 years ago)

Author:

charles

Message:

fix looong-standing potential dangling pointer bug reported by BMW

Location:

trunk/libtransmission

Files:

• peer-mgr.c (modified) (1 diff)
• torrent.c (modified) (1 diff)

trunk/libtransmission/peer-mgr.c

@@ -1321 +1321 @@
         stat->port             = peer->port;
         stat->from             = atom->from;
-        stat->client           = peer->client;
+        stat->client           = tr_strdup( peer->client ? peer->client : "" );
         stat->progress         = peer->progress;
         stat->isEncrypted      = tr_peerIoIsEncrypted( peer->io ) ? 1 : 0;

trunk/libtransmission/torrent.c

@@ -905 +905 @@
 }
 
-void tr_torrentPeersFree( tr_peer_stat * peers, int peerCount UNUSED )
-{
+void
+tr_torrentPeersFree( tr_peer_stat * peers, int peerCount )
+{
+    int i;
+    for( i=0; i<peerCount; ++i )
+        tr_free( (char*) peers[i].client );
     tr_free( peers );
 }