Changeset 3350


Ignore:
Timestamp:
Oct 10, 2007, 5:25:56 PM (15 years ago)
Author:
charles
Message:

Better GNOME Integration (#338): (1) follow HIG recommendation that dialog titles be the name of the command that opened the dialog (2) rename stop-torrent as pause-torrent in the underlying gtk code

Location:
trunk/gtk
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/gtk/actions.c

    r3294 r3350  
    7272  { "recheck-torrent", GTK_STOCK_REFRESH,
    7373    N_("Re_check"), NULL, NULL, G_CALLBACK(action_cb) },
    74   { "stop-torrent", GTK_STOCK_MEDIA_PAUSE,
     74  { "pause-torrent", GTK_STOCK_MEDIA_PAUSE,
    7575    N_("_Pause"), "<control>P", NULL, G_CALLBACK(action_cb) },
    7676  { "remove-torrent", GTK_STOCK_REMOVE,
  • trunk/gtk/main.c

    r3328 r3350  
    199199    int status = 0;
    200200    gtk_tree_selection_selected_foreach( s, accumulateStatusForeach, &status );
    201     action_sensitize( "stop-torrent", (status & TR_STATUS_ACTIVE) != 0);
     201    action_sensitize( "pause-torrent", (status & TR_STATUS_ACTIVE) != 0);
    202202    action_sensitize( "start-torrent", (status & TR_STATUS_INACTIVE) != 0);
    203203    action_sensitize( "remove-torrent", status != 0);
     
    988988        changed |= gtk_tree_selection_count_selected_rows( s ) != 0;
    989989    }
    990     else if (!strcmp (action_name, "stop-torrent"))
     990    else if (!strcmp (action_name, "pause-torrent"))
    991991    {
    992992        GtkTreeSelection * s = tr_window_get_selection(data->wind);
  • trunk/gtk/makemeta-ui.c

    r3333 r3350  
    226226    ui->handle = handle;
    227227
    228     d = gtk_dialog_new_with_buttons( _("Make a New Torrent"),
     228    d = gtk_dialog_new_with_buttons( _("Create New Torrent"),
    229229                                     parent,
    230230                                     GTK_DIALOG_DESTROY_WITH_PARENT,
  • trunk/gtk/torrent-inspector.c

    r3333 r3350  
    15981598
    15991599  /* create the dialog */
    1600   pch = g_strdup_printf ("%s: %s",
    1601                          g_get_application_name(),
    1602                          _("Torrent Inspector"));
     1600  pch = _( "Torrent Info" );
    16031601  d = gtk_dialog_new_with_buttons (pch, parent, 0,
    16041602                                   GTK_STOCK_CLOSE, GTK_RESPONSE_CLOSE,
     
    16071605  g_signal_connect (d, "response", G_CALLBACK (response_cb), gtor);
    16081606  g_object_weak_ref (G_OBJECT(gtor), torrent_destroyed, d);
    1609   g_free (pch);
    16101607
    16111608
  • trunk/gtk/tr_prefs.c

    r3209 r3350  
    198198    GtkWidget * d;
    199199
    200     d = gtk_dialog_new_with_buttons( _("Transmission: Preferences"), parent,
     200    d = gtk_dialog_new_with_buttons( _("Preferences"), parent,
    201201                                     GTK_DIALOG_DESTROY_WITH_PARENT,
    202202                                     GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,
  • trunk/gtk/ui.h

    r3126 r3350  
    66"      <menuitem action='start-torrent'/>\n"
    77"      <menuitem action='update-tracker'/>\n"
    8 "      <menuitem action='stop-torrent'/>\n"
     8"      <menuitem action='pause-torrent'/>\n"
    99"      <menuitem action='recheck-torrent'/>\n"
    1010"      <menuitem action='remove-torrent'/>\n"
     
    3232"    <toolitem action='add-torrent'/>\n"
    3333"    <toolitem action='start-torrent'/>\n"
    34 "    <toolitem action='stop-torrent'/>\n"
     34"    <toolitem action='pause-torrent'/>\n"
    3535"    <toolitem action='remove-torrent'/>\n"
    3636"    <separator/>\n"
     
    4242"    <separator/>\n"
    4343"    <menuitem action='start-torrent'/>\n"
    44 "    <menuitem action='stop-torrent'/>\n"
     44"    <menuitem action='pause-torrent'/>\n"
    4545"    <menuitem action='recheck-torrent'/>\n"
    4646"    <separator/>\n"
Note: See TracChangeset for help on using the changeset viewer.