Changeset 3353


Ignore:
Timestamp:
Oct 10, 2007, 6:52:08 PM (15 years ago)
Author:
charles
Message:

minor tweaks: (1) list None' instead of 0 b' for zero bytes, such as in UL speed or the "corrupted" field. (2) the properties icon is too horrible to keep -- use `torrent details' instead. (3) list active maintainers first in credits. (4) tweak the "about" dialog's client description a bit to better match the style of other gtk+ apps.

Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed
  • trunk/AUTHORS

    r3343 r3353  
    33
    44Lead Developers <transmission-dev@m0k.org>
     5        Mitchell Livingston <livings124@gmail.com>  (Mac OS X interface, Backend)
     6        Charles Kerr <charles@rebelbase.com>  (Backend, GTK+ client)
    57        Eric Petit <titer@m0k.org>  (Creator)
    6         Josh Elsasser <josh@elsasser.org>  (Back-end, GTK+ interface, Daemon interface)
    7         Mitchell Livingston <livings124@gmail.com>  (Mac OS X interface, Back-end)
    8         Charles Kerr <charles@rebelbase.com>  (Back-end, GTK+, wxWidgets)
     8        Josh Elsasser <josh@elsasser.org>  (Daemon, Backend, GTK+ interface)
    99        Bryan Varner <bryan@varnernet.com>  (BeOS interface)
    1010
  • trunk/NEWS

    r3334 r3353  
    1414   + Optimizations to decrease memory usage
    1515   + Various smaller interface additions and improvements
     16 - GTK:
     17   + Various smaller interface improvements
    1618
    17190.82 (2007/09/09)
  • trunk/gtk/actions.c

    r3352 r3353  
    8888  { "edit-preferences", GTK_STOCK_PREFERENCES,
    8989    NULL, NULL, NULL, G_CALLBACK(action_cb) },
    90   { "show-torrent-properties", GTK_STOCK_PROPERTIES,
    91     NULL, "<alt>Return", NULL, G_CALLBACK(action_cb) },
     90  { "show-torrent-details", GTK_STOCK_INFO,
     91    N_("_Details"), "<alt>Return", NULL, G_CALLBACK(action_cb) },
    9292  { "show-about-dialog", GTK_STOCK_ABOUT,
    9393    N_("_About Transmission"), NULL, NULL, G_CALLBACK(action_cb) },
  • trunk/gtk/main.c

    r3352 r3353  
    203203    action_sensitize( "remove-torrent", status != 0);
    204204    action_sensitize( "verify-torrent", status != 0);
    205     action_sensitize( "show-torrent-properties", status != 0);
     205    action_sensitize( "show-torrent-details", status != 0);
    206206
    207207    status = 0;
     
    882882  GtkWidget * w = gtk_about_dialog_new ();
    883883  GtkAboutDialog * a = GTK_ABOUT_DIALOG (w);
    884   const char *authors[] = { "Eric Petit (Back-end; OS X)",
    885                             "Josh Elsasser (Back-end; GTK+)",
     884  const char *authors[] = { "Charles Kerr (Back-end; GTK+)",
    886885                            "Mitchell Livingston (Back-end; OS X)",
    887                             "Charles Kerr (Back-end; GTK+)",
     886                            "Eric Petit (Back-end; OS X)",
     887                            "Josh Elsasser (Daemon; Back-end; GTK+)",
    888888                            "Bryan Varner (BeOS)",
    889889                            NULL };
     
    894894#endif
    895895  gtk_about_dialog_set_logo_icon_name( a, "transmission-logo" );
    896   gtk_about_dialog_set_comments( a, _("A GTK+ BitTorrent Client.") );
     896  gtk_about_dialog_set_comments( a, _("A simple yet powerful BitTorrent Client") );
    897897  gtk_about_dialog_set_website( a, "http://transmission.m0k.org/" );
    898898  gtk_about_dialog_set_copyright( a, _("Copyright 2005-2007 The Transmission Project") );
     
    10001000        changed |= gtk_tree_selection_count_selected_rows( s ) != 0;
    10011001    }
    1002     else if (!strcmp (action_name, "show-torrent-properties"))
     1002    else if (!strcmp (action_name, "show-torrent-details"))
    10031003    {
    10041004        GtkTreeSelection * s = tr_window_get_selection(data->wind);
  • trunk/gtk/torrent-inspector.c

    r3352 r3353  
    15991599  /* create the dialog */
    16001600  size = readablesize( info->totalSize );
    1601   pch = g_strdup_printf( _( "Properties for %s (%s)" ), info->name, size );
     1601  pch = g_strdup_printf( _( "Details for %s (%s)" ), info->name, size );
    16021602  d = gtk_dialog_new_with_buttons (pch, parent, 0,
    16031603                                   GTK_STOCK_CLOSE, GTK_RESPONSE_CLOSE,
  • trunk/gtk/tr_window.c

    r3352 r3353  
    174174                     gpointer            user_data  UNUSED )
    175175{
    176     action_activate( "show-torrent-properties" );
     176    action_activate( "show-torrent-details" );
    177177}
    178178
  • trunk/gtk/ui.h

    r3352 r3353  
    99"      <menuitem action='verify-torrent'/>\n"
    1010"      <menuitem action='remove-torrent'/>\n"
    11 "      <menuitem action='show-torrent-properties'/>\n"
     11"      <menuitem action='show-torrent-details'/>\n"
    1212"      <separator/>\n"
    1313"      <menuitem action='create-torrent'/>\n"
     
    3535"    <toolitem action='remove-torrent'/>\n"
    3636"    <separator/>\n"
    37 "    <toolitem action='show-torrent-properties'/>\n"
     37"    <toolitem action='show-torrent-details'/>\n"
    3838"  </toolbar>\n"
    3939"\n"
    4040"  <popup name='main-window-popup'>\n"
    41 "    <menuitem action='show-torrent-properties'/>\n"
     41"    <menuitem action='show-torrent-details'/>\n"
    4242"    <separator/>\n"
    4343"    <menuitem action='start-torrent'/>\n"
  • trunk/gtk/util.c

    r3333 r3353  
    6262  double small = size;
    6363
     64  if( !size )
     65    return g_strdup_printf( _("None") );
     66
    6467  for(ii = 0; ii + 1 < ALEN(sizestrs) && 1024.0 <= small / 1024.0; ii++)
    6568    small /= 1024.0;
     
    7982  const guint64 bps = KiBps * 1024;
    8083  char * str = readablesize (bps);
    81   char * ret = g_strdup_printf ("%s/s", str);
     84  char * ret = bps ? g_strdup_printf ("%s/s", str) : g_strdup( str );
    8285  g_free (str);
    8386  return ret;
Note: See TracChangeset for help on using the changeset viewer.