Changeset 3353

Timestamp:

Oct 10, 2007, 6:52:08 PM (15 years ago)

Author:

charles

Message:

minor tweaks: (1) list None' instead of 0 b' for zero bytes, such as in UL speed or the "corrupted" field. (2) the properties icon is too horrible to keep -- use `torrent details' instead. (3) list active maintainers first in credits. (4) tweak the "about" dialog's client description a bit to better match the style of other gtk+ apps.

Location:

trunk

Files:

• AUTHORS (modified) (1 diff)
• NEWS (modified) (1 diff)
• gtk/actions.c (modified) (1 diff)
• gtk/main.c (modified) (4 diffs)
• gtk/torrent-inspector.c (modified) (1 diff)
• gtk/tr_window.c (modified) (1 diff)
• gtk/ui.h (modified) (2 diffs)
• gtk/util.c (modified) (2 diffs)

trunk/AUTHORS

@@ -3 +3 @@
 
 Lead Developers <transmission-dev@m0k.org>
+        Mitchell Livingston <livings124@gmail.com>  (Mac OS X interface, Backend)
+        Charles Kerr <charles@rebelbase.com>  (Backend, GTK+ client)
         Eric Petit <titer@m0k.org>  (Creator)
-        Josh Elsasser <josh@elsasser.org>  (Back-end, GTK+ interface, Daemon interface)
-        Mitchell Livingston <livings124@gmail.com>  (Mac OS X interface, Back-end)
-        Charles Kerr <charles@rebelbase.com>  (Back-end, GTK+, wxWidgets)
+        Josh Elsasser <josh@elsasser.org>  (Daemon, Backend, GTK+ interface)
         Bryan Varner <bryan@varnernet.com>  (BeOS interface)
 

trunk/NEWS

@@ -14 +14 @@
    + Optimizations to decrease memory usage
    + Various smaller interface additions and improvements
+ - GTK:
+   + Various smaller interface improvements
 
 0.82 (2007/09/09)

trunk/gtk/actions.c

@@ -88 +88 @@
   { "edit-preferences", GTK_STOCK_PREFERENCES,
     NULL, NULL, NULL, G_CALLBACK(action_cb) },
-  { "show-torrent-properties", GTK_STOCK_PROPERTIES,
-    NULL, "<alt>Return", NULL, G_CALLBACK(action_cb) },
+  { "show-torrent-details", GTK_STOCK_INFO,
+    N_("_Details"), "<alt>Return", NULL, G_CALLBACK(action_cb) },
   { "show-about-dialog", GTK_STOCK_ABOUT,
     N_("_About Transmission"), NULL, NULL, G_CALLBACK(action_cb) },

trunk/gtk/main.c

@@ -203 +203 @@
     action_sensitize( "remove-torrent", status != 0);
     action_sensitize( "verify-torrent", status != 0);
-    action_sensitize( "show-torrent-properties", status != 0);
+    action_sensitize( "show-torrent-details", status != 0);
 
     status = 0;
@@ -882 +882 @@
   GtkWidget * w = gtk_about_dialog_new ();
   GtkAboutDialog * a = GTK_ABOUT_DIALOG (w);
-  const char *authors[] = { "Eric Petit (Back-end; OS X)",
-                            "Josh Elsasser (Back-end; GTK+)",
+  const char *authors[] = { "Charles Kerr (Back-end; GTK+)",
                             "Mitchell Livingston (Back-end; OS X)",
-                            "Charles Kerr (Back-end; GTK+)",
+                            "Eric Petit (Back-end; OS X)",
+                            "Josh Elsasser (Daemon; Back-end; GTK+)",
                             "Bryan Varner (BeOS)", 
                             NULL };
@@ -894 +894 @@
 #endif
   gtk_about_dialog_set_logo_icon_name( a, "transmission-logo" );
-  gtk_about_dialog_set_comments( a, _("A GTK+ BitTorrent Client.") );
+  gtk_about_dialog_set_comments( a, _("A simple yet powerful BitTorrent Client") );
   gtk_about_dialog_set_website( a, "http://transmission.m0k.org/" );
   gtk_about_dialog_set_copyright( a, _("Copyright 2005-2007 The Transmission Project") );
@@ -1000 +1000 @@
         changed |= gtk_tree_selection_count_selected_rows( s ) != 0;
     }
-    else if (!strcmp (action_name, "show-torrent-properties"))
+    else if (!strcmp (action_name, "show-torrent-details"))
     {
         GtkTreeSelection * s = tr_window_get_selection(data->wind);

trunk/gtk/torrent-inspector.c

@@ -1599 +1599 @@
   /* create the dialog */
   size = readablesize( info->totalSize );
-  pch = g_strdup_printf( _( "Properties for %s (%s)" ), info->name, size );
+  pch = g_strdup_printf( _( "Details for %s (%s)" ), info->name, size );
   d = gtk_dialog_new_with_buttons (pch, parent, 0,
                                    GTK_STOCK_CLOSE, GTK_RESPONSE_CLOSE,

trunk/gtk/tr_window.c

@@ -174 +174 @@
                      gpointer            user_data  UNUSED )
 {
-    action_activate( "show-torrent-properties" );
+    action_activate( "show-torrent-details" );
 }
 

trunk/gtk/ui.h

@@ -9 +9 @@
 "      <menuitem action='verify-torrent'/>\n"
 "      <menuitem action='remove-torrent'/>\n"
-"      <menuitem action='show-torrent-properties'/>\n"
+"      <menuitem action='show-torrent-details'/>\n"
 "      <separator/>\n"
 "      <menuitem action='create-torrent'/>\n"
@@ -35 +35 @@
 "    <toolitem action='remove-torrent'/>\n"
 "    <separator/>\n"
-"    <toolitem action='show-torrent-properties'/>\n"
+"    <toolitem action='show-torrent-details'/>\n"
 "  </toolbar>\n"
 "\n"
 "  <popup name='main-window-popup'>\n"
-"    <menuitem action='show-torrent-properties'/>\n"
+"    <menuitem action='show-torrent-details'/>\n"
 "    <separator/>\n"
 "    <menuitem action='start-torrent'/>\n"

trunk/gtk/util.c

@@ -62 +62 @@
   double small = size;
 
+  if( !size )
+    return g_strdup_printf( _("None") );
+
   for(ii = 0; ii + 1 < ALEN(sizestrs) && 1024.0 <= small / 1024.0; ii++)
     small /= 1024.0;
@@ -79 +82 @@
   const guint64 bps = KiBps * 1024;
   char * str = readablesize (bps);
-  char * ret = g_strdup_printf ("%s/s", str);
+  char * ret = bps ? g_strdup_printf ("%s/s", str) : g_strdup( str );
   g_free (str);
   return ret;