Changeset 3682

Timestamp:

Nov 1, 2007, 6:41:13 PM (15 years ago)

Author:

charles

Message:

fix handshake memory leak reported by MishaS (#442)

Location:

trunk

Files:

• NEWS (modified) (2 diffs)
• libtransmission/handshake.c (modified) (3 diffs)

trunk/NEWS

@@ -8 +8 @@
 - All Platforms:
    + Fix 0.90 data corruption bugs.
+   + Fix 0.90 small memory leaks.
 - OS X:
    + Leopard: Fix bug with typing values in Inspector->Options
@@ -15 +16 @@
    + Fix localization error in torrent inspector's dates
    
-
 0.91 (2007/10/28)
 - All Platforms:

trunk/libtransmission/handshake.c

@@ -811 +811 @@
     int i;
     const size_t needlen = handshake->ia_len;
-    struct evbuffer * outbuf = evbuffer_new( );
+    struct evbuffer * outbuf;
     uint32_t crypto_select;
 
@@ -823 +823 @@
 dbgmsg( handshake, "parseHandshake returned %d", i );
     if( i != HANDSHAKE_OK ) {
-        evbuffer_free( outbuf );
         tr_handshakeDone( handshake, FALSE );
         return READ_DONE;
@@ -833 +832 @@
 
     tr_cryptoEncryptInit( handshake->crypto );
+    outbuf = evbuffer_new( );
 
 dbgmsg( handshake, "sending vc" );