Changeset 3770

Timestamp:

Nov 9, 2007, 4:10:48 PM (15 years ago)

Author:

charles

Message:

move the gateway discovery from init() to start() so that tr_init() doesn't block.

File:

• trunk/libtransmission/upnp.c (modified) (4 diffs)

trunk/libtransmission/upnp.c

@@ -30 +30 @@
     unsigned int isForwarding : 1;
     unsigned int isEnabled : 1;
+    unsigned int hasDiscovered : 1;
 };
 
@@ -40 +41 @@
 {
     tr_upnp * ret = tr_new0( tr_upnp, 1 );
-    struct UPNPDev * devlist = upnpDiscover( 2000, NULL );
-    if( UPNP_GetValidIGD( devlist, &ret->urls, &ret->data, ret->lanaddr, sizeof(ret->lanaddr))) {
-        tr_dbg( "Found Internet Gateway Device '%s'", ret->urls.controlURL );
-        tr_dbg( "Local LAN IP Address is '%s'", ret->lanaddr );
-    }
     ret->port = -1;
-    freeUPNPDevlist( devlist );
     return ret;
 }
@@ -54 +49 @@
 {
     tr_upnpStop( handle );
-    FreeUPNPUrls( &handle->urls );
+    if( handle->hasDiscovered )
+        FreeUPNPUrls( &handle->urls );
     tr_free( handle );
 }
@@ -65 +61 @@
 tr_upnpStart( tr_upnp * handle )
 {
+    if( !handle->hasDiscovered )
+    {
+        struct UPNPDev * devlist = upnpDiscover( 2000, NULL );
+        if( UPNP_GetValidIGD( devlist, &handle->urls, &handle->data, handle->lanaddr, sizeof(handle->lanaddr))) {
+            tr_dbg( "Found Internet Gateway Device '%s'", handle->urls.controlURL );
+            tr_dbg( "Local LAN IP Address is '%s'", handle->lanaddr );
+        }
+        freeUPNPDevlist( devlist );
+        handle->hasDiscovered = 1;
+    }
+
     handle->isEnabled = 1;