Changeset 3970

Timestamp:

Nov 26, 2007, 4:05:12 AM (15 years ago)

Author:

charles

Message:

disable SWIFT on private trackers, because they are typically ratio-based sites where you *want* to upload as much as possible to deadbeats

Location:

trunk/libtransmission

Files:

• internal.h (modified) (1 diff)
• peer-msgs.c (modified) (2 diffs)
• torrent.c (modified) (1 diff)

trunk/libtransmission/internal.h

@@ -44 +44 @@
 #endif
 
+int tr_torrentIsPrivate( const tr_torrent * );
+
 void tr_torrentRecheckCompleteness( tr_torrent * );
 

trunk/libtransmission/peer-msgs.c

@@ -1443 +1443 @@
 **/
 
+static int
+isSwiftEnabled( const tr_peermsgs * msgs )
+{
+    /* rationale: SWIFT is good for getting rid of deadbeats, but most
+     * private trackers have ratios where you _want_ to feed deadbeats
+     * as much as possible.  So we disable SWIFT on private torrents */
+    return SWIFT_ENABLED
+        && !tr_torrentIsSeed( msgs->torrent )
+        && !tr_torrentIsPrivate( msgs->torrent );
+}
+
 static size_t
 getUploadMax( const tr_peermsgs * msgs )
@@ -1448 +1459 @@
     static const size_t maxval = ~0;
     const tr_torrent * tor = msgs->torrent;
-    const int useSwift = SWIFT_ENABLED && !tr_torrentIsSeed( msgs->torrent );
+    const int useSwift = isSwiftEnabled( msgs );
     const size_t swiftLeft = msgs->info->credit;
     size_t speedLeft;

trunk/libtransmission/torrent.c

@@ -643 +643 @@
 
 int
+tr_torrentIsPrivate( const tr_torrent * tor )
+{
+    return tor
+        && tor->info.isPrivate;
+}
+
+int
 tr_torrentIsPexEnabled( const tr_torrent * tor )
 {
-    return !tor->info.isPrivate && !tor->pexDisabled;
+    return tor
+        && !tr_torrentIsPrivate( tor )
+        && !tor->pexDisabled;
 }