Changeset 4083

Timestamp:

Dec 6, 2007, 8:25:38 PM (14 years ago)

Author:

livings124

Message:

more cleanup of the group toolbar button code

Location:

trunk/macosx

Files:

• ButtonGroupToolbarItem.h (modified) (1 diff)
• ButtonGroupToolbarItem.m (modified) (1 diff)
• Controller.h (modified) (1 diff)
• Controller.m (modified) (5 diffs)

trunk/macosx/ButtonGroupToolbarItem.h

@@ -28 +28 @@
 {
     NSArray * fLabels, * fIdentifiers;
+    
+    BOOL fMenuCreated;
 }
 

trunk/macosx/ButtonGroupToolbarItem.m

@@ -57 +57 @@
 - (NSMenuItem *) menuFormRepresentation
 {
-    NSMenuItem * menuItem = [[NSMenuItem alloc] initWithTitle: [self label] action: NULL keyEquivalent: @""];
-    NSMenu * menu = [[NSMenu alloc] initWithTitle: [self label]];
-    [menuItem setSubmenu: menu];
+    NSMenuItem * menuItem;
+    if (!fMenuCreated)
+    {
+        fMenuCreated = YES;
+        
+        menuItem = [[[NSMenuItem alloc] initWithTitle: [self label] action: NULL keyEquivalent: @""] autorelease];
+        NSMenu * menu = [[NSMenu alloc] initWithTitle: [self label]];
+        [menuItem setSubmenu: menu];
+        
+        [menu setAutoenablesItems: NO];
+        
+        NSMenuItem * addItem;
+        int i;
+        for (i = 0; i < [(NSSegmentedControl *)[self view] segmentCount]; i++)
+        {
+            addItem = [[NSMenuItem alloc] initWithTitle: [fLabels objectAtIndex: i] action: [self action] keyEquivalent: @""];
+            [addItem setTarget: [self target]];
+            [addItem setTag: i];
+            
+            [menu addItem: addItem];
+            [addItem release];
+        }
+        
+        [menu release];
+        [self setMenuFormRepresentation: menuItem];
+    }
+    else
+        menuItem = [super menuFormRepresentation];
     
-    [menu setAutoenablesItems: NO];
-    
-    NSMenuItem * addItem;
     int i;
     for (i = 0; i < [(NSSegmentedControl *)[self view] segmentCount]; i++)
-    {
-        addItem = [[NSMenuItem alloc] initWithTitle: [fLabels objectAtIndex: i] action: [self action] keyEquivalent: @""];
-        [addItem setTarget: [self target]];
-        [addItem setTag: i];
-        [addItem setEnabled: [[self target] validateToolbarItem:
+        [[[menuItem submenu] itemAtIndex: i] setEnabled: [[self target] validateToolbarItem:
             [[[NSToolbarItem alloc] initWithItemIdentifier: [fIdentifiers objectAtIndex: i]] autorelease]]];
-        
-        [menu addItem: addItem];
-        [addItem release];
-    }
     
-    [menu release];
-    return [menuItem autorelease];
+    return menuItem;
 }
 

trunk/macosx/Controller.h

@@ -214 +214 @@
 - (void) showFilterBar: (BOOL) show animate: (BOOL) animate;
 
+- (void) allToolbarClicked: (id) sender;
 - (void) selectedToolbarClicked: (id) sender;
 

trunk/macosx/Controller.m

@@ -56 +56 @@
 #define TOOLBAR_PAUSE_RESUME_SELECTED   @"Toolbar Pause / Resume Selected"
 #define TOOLBAR_FILTER                  @"Toolbar Toggle Filter"
+
+typedef enum
+{
+    TOOLBAR_PAUSE_TAG = 0,
+    TOOLBAR_RESUME_TAG = 1
+} toolbarGroupTag;
 
 #define SORT_DATE       @"Date"
@@ -2693 +2699 @@
         [item setAutovalidates: NO];
     }
-    else if ([ident isEqualToString: TOOLBAR_PAUSE_ALL])
-    {
-        [item setLabel: NSLocalizedString(@"Pause All", "Pause All toolbar item -> label")];
-        [item setPaletteLabel: [item label]];
-        [item setToolTip: NSLocalizedString(@"Pause all transfers", "Pause All toolbar item -> tooltip")];
-        [item setImage: [NSImage imageNamed: @"PauseAll.png"]];
-        [item setTarget: self];
-        [item setAction: @selector(stopAllTorrents:)];
-    }
-    else if ([ident isEqualToString: TOOLBAR_RESUME_ALL])
-    {
-        [item setLabel: NSLocalizedString(@"Resume All", "Resume All toolbar item -> label")];
-        [item setPaletteLabel: [item label]];
-        [item setToolTip: NSLocalizedString(@"Resume all transfers", "Resume All toolbar item -> tooltip")];
-        [item setImage: [NSImage imageNamed: @"ResumeAll.png"]];
-        [item setTarget: self];
-        [item setAction: @selector(resumeAllTorrents:)];
-    }
     else if ([ident isEqualToString: TOOLBAR_PAUSE_RESUME_ALL])
     {
@@ -2734 +2722 @@
                                         NSLocalizedString(@"Resume All", "All toolbar item -> label"), nil]];
         
-        [segmentedControl setImage: [NSImage imageNamed: @"PauseAll.png"] forSegment: 0];
+        [segmentedControl setImage: [NSImage imageNamed: @"PauseAll.png"] forSegment: TOOLBAR_PAUSE_TAG];
         [(NSSegmentedCell *)[segmentedControl cell] setToolTip: NSLocalizedString(@"Pause all transfers",
-                                                        "All toolbar item -> tooltip") forSegment: 0];
-        
-        [segmentedControl setImage: [NSImage imageNamed: @"ResumeAll.png"] forSegment: 1];
+                                                        "All toolbar item -> tooltip") forSegment: TOOLBAR_PAUSE_TAG];
+        
+        [segmentedControl setImage: [NSImage imageNamed: @"ResumeAll.png"] forSegment: TOOLBAR_RESUME_TAG];
         [(NSSegmentedCell *)[segmentedControl cell] setToolTip: NSLocalizedString(@"Resume all transfers",
-                                                        "All toolbar item -> tooltip") forSegment: 1];
+                                                        "All toolbar item -> tooltip") forSegment: TOOLBAR_RESUME_TAG];
         
         [segmentedControl release];
@@ -2769 +2757 @@
                                         NSLocalizedString(@"Resume Selected", "Selected toolbar item -> label"), nil]];
         
-        [segmentedControl setImage: [NSImage imageNamed: @"PauseSelected.png"] forSegment: 0];
+        [segmentedControl setImage: [NSImage imageNamed: @"PauseSelected.png"] forSegment: TOOLBAR_PAUSE_TAG];
         [(NSSegmentedCell *)[segmentedControl cell] setToolTip: NSLocalizedString(@"Pause selected transfers",
-                                                        "Selected toolbar item -> tooltip") forSegment: 0];
-        
-        [segmentedControl setImage: [NSImage imageNamed: @"ResumeSelected.png"] forSegment: 1];
+                                                        "Selected toolbar item -> tooltip") forSegment: TOOLBAR_PAUSE_TAG];
+        
+        [segmentedControl setImage: [NSImage imageNamed: @"ResumeSelected.png"] forSegment: TOOLBAR_RESUME_TAG];
         [(NSSegmentedCell *)[segmentedControl cell] setToolTip: NSLocalizedString(@"Resume selected transfers",
-                                                        "Selected toolbar item -> tooltip") forSegment: 1];
+                                                        "Selected toolbar item -> tooltip") forSegment: TOOLBAR_RESUME_TAG];
         
         [segmentedControl release];
@@ -2796 +2784 @@
 }
 
-#warning use constants
 - (void) allToolbarClicked: (id) sender
 {
-    if ([sender tag] == 0)
-        [self stopAllTorrents: sender];
-    else if ([sender tag] == 1)
-        [self resumeAllTorrents: sender];
-    else;
-}
-
-#warning use constants
+    switch ([sender tag])
+    {
+        case TOOLBAR_PAUSE_TAG:
+            [self stopAllTorrents: sender];
+            break;
+        case TOOLBAR_RESUME_TAG:
+            [self resumeAllTorrents: sender];
+            break;
+    }
+}
+
 - (void) selectedToolbarClicked: (id) sender
 {
-    if ([sender tag] == 0)
-        [self stopSelectedTorrents: sender];
-    else if ([sender tag] == 1)
-        [self resumeSelectedTorrents: sender];
-    else;
+    switch ([sender tag])
+    {
+        case TOOLBAR_PAUSE_TAG:
+            [self stopSelectedTorrents: sender];
+            break;
+        case TOOLBAR_RESUME_TAG:
+            [self resumeSelectedTorrents: sender];
+            break;
+    }
 }