Changeset 4084

Timestamp:

Dec 6, 2007, 8:46:58 PM (14 years ago)

Author:

livings124

Message:

fix the toolbar customization sheet

Location:

trunk/macosx

Files:

• ButtonGroupToolbarItem.h (modified) (1 diff)
• ButtonGroupToolbarItem.m (modified) (2 diffs)
• Controller.m (modified) (4 diffs)

trunk/macosx/ButtonGroupToolbarItem.h

@@ -27 +27 @@
 @interface ButtonGroupToolbarItem : NSToolbarItem
 {
-    NSArray * fLabels, * fIdentifiers;
-    
-    BOOL fMenuCreated;
+    NSArray * fIdentifiers;
 }
 
-- (void) setLabels: (NSArray *) labels;
 - (void) setIdentifiers: (NSArray *) identifiers;
 
+- (void) createMenu: (NSArray *) labels;
+
 @end

trunk/macosx/ButtonGroupToolbarItem.m

@@ -33 +33 @@
 }
 
-- (void) setLabels: (NSArray *) labels
-{
-    [fLabels release];
-    fLabels = [labels retain];
-}
-
 - (void) setIdentifiers: (NSArray *) identifiers
 {
@@ -55 +49 @@
 }
 
+- (void) createMenu: (NSArray *) labels
+{
+    NSMenuItem * menuItem = [[NSMenuItem alloc] initWithTitle: [self label] action: NULL keyEquivalent: @""];
+    NSMenu * menu = [[NSMenu alloc] initWithTitle: [self label]];
+    [menuItem setSubmenu: menu];
+    
+    [menu setAutoenablesItems: NO];
+    
+    NSMenuItem * addItem;
+    int i;
+    for (i = 0; i < [(NSSegmentedControl *)[self view] segmentCount]; i++)
+    {
+        addItem = [[NSMenuItem alloc] initWithTitle: [labels objectAtIndex: i] action: [self action] keyEquivalent: @""];
+        [addItem setTarget: [self target]];
+        [addItem setTag: i];
+        
+        [menu addItem: addItem];
+        [addItem release];
+    }
+    
+    [menu release];
+    [self setMenuFormRepresentation: menuItem];
+    [menuItem release];
+}
+
 - (NSMenuItem *) menuFormRepresentation
 {
-    NSMenuItem * menuItem;
-    if (!fMenuCreated)
-    {
-        fMenuCreated = YES;
-        
-        menuItem = [[[NSMenuItem alloc] initWithTitle: [self label] action: NULL keyEquivalent: @""] autorelease];
-        NSMenu * menu = [[NSMenu alloc] initWithTitle: [self label]];
-        [menuItem setSubmenu: menu];
-        
-        [menu setAutoenablesItems: NO];
-        
-        NSMenuItem * addItem;
-        int i;
-        for (i = 0; i < [(NSSegmentedControl *)[self view] segmentCount]; i++)
-        {
-            addItem = [[NSMenuItem alloc] initWithTitle: [fLabels objectAtIndex: i] action: [self action] keyEquivalent: @""];
-            [addItem setTarget: [self target]];
-            [addItem setTag: i];
-            
-            [menu addItem: addItem];
-            [addItem release];
-        }
-        
-        [menu release];
-        [self setMenuFormRepresentation: menuItem];
-    }
-    else
-        menuItem = [super menuFormRepresentation];
+    NSMenuItem * menuItem = [super menuFormRepresentation];
     
     int i;

trunk/macosx/Controller.m

@@ -2719 +2719 @@
         
         [groupItem setIdentifiers: [NSArray arrayWithObjects: TOOLBAR_PAUSE_ALL, TOOLBAR_RESUME_ALL, nil]];
-        [groupItem setLabels: [NSArray arrayWithObjects: NSLocalizedString(@"Pause All", "All toolbar item -> label"),
-                                        NSLocalizedString(@"Resume All", "All toolbar item -> label"), nil]];
         
         [segmentedControl setImage: [NSImage imageNamed: @"PauseAll.png"] forSegment: TOOLBAR_PAUSE_TAG];
@@ -2729 +2727 @@
         [(NSSegmentedCell *)[segmentedControl cell] setToolTip: NSLocalizedString(@"Resume all transfers",
                                                         "All toolbar item -> tooltip") forSegment: TOOLBAR_RESUME_TAG];
+        
+        [groupItem createMenu: [NSArray arrayWithObjects: NSLocalizedString(@"Pause All", "All toolbar item -> label"),
+                                        NSLocalizedString(@"Resume All", "All toolbar item -> label"), nil]];
         
         [segmentedControl release];
@@ -2754 +2755 @@
         
         [groupItem setIdentifiers: [NSArray arrayWithObjects: TOOLBAR_PAUSE_SELECTED, TOOLBAR_RESUME_SELECTED, nil]];
-        [groupItem setLabels: [NSArray arrayWithObjects: NSLocalizedString(@"Pause Selected", "Selected toolbar item -> label"),
-                                        NSLocalizedString(@"Resume Selected", "Selected toolbar item -> label"), nil]];
         
         [segmentedControl setImage: [NSImage imageNamed: @"PauseSelected.png"] forSegment: TOOLBAR_PAUSE_TAG];
@@ -2764 +2763 @@
         [(NSSegmentedCell *)[segmentedControl cell] setToolTip: NSLocalizedString(@"Resume selected transfers",
                                                         "Selected toolbar item -> tooltip") forSegment: TOOLBAR_RESUME_TAG];
+        
+        [groupItem createMenu: [NSArray arrayWithObjects: NSLocalizedString(@"Pause Selected", "Selected toolbar item -> label"),
+                                        NSLocalizedString(@"Resume Selected", "Selected toolbar item -> label"), nil]];
         
         [segmentedControl release];