Changeset 4838

Timestamp:

Jan 26, 2008, 3:43:47 AM (15 years ago)

Author:

charles

Message:

(1.0x) #613: fix handshake protocol error reported by brad- and tracked down w/Lacrocivious' help.

Location:

branches/1.0x

Files:

• NEWS (modified) (2 diffs)
• libtransmission/peer-msgs.c (modified) (2 diffs)

branches/1.0x/NEWS

@@ -4 +4 @@
 - All Platforms:
    + Fix handshake bug with peers that support LTEP
+   + Fix handshake bug with mainline BitTorrent
 
 1.02 (2008/01/22)
@@ -9 +10 @@
    + Fix 1.00 bug that choked some models of routers
    + Fix 1.00 crash in peer handshake
-   + Fix 1.01 bug that sometimes froze the app for a long time
+   + Fix 1.00 bug that sometimes froze the app for a long time
    + Minor improvements to the command-line client
 - GTK+

branches/1.0x/libtransmission/peer-msgs.c

@@ -1892 +1892 @@
     m->clientSuggestedPieces = tr_bitfieldNew( m->torrent->info.pieceCount );
     *setme = tr_publisherSubscribe( m->publisher, func, userData );
-    
-    tr_peerIoSetTimeoutSecs( m->io, 150 ); /* timeout after N seconds of inactivity */
-    tr_peerIoSetIOFuncs( m->io, canRead, didWrite, gotError, m );
-    ratePulse( m );
 
     if ( tr_peerIoSupportsLTEP( m->io ) )
         sendLtepHandshake( m );
 
+    /* bitfield/have-all/have-none must preceed other non-handshake messages... */
     if ( !tr_peerIoSupportsFEXT( m->io ) )
         sendBitfield( m );
@@ -1913 +1910 @@
         }
     }
+    
+    tr_peerIoSetTimeoutSecs( m->io, 150 ); /* timeout after N seconds of inactivity */
+    tr_peerIoSetIOFuncs( m->io, canRead, didWrite, gotError, m );
+    ratePulse( m );
 
     return m;