Changeset 5543

Timestamp:

Apr 6, 2008, 4:50:41 PM (14 years ago)

Author:

charles

Message:

#846: transmissioncli attempts to bind to port even when not needed

Location:

trunk

Files:

• cli/transmissioncli.c (modified) (1 diff)
• libtransmission/shared.c (modified) (1 diff)

trunk/cli/transmissioncli.c

@@ -140 +140 @@
     }
 
+    /* don't bind the port if we're just running the CLI 
+     * to get metainfo or to create a torrent */
+    if( showInfo || ( sourceFile != NULL ) )
+        bindPort = -1;
+
     /* Initialize libtransmission */
     h = tr_initFull( tr_getDefaultConfigDir(),

trunk/libtransmission/shared.c

@@ -111 +111 @@
     }
 
-    if( s->bindPort != s->publicPort )
+    if( ( s->publicPort > 0 ) && ( s->bindPort != s->publicPort ) )
     {
         int socket;
         errno = 0;
         socket = tr_netBindTCP( s->publicPort );
+fprintf( stderr, "opening socket on %d to listen\n", s->publicPort );
         if( socket >= 0 ) {
             tr_ninf( getKey(), _( "Opened port %d to listen for incoming peer connections" ), s->publicPort );