Changeset 5925 for trunk/macosx/TorrentTableView.m

Timestamp:

May 23, 2008, 8:36:19 PM (14 years ago)

Author:

livings124

Message:

even more efficiency when drawing custom row colors

File:

• trunk/macosx/TorrentTableView.m (modified) (3 diffs)

trunk/macosx/TorrentTableView.m

@@ -703 +703 @@
 {
     NSColor * altColor = [[NSColor controlAlternatingRowBackgroundColors] objectAtIndex: 1];
+    [altColor set];
     
     NSRect visibleRect = clipRect;
     NSRange rows = [self rowsInRect: visibleRect];
     BOOL start = YES;
+    int i;
     
     if (rows.length > 0)
     {
-        int i;
-        
         //determine what the first row color should be
         if ([[self itemAtRow: rows.location] isKindOfClass: [Torrent class]])
@@ -737 +737 @@
             
             if (!start)
-            {
-                [altColor set];
                 NSRectFill([self rectOfRow: i]);
-            }
             
             start = !start;
@@ -751 +748 @@
     
     //remaining visible rows continue alternating
-    NSRect rowRect = visibleRect;
-    rowRect.size.height = [self rowHeight] + [self intercellSpacing].height;
-    
-    while (rowRect.origin.y < NSMaxY(visibleRect))
+    float height = [self rowHeight] + [self intercellSpacing].height;
+    int numberOfRects = ceil(visibleRect.size.height / height);
+    visibleRect.size.height = height;
+    
+    for (i=0; i<numberOfRects; i++)
     {
         if (!start)
-        {
-            [altColor set];
-            NSRectFill(rowRect);
-        }
+            NSRectFill(visibleRect);
         
         start = !start;
-        rowRect.origin.y += rowRect.size.height;
+        visibleRect.origin.y += height;
     }