Changeset 7106


Ignore:
Timestamp:
Nov 13, 2008, 4:10:04 AM (12 years ago)
Author:
charles
Message:

(gtk) #1453: follow Gnome HIG; the "details" dialog should be a "properties" dialog

Location:
trunk/gtk
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/gtk/actions.c

    r6949 r7106  
    153153    { "edit-preferences",     GTK_STOCK_PREFERENCES, NULL,
    154154      NULL,            NULL,                   G_CALLBACK( action_cb ) },
    155     { "show-torrent-details", GTK_STOCK_INFO,
    156       N_( "_Details" ), "<alt>Return", N_( "Torrent details" ), G_CALLBACK(
    157           action_cb ) },
     155    { "show-torrent-properties", GTK_STOCK_PROPERTIES,
     156      NULL, "<alt>Return", N_( "Torrent properties" ), G_CALLBACK( action_cb ) },
    158157    { "open-torrent-folder",  GTK_STOCK_OPEN,
    159158      N_( "_Open Folder" ), NULL, NULL, G_CALLBACK( action_cb ) },
  • trunk/gtk/details.c

    r7086 r7106  
    14781478    GtkWidget *     d, *n, *w;
    14791479    tr_torrent *    tor = tr_torrent_handle ( gtor );
    1480     char            sizeStr[64];
    14811480    char            title[512];
    14821481    const tr_info * info = tr_torrent_info ( gtor );
    14831482
    14841483    /* create the dialog */
    1485     tr_strlsize( sizeStr, info->totalSize, sizeof( sizeStr ) );
    1486     /* %1$s is torrent name
    1487        %2$s its file size */
    1488     g_snprintf( title, sizeof( title ), _(
    1489                     "Details for %1$s (%2$s)" ), info->name, sizeStr );
     1484    g_snprintf( title, sizeof( title ), _( "%s Properties" ), info->name );
    14901485    d = gtk_dialog_new_with_buttons ( title, parent, 0,
    14911486                                      GTK_STOCK_CLOSE, GTK_RESPONSE_CLOSE,
  • trunk/gtk/file-list.c

    r7072 r7106  
    795795                                                "expand", TRUE,
    796796                                                /* Translators: this is a column
    797                                                    header in Files tab, Details
     797                                                   header in Files tab, Properties
    798798                                                   dialog;
    799799                                                   Don't include the prefix
     
    817817
    818818    rend = gtk_cell_renderer_progress_new( );
    819     /* Translators: this is a column header in Files tab, Details dialog;
     819    /* Translators: this is a column header in Files tab, Properties dialog;
    820820       Don't include the prefix "filedetails|" in the translation. */
    821821    col = gtk_tree_view_column_new_with_attributes( Q_( "filedetails|Progress" ), rend, NULL );
     
    826826    /* add "enabled" column */
    827827    rend = gtk_cell_renderer_toggle_new( );
    828     /* Translators: this is a column header in Files tab, Details dialog;
     828    /* Translators: this is a column header in Files tab, Properties dialog;
    829829       Don't include the prefix "filedetails|" in the translation.
    830830       The items for this column are checkboxes (yes/no) */
  • trunk/gtk/main.c

    r7020 r7106  
    221221    action_sensitize( "verify-torrent", counts.totalCount != 0 );
    222222    action_sensitize( "open-torrent-folder", counts.totalCount == 1 );
    223     action_sensitize( "show-torrent-details", counts.totalCount == 1 );
     223    action_sensitize( "show-torrent-properties", counts.totalCount == 1 );
    224224
    225225    canUpdate = 0;
     
    14851485        gtk_tree_selection_selected_foreach( s, openFolderForeach, data );
    14861486    }
    1487     else if( !strcmp ( action_name, "show-torrent-details" ) )
     1487    else if( !strcmp ( action_name, "show-torrent-properties" ) )
    14881488    {
    14891489        GtkTreeSelection * s = tr_window_get_selection( data->wind );
  • trunk/gtk/tr-window.c

    r7069 r7106  
    129129                    gpointer            user_data UNUSED )
    130130{
    131     action_activate( "show-torrent-details" );
     131    action_activate( "show-torrent-properties" );
    132132}
    133133
  • trunk/gtk/ui.h

    r6870 r7106  
    66    "      <menuitem action='new-torrent'/>\n"
    77    "      <separator/>\n"
    8     "      <menuitem action='show-torrent-details'/>\n"
     8    "      <menuitem action='show-torrent-properties'/>\n"
    99    "      <menuitem action='open-torrent-folder'/>\n"
    1010    "      <separator/>\n"
     
    5656    "    <toolitem action='remove-torrent'/>\n"
    5757    "    <separator/>\n"
    58     "    <toolitem action='show-torrent-details'/>\n"
     58    "    <toolitem action='show-torrent-properties'/>\n"
    5959    "  </toolbar>\n"
    6060    "\n"
    6161    "  <popup name='main-window-popup'>\n"
    62     "    <menuitem action='show-torrent-details'/>\n"
     62    "    <menuitem action='show-torrent-properties'/>\n"
    6363    "    <menuitem action='open-torrent-folder'/>\n"
    6464    "    <separator/>\n"
Note: See TracChangeset for help on using the changeset viewer.