Changeset 7267

Timestamp:

Dec 4, 2008, 5:31:13 AM (12 years ago)

Author:

charles

Message:

(1.4x libT) #1557: handshake peer-id doesn't match the peer-id sent in the tracker announce

Location:

branches/1.4x/libtransmission

Files:

• handshake.c (modified) (3 diffs)
• torrent.h (modified) (1 diff)
• tracker.c (modified) (1 diff)

branches/1.4x/libtransmission/handshake.c

@@ -205 +205 @@
                        int *          setme_len )
 {
-    uint8_t *       buf = tr_new0( uint8_t, HANDSHAKE_SIZE );
-    uint8_t *       walk = buf;
-    const uint8_t * torrentHash = tr_cryptoGetTorrentHash(
-        handshake->crypto );
-    const uint8_t * peerId = tr_getPeerId( );
+    uint8_t          * buf = tr_new0( uint8_t, HANDSHAKE_SIZE );
+    uint8_t          * walk = buf;
+    const uint8_t    * torrentHash = tr_cryptoGetTorrentHash( handshake->crypto );
+    const tr_torrent * tor = tr_torrentFindFromHash( handshake->handle, torrentHash );
+    const uint8_t    * peerId = tor && tor->peer_id ? tor->peer_id : tr_getPeerId( );
 
     memcpy( walk, HANDSHAKE_NAME, HANDSHAKE_NAME_LEN );
@@ -682 +682 @@
         if( !tr_torrentExists( handshake->handle, hash ) )
         {
-            dbgmsg(
-                handshake,
-                "peer is trying to connect to us for a torrent we don't have." );
+            dbgmsg( handshake, "peer is trying to connect to us for a torrent we don't have." );
             return tr_handshakeDone( handshake, FALSE );
         }
@@ -705 +703 @@
 
     /**
-    ***  If this is an incoming message, then we need to send a response
-    ***handshake
+    ***  If it's an incoming message, we need to send a response handshake
     **/
 

branches/1.4x/libtransmission/torrent.h

@@ -182 +182 @@
     uint8_t                  obfuscatedHash[SHA_DIGEST_LENGTH];
 
+    /* If the initiator of the connection receives a handshake in which the
+     * peer_id does not match the expected peerid, then the initiator is
+     * expected to drop the connection. Note that the initiator presumably
+     * received the peer information from the tracker, which includes the
+     * peer_id that was registered by the peer. The peer_id from the tracker
+     * and in the handshake are expected to match.
+     */
+    uint8_t * peer_id;
+
     /* Where to download */
-    char *  downloadDir;
+    char * downloadDir;
 
     /* How many bytes we ask for per request */

branches/1.4x/libtransmission/tracker.c

@@ -1076 +1076 @@
     if( t && !t->isRunning )
     {
+        tr_torrent * tor;
+
+        /* change the peer-id */
         tr_free( t->peer_id );
         t->peer_id = tr_peerIdNew( );
+        if(( tor = tr_torrentFindFromHash( t->session, t->hash ))) {
+            tr_free( tor->peer_id );
+            tor->peer_id = (uint8_t*) tr_strdup( t->peer_id );
+        }
 
         t->isRunning = 1;