Changeset 7336

Timestamp:

Dec 9, 2008, 10:05:45 PM (12 years ago)

Author:

charles

Message:

(trunk libT) experimental code to try & fix the "one torrent / one peer eats all my bandwidth" issue reported in the forums & irc

File:

• trunk/libtransmission/bandwidth.c (modified) (5 diffs)

trunk/libtransmission/bandwidth.c

@@ -18 +18 @@
 #include "transmission.h"
 #include "bandwidth.h"
+#include "crypto.h"
 #include "iobuf.h"
 #include "ptrarray.h"
@@ -245 +246 @@
 #endif
 
-void
-tr_bandwidthAllocate( tr_bandwidth  * b,
-                      tr_direction    dir,
-                      int             period_msec )
+static void
+allocateBandwidth( tr_bandwidth  * b,
+                   tr_direction    dir,
+                   int             period_msec,
+                   tr_ptrArray   * addme_buffers )
 {
     assert( isBandwidth( b ) );
@@ -256 +258 @@
     {
         const double desiredSpeed = b->band[dir].desiredSpeed;
-#if 0
-        const double currentSpeed = getSpeed( &b->band[dir].piece, HISTORY_MSEC - period_msec );
-        const double pulseCount = ( HISTORY_MSEC - period_msec ) / (double)period_msec;
-        const double nextPulseSpeed = desiredSpeed * ( pulseCount + 1 ) - ( currentSpeed * pulseCount );
-#else
         const double nextPulseSpeed = desiredSpeed;
-#endif
         b->band[dir].bytesLeft = MAX( 0.0, nextPulseSpeed * 1024.0 * period_msec / 1000.0 );
 
@@ -276 +272 @@
     if( !b->band[dir].isLimited || ( b->band[dir].bytesLeft > 0 ) )
     {
-        int i, n=0;
-        short what = dir==TR_UP ? EV_WRITE : EV_READ;
-        struct tr_iobuf ** iobufs = (struct tr_iobuf**) tr_ptrArrayPeek( b->iobufs, &n );
+        int i;
+        const int n = tr_ptrArraySize( b->iobufs );
+        for( i=0; i<n; ++i )
+            tr_ptrArrayAppend( addme_buffers, tr_ptrArrayNth( b->iobufs, i ) );
+    }
+
 #ifdef DEBUG_DIRECTION
 if( ( dir == DEBUG_DIRECTION ) && ( n > 1 ) )
 fprintf( stderr, "bandwidth %p has %d iobufs\n", b, n );
 #endif
-        for( i=0; i<n; ++i )
-            tr_iobuf_enable( iobufs[i], what );
-    }
 
     /* all children should reallocate too */
@@ -296 +292 @@
 }
 
+void
+tr_bandwidthAllocate( tr_bandwidth  * b,
+                      tr_direction    dir,
+                      int             period_msec )
+{
+    int n;
+    tr_ptrArray * tmp;
+    struct tr_iobuf ** buffers;
+    const short what = dir==TR_UP ? EV_WRITE : EV_READ;
+
+    tmp = tr_ptrArrayNew( );
+    allocateBandwidth( b, dir, period_msec, tmp );
+    buffers = (struct tr_iobuf**) tr_ptrArrayPeek( b->children, &n );
+
+    /* notify the io buffers in a random order s.t. no
+       particular peer gets to hog all the bandwidth */
+    while( n > 0 ) {
+        const int i = tr_cryptoRandInt( n );
+        tr_iobuf_enable( buffers[i], what );
+        buffers[i] = buffers[n-1];
+        --n;
+    }
+
+    tr_ptrArrayFree( tmp, NULL );
+}
+
 /***
 ****