Changeset 7439 for trunk/libtransmission/net.c

Timestamp:

Dec 20, 2008, 8:51:32 AM (13 years ago)

Author:

jhujhiti

Message:

(trunk libT) Don't log two "errors" we expect to see from time-to-time.

EAFNOSUPPORT: On OS X, socket() incorrectly throws EAFNOSUPPORT for certain
IP/Port combinations. There is nothing we can do about this.

ENETUNREACH: #1606 is evidence that some trackers return IPv6 peers when
contacted over IPv4. This code will silently ignore "network unreachable"
errors for IPv6 connections.

File:

• trunk/libtransmission/net.c (modified) (1 diff)

trunk/libtransmission/net.c

@@ -403 +403 @@
     {
         int tmperrno;
-        tr_err( _( "Couldn't connect socket %d to %s, port %d (errno %d - %s)" ),
-               s, tr_ntop_non_ts( addr ), (int)port, sockerrno, tr_strerror( sockerrno ) );
         tmperrno = sockerrno;
+        if( tmperrno != ENETUNREACH || addr->type == TR_AF_INET )
+            tr_err( _( "Couldn't connect socket %d to %s, port %d (errno %d - %s)" ),
+                    s, tr_ntop_non_ts( addr ), (int)port, tmperrno,
+                    tr_strerror( tmperrno ) );
         tr_netClose( s );
         s = -tmperrno;