Changeset 7458

Timestamp:

Dec 22, 2008, 4:55:07 AM (12 years ago)

Author:

charles

Message:

(trunk libT) peer-io.c: remove dead code and get rid of a couple of GOTOs

File:

• trunk/libtransmission/peer-io.c (modified) (26 diffs)

trunk/libtransmission/peer-io.c

@@ -96 +96 @@
 
     tr_address         addr;
-    tr_list          * output_datatypes; /* struct tr_datatype */
 
     tr_can_read_cb     canRead;
@@ -103 +102 @@
     void *             userData;
 
-    size_t             bufferSize[2];
-
     tr_bandwidth     * bandwidth;
     tr_crypto        * crypto;
@@ -110 +107 @@
     struct evbuffer  * inbuf;
     struct evbuffer  * outbuf;
+    tr_list          * outbuf_datatypes; /* struct tr_datatype */
 
     struct event       event_read;
@@ -124 +122 @@
     while( bytes_transferred )
     {
-        struct tr_datatype * next = io->output_datatypes->data;
+        struct tr_datatype * next = io->outbuf_datatypes->data;
         const size_t payload = MIN( next->length, bytes_transferred );
         const size_t overhead = getPacketOverhead( payload );
@@ -139 +137 @@
         next->length -= payload;
         if( !next->length )
-            tr_free( tr_list_pop_front( &io->output_datatypes ) );
+            tr_free( tr_list_pop_front( &io->outbuf_datatypes ) );
     }
 }
@@ -212 +210 @@
 {
     int res;
-    short what = EVBUFFER_READ;
     tr_peerIo * io = vio;
     const size_t howmuch = tr_bandwidthClamp( io->bandwidth, TR_DOWN, io->session->so_rcvbuf );
@@ -228 +225 @@
 
     res = evbuffer_read( io->inbuf, fd, howmuch );
-    if( res == -1 ) {
-        if( errno == EAGAIN || errno == EINTR )
-            goto reschedule;
-        /* error case */
-        what |= EVBUFFER_ERROR;
-    } else if( res == 0 ) {
-        /* eof case */
-        what |= EVBUFFER_EOF;
-    }
-
-    if( res <= 0 )
-        goto error;
-
-    tr_peerIoSetEnabled( io, dir, TRUE );
-
-    /* Invoke the user callback - must always be called last */
-    canReadWrapper( io );
-
-    return;
-
- reschedule:
-    tr_peerIoSetEnabled( io, dir, TRUE );
-    return;
-
- error:
-    if( io->gotError != NULL )
-        io->gotError( io, what, io->userData );
+
+    if( res > 0 )
+    {
+        tr_peerIoSetEnabled( io, dir, TRUE );
+
+        /* Invoke the user callback - must always be called last */
+        canReadWrapper( io );
+    }
+    else
+    {
+        short what = EVBUFFER_READ;
+
+        if( res == 0 ) /* EOF */
+            what |= EVBUFFER_EOF;
+        else if( res == -1 ) {
+            if( errno == EAGAIN || errno == EINTR ) {
+                tr_peerIoSetEnabled( io, dir, TRUE );
+                return;
+            }
+            what |= EVBUFFER_ERROR;
+        }
+
+        if( io->gotError != NULL )
+            io->gotError( io, what, io->userData );
+    }
 }
 
@@ -341 +336 @@
 ***
 **/
-
-
-static int
-isFlag( int flag )
-{
-    return( ( flag == 0 ) || ( flag == 1 ) );
-}
 
 static tr_peerIo*
@@ -375 +363 @@
     event_set( &io->event_read, io->socket, EV_READ, event_read_cb, io );
     event_set( &io->event_write, io->socket, EV_WRITE, event_write_cb, io );
-#if 0
-    bufevNew( io );
-#endif
     tr_peerIoSetBandwidth( io, session->bandwidth );
     return io;
@@ -389 +374 @@
 {
     assert( session );
-    assert( addr );
+    assert( tr_isAddress( addr ) );
     assert( socket >= 0 );
 
@@ -404 +389 @@
 
     assert( session );
-    assert( addr );
+    assert( tr_isAddress( addr ) );
     assert( torrentHash );
 
@@ -426 +411 @@
     tr_netClose( io->socket );
     tr_cryptoFree( io->crypto );
-    tr_list_free( &io->output_datatypes, tr_free );
+    tr_list_free( &io->outbuf_datatypes, tr_free );
 
     io->magicNumber = 0xDEAD;
@@ -516 +501 @@
         tr_bandwidth * bandwidth = io->bandwidth;
         tr_peerIoSetBandwidth( io, NULL );
-
         tr_netSetTOS( io->socket, io->session->peerSocketTOS );
-#if 0
-        bufevNew( io );
-#endif
-
         tr_peerIoSetBandwidth( io, bandwidth );
         return 0;
@@ -594 +574 @@
 {
     assert( tr_isPeerIo( io ) );
-    assert( isFlag( flag ) );
-
-    dbgmsg( io, "setting FEXT support flag to %d", (flag?1:0) );
+    assert( _isBool( flag ) );
+
+    dbgmsg( io, "setting FEXT support flag to %d", (flag!=0) );
     io->fastExtensionSupported = flag;
 }
@@ -617 +597 @@
 {
     assert( tr_isPeerIo( io ) );
-    assert( isFlag( flag ) );
-
-    dbgmsg( io, "setting LTEP support flag to %d", (flag?1:0) );
+    assert( _isBool( flag ) );
+
+    dbgmsg( io, "setting LTEP support flag to %d", (flag!=0) );
     io->extendedProtocolSupported = flag;
 }
@@ -715 +695 @@
 {
     struct tr_datatype * datatype;
+
     assert( tr_amInEventThread( io->session ) );
     dbgmsg( io, "adding %zu bytes into io->output", writemeLen );
@@ -721 +702 @@
     datatype->isPieceData = isPieceData != 0;
     datatype->length = writemeLen;
-    tr_list_append( &io->output_datatypes, datatype );
+    tr_list_append( &io->outbuf_datatypes, datatype );
 
     evbuffer_add( io->outbuf, writeme, writemeLen );
@@ -742 +723 @@
 
 void
-tr_peerIoWriteBytes( tr_peerIo *       io,
+tr_peerIoWriteBytes( tr_peerIo       * io,
                      struct evbuffer * outbuf,
-                     const void *      bytes,
+                     const void      * bytes,
                      size_t            byteCount )
 {
@@ -768 +749 @@
 
 void
-tr_peerIoWriteUint8( tr_peerIo *       io,
+tr_peerIoWriteUint8( tr_peerIo       * io,
                      struct evbuffer * outbuf,
                      uint8_t           writeme )
@@ -776 +757 @@
 
 void
-tr_peerIoWriteUint16( tr_peerIo *       io,
+tr_peerIoWriteUint16( tr_peerIo       * io,
                       struct evbuffer * outbuf,
                       uint16_t          writeme )
@@ -786 +767 @@
 
 void
-tr_peerIoWriteUint32( tr_peerIo *       io,
+tr_peerIoWriteUint32( tr_peerIo       * io,
                       struct evbuffer * outbuf,
                       uint32_t          writeme )
@@ -800 +781 @@
 
 void
-tr_peerIoReadBytes( tr_peerIo *       io,
+tr_peerIoReadBytes( tr_peerIo       * io,
                     struct evbuffer * inbuf,
-                    void *            bytes,
+                    void            * bytes,
                     size_t            byteCount )
 {
@@ -824 +805 @@
 
 void
-tr_peerIoReadUint8( tr_peerIo *       io,
+tr_peerIoReadUint8( tr_peerIo       * io,
                     struct evbuffer * inbuf,
-                    uint8_t *         setme )
+                    uint8_t         * setme )
 {
     tr_peerIoReadBytes( io, inbuf, setme, sizeof( uint8_t ) );
@@ -832 +813 @@
 
 void
-tr_peerIoReadUint16( tr_peerIo *       io,
+tr_peerIoReadUint16( tr_peerIo       * io,
                      struct evbuffer * inbuf,
-                     uint16_t *        setme )
+                     uint16_t        * setme )
 {
     uint16_t tmp;
@@ -845 +826 @@
 
 void
-tr_peerIoReadUint32( tr_peerIo *       io,
+tr_peerIoReadUint32( tr_peerIo       * io,
                      struct evbuffer * inbuf,
-                     uint32_t *        setme )
+                     uint32_t        * setme )
 {
     uint32_t tmp;
@@ -858 +839 @@
 
 void
-tr_peerIoDrain( tr_peerIo *       io,
+tr_peerIoDrain( tr_peerIo       * io,
                 struct evbuffer * inbuf,
                 size_t            byteCount )