Changeset 7692

Timestamp:

Jan 12, 2009, 9:59:53 PM (12 years ago)

Author:

charles

Message:

(trunk libT) close open files immediately after they're done downloading

Location:

trunk/libtransmission

Files:

• completion.c (modified) (1 diff)
• completion.h (modified) (1 diff)
• peer-mgr.c (modified) (3 diffs)

trunk/libtransmission/completion.c

@@ -316 +316 @@
     return cp->completeBlocks[piece] == tr_torPieceCountBlocks( cp->tor, piece );
 }
+
+tr_bool
+tr_cpFileIsComplete( const tr_completion * cp, tr_file_index_t fileIndex )
+{
+    tr_block_index_t block;
+
+    const tr_torrent * tor = cp->tor;
+    const tr_file * file = &tor->info.files[fileIndex];
+    const tr_block_index_t firstBlock = file->offset / tor->blockSize;
+    const tr_block_index_t lastBlock = ( file->offset + file->length - 1 ) / tor->blockSize;
+
+    assert( tr_torBlockPiece( tor, firstBlock ) == file->firstPiece );
+    assert( tr_torBlockPiece( tor, lastBlock ) == file->lastPiece );
+
+    for( block=firstBlock; block<=lastBlock; ++block )
+        if( !tr_cpBlockIsComplete( cp, block ) )
+            return FALSE;
+
+    return TRUE;
+}

trunk/libtransmission/completion.h

@@ -129 +129 @@
                       tr_piece_index_t   piece );
 
+tr_bool tr_cpFileIsComplete( const tr_completion * cp, tr_file_index_t );
+
 /**
 *** Blocks
 **/
 
-static TR_INLINE int tr_cpBlockIsComplete( const tr_completion * cp, tr_block_index_t block ) {
+static TR_INLINE tr_bool tr_cpBlockIsComplete( const tr_completion * cp, tr_block_index_t block ) {
     return tr_bitfieldHas( &cp->blockBitfield, block );
 }

trunk/libtransmission/peer-mgr.c

@@ -27 +27 @@
 #include "completion.h"
 #include "crypto.h"
+#include "fdlimit.h"
 #include "handshake.h"
 #include "inout.h" /* tr_ioTestPiece */
@@ -1063 +1064 @@
         case TR_PEER_CLIENT_GOT_BLOCK:
         {
-            tr_torrent *     tor = t->tor;
+            tr_torrent * tor = t->tor;
 
             tr_block_index_t block = _tr_block( tor, e->pieceIndex, e->offset );
@@ -1088 +1089 @@
 
                 if( !ok )
+                {
                     gotBadPiece( t, p );
+                }
                 else
                 {
                     int i;
-                    int peerCount = tr_ptrArraySize( &t->peers );
-                    tr_peer ** peers = (tr_peer**) tr_ptrArrayBase( &t->peers );
+                    int peerCount;
+                    tr_peer ** peers;
+                    tr_file_index_t fileIndex;
+
+                    peerCount = tr_ptrArraySize( &t->peers );
+                    peers = (tr_peer**) tr_ptrArrayBase( &t->peers );
                     for( i=0; i<peerCount; ++i )
                         tr_peerMsgsHave( peers[i]->msgs, p );
+
+                    for( fileIndex=0; fileIndex<tor->info.fileCount; ++fileIndex )
+                    {
+                        const tr_file * file = &tor->info.files[fileIndex];
+                        if( ( file->firstPiece <= p ) && ( p <= file->lastPiece ) && tr_cpFileIsComplete( &tor->completion, fileIndex ) )
+                        {
+                            char * path = tr_buildPath( tor->downloadDir, file->name, NULL );
+                            tordbg( t, "closing recently-completed file \"%s\"", path );
+                            tr_fdFileClose( path );
+                            tr_free( path );
+                        }
+                    }
                 }