Changeset 7788

Timestamp:

Jan 24, 2009, 2:33:25 AM (12 years ago)

Author:

charles

Message:

(trunk libT) #1743: potential threading issue in tr_list. only affects 1.50b[1-3]

File:

• trunk/libtransmission/list.c (modified) (2 diffs)

trunk/libtransmission/list.c

@@ -15 +15 @@
 #include "utils.h"
 
-/***
-****
-***/
-
-static tr_list * _unusedNodes = NULL;
-
-static const tr_list TR_LIST_INIT = { NULL, NULL, NULL };
-
 static tr_list*
 node_alloc( void )
 {
-    tr_list * node;
-
-    if( _unusedNodes == NULL )
-        node = tr_new( tr_list, 1 );
-    else {
-        node = _unusedNodes;
-        _unusedNodes = node->next;
-    }
-
-    *node = TR_LIST_INIT;
-    return node;
+    return tr_new0( tr_list, 1 );
 }
 
@@ -42 +24 @@
 node_free( tr_list* node )
 {
-    if( node )
-    {
-        *node = TR_LIST_INIT;
-        node->next = _unusedNodes;
-        _unusedNodes = node;
-    }
+    tr_free( node );
 }