Changeset 839 for trunk

Timestamp:

Aug 30, 2006, 9:40:36 PM (16 years ago)

Author:

livings124

Message:

Better compare of IP strings.

Location:

trunk/macosx

Files:

• StringAdditions.m (modified) (1 diff)
• TorrentCell.m (modified) (1 diff)

trunk/macosx/StringAdditions.m

@@ -162 +162 @@
     if ([self isEqualToString: string])
         return NSOrderedSame;
+    
+    NSArray * selfSections = [self componentsSeparatedByString: @"."],
+            * newSections = [string componentsSeparatedByString: @"."];
+    
+    if ([selfSections count] != [newSections count])
+        return [[NSNumber numberWithUnsignedInt: [selfSections count]] compare:
+                            [NSNumber numberWithUnsignedInt: [newSections count]]];
 
-    NSEnumerator * selfSections = [[self componentsSeparatedByString: @"."] objectEnumerator],
-            * newSections = [[string componentsSeparatedByString: @"."] objectEnumerator];
-    
+    NSEnumerator * selfSectionsEnum = [selfSections objectEnumerator], * newSectionsEnum = [newSections objectEnumerator];
+    NSString * selfString, * newString;
     NSComparisonResult result;
-    NSString * selfString = [selfSections nextObject], * newString = [newSections nextObject];
-    while (selfString && newString)
-    {
+    while ((selfString = [selfSectionsEnum nextObject]) && (newString = [newSectionsEnum nextObject]))
         if ((result = [selfString compare: newString options: NSNumericSearch]) != NSOrderedSame)
             return result;
-        
-        selfString = [selfSections nextObject];
-        newString = [newSections nextObject];
-    }
     
-    if (selfString)
-        return NSOrderedDescending;
-    else if (newString)
-        return NSOrderedAscending;
-    else
-        return NSOrderedSame;
+    return NSOrderedSame;
 }
 

trunk/macosx/TorrentCell.m

@@ -107 +107 @@
         [barImage setSize: NSMakeSize(width * 1.5, BAR_HEIGHT)];
 
-    [barImage compositeToPoint: point fromRect: NSMakeRect(0, 0, width, BAR_HEIGHT)
-                        operation: NSCompositeSourceOver];
+    [barImage compositeToPoint: point fromRect: NSMakeRect(0, 0, width, BAR_HEIGHT) operation: NSCompositeSourceOver];
 }