Changeset 8494

Timestamp:

May 23, 2009, 6:09:56 PM (14 years ago)

Author:

charles

Message:

(trunk web) #2052: "Warning: Unresponsive Script" in Web GUI

Location:

trunk/web/javascript

Files:

• torrent.js (modified) (14 diffs)
• transmission.js (modified) (1 diff)

trunk/web/javascript/torrent.js

@@ -40 +40 @@
 
                 // Create a new <li> element
-                var element = $('<li/>');
-                element.addClass('torrent');
-                element[0].id = 'torrent_' + data.id;
+                var top_e = document.createElement( 'li' );
+                top_e.className = 'torrent';
+                top_e.id = 'torrent_' + data.id;
+                var element = $(top_e);
                 element._torrent = this;
                 this._element = element;
@@ -51 +52 @@
                 var e = document.createElement( 'div' );
                 e.className = 'torrent_name';
-                element[0].appendChild( e );
+                top_e.appendChild( e );
                 element._name_container = e;
                 
@@ -57 +58 @@
                 e = document.createElement( 'div' );
                 e.className = 'torrent_progress_details';
-                element[0].appendChild( e );
+                top_e.appendChild( e );
                 element._progress_details_container = e;
 
@@ -64 +65 @@
                 e.className = 'torrent_progress_bar incomplete';
                 e.style.width = '0%';
-                element[0].appendChild( e );
+                top_e.appendChild( e );
                 element._progress_complete_container = e;
                         
@@ -71 +72 @@
                 e.className = 'torrent_progress_bar incomplete';
                 e.style.display = 'none';
-                element[0].appendChild( e );
+                top_e.appendChild( e );
                 element._progress_incomplete_container = e;
                 
@@ -81 +82 @@
                 e = document.createElement( 'a' );
                 e.appendChild( image );
-                element[0].appendChild( e );
+                top_e.appendChild( e );
                 element._pause_resume_button_image = image;
                 //element._pause_resume_button = e;
@@ -89 +90 @@
                 e = document.createElement( 'div' );
                 e.className = 'torrent_peer_details';
-                element[0].appendChild( e );
+                top_e.appendChild( e );
                 element._peer_details_container = e;
                 
@@ -102 +103 @@
                 
                 // insert the element
-                $('#torrent_list').append(this._element);
+                this._controller._torrent_list.appendChild( top_e );
 
                 this._files = [];
@@ -108 +109 @@
                 if(data.files){
                         if(data.files.length == 1)
-                                this._fileList.addClass('single_file');
+                                this._fileList.className += ' single_file';
                         for (var i = 0; i < data.files.length; i++) {
                                 var file = data.files[i];
@@ -117 +118 @@
                                 var torrentFile = new TorrentFile(file);
                                 this._files.push(torrentFile);
-                                var class = (i % 2 ? 'even' : 'odd') + ' inspector_torrent_file_list_entry';
-                                torrentFile.element()[0].className = class;
-                                this._fileList[0].appendChild(torrentFile.element()[0]);
+                                var e = torrentFile.domElement();
+                                e.className = (i % 2 ? 'even' : 'odd') + ' inspector_torrent_file_list_entry'; 
+                                this._fileList.appendChild( e );
                         }
                 }
@@ -128 +129 @@
         
         initializeTorrentFilesInspectorGroup: function(length) {
-        this._fileList = $('<ul/>').addClass('inspector_torrent_file_list').addClass('inspector_group').hide();
-        $('#inspector_file_list').append(this._fileList);
+                var e = document.createElement( 'ul' );
+                e.className = 'inspector_torrent_file_list inspector_group';
+                e.style.display = 'none';
+                this._controller._inspector_file_list.appendChild( e );
+                this._fileList = e;
         },
         
         fileList: function() {
-                return this._fileList;
+                return $(this._fileList);
         },
         
@@ -479 +483 @@
          */
         isSelected: function() {
-                var e = this.element( );
-                return e && $.className.has( e[0], 'selected' );
+                return this.element()[0].className.indexOf('selected') != -1;
         },
 
@@ -670 +673 @@
                 li.appendChild(prog_div);
                 
-                this._element = $(li);
+                this._element = li;
                 this._priority_control = $(pri_div);
                 this._progress = $(prog_div);
@@ -702 +705 @@
         
         element: function() {
+                return $(this._element);
+        },
+        
+        domElement: function() {
                 return this._element;
         },

trunk/web/javascript/transmission.js

@@ -75 +75 @@
                         this.createSettingsMenu();
                 }
+
+                this._torrent_list = $('#torrent_list')[0];
+                this._inspector_file_list = $('#inspector_file_list')[0];
                 
                 // Setup the preference box