Changeset 8563

Timestamp:

May 30, 2009, 9:45:40 PM (14 years ago)

Author:

charles

Message:

(trunk libT) dead code removal

File:

• trunk/libtransmission/handshake.c (modified) (15 diffs)

trunk/libtransmission/handshake.c

@@ -108 +108 @@
     tr_crypto *           crypto;
     tr_session *          session;
-    uint8_t               myPublicKey[KEY_LEN];
     uint8_t               mySecret[KEY_LEN];
     uint8_t               state;
@@ -118 +117 @@
     uint32_t              crypto_provide;
     uint8_t               myReq1[SHA_DIGEST_LENGTH];
-    uint8_t               peer_id[PEER_ID_LEN];
     handshakeDoneCB       doneCB;
     void *                doneUserData;
@@ -215 +213 @@
 }
 
-static uint8_t *
-buildHandshakeMessage( tr_handshake * handshake,
-                       int *          setme_len )
-{
-    uint8_t          * buf = tr_new0( uint8_t, HANDSHAKE_SIZE );
+static void
+buildHandshakeMessage( tr_handshake * handshake, uint8_t * buf )
+{
     uint8_t          * walk = buf;
     const uint8_t    * torrentHash = tr_cryptoGetTorrentHash( handshake->crypto );
@@ -245 +241 @@
     assert( strlen( ( const char* )peer_id ) == PEER_ID_LEN );
     assert( walk - buf == HANDSHAKE_SIZE );
-    *setme_len = walk - buf;
-    return buf;
 }
 
@@ -268 +262 @@
     uint8_t hash[SHA_DIGEST_LENGTH];
     const tr_torrent * tor;
-    const uint8_t * peer_id;
+    const uint8_t * tor_peer_id;
+    uint8_t peer_id[PEER_ID_LEN];
 
     dbgmsg( handshake, "payload: need %d, got %zu",
@@ -296 +291 @@
 
     /* peer_id */
-    tr_peerIoReadBytes( handshake->io, inbuf, handshake->peer_id,
-                       sizeof( handshake->peer_id ) );
-    tr_peerIoSetPeersId( handshake->io, handshake->peer_id );
+    tr_peerIoReadBytes( handshake->io, inbuf, peer_id, sizeof( peer_id ) );
+    tr_peerIoSetPeersId( handshake->io, peer_id );
 
     /* peer id */
     handshake->havePeerID = TRUE;
-    dbgmsg( handshake, "peer-id is [%*.*s]", PEER_ID_LEN, PEER_ID_LEN,
-            handshake->peer_id );
+    dbgmsg( handshake, "peer-id is [%*.*s]", PEER_ID_LEN, PEER_ID_LEN, peer_id );
 
     tor = tr_torrentFindFromHash( handshake->session, hash );
-    peer_id = tor && tor->peer_id ? tor->peer_id : tr_getPeerId( );
-    if( !memcmp( handshake->peer_id, peer_id, PEER_ID_LEN ) )
+    tor_peer_id = tor && tor->peer_id ? tor->peer_id : tr_getPeerId( );
+    if( !memcmp( peer_id, tor_peer_id, PEER_ID_LEN ) )
     {
         dbgmsg( handshake, "streuth!  we've connected to ourselves." );
@@ -494 +487 @@
     /* ENCRYPT len(IA)), ENCRYPT(IA) */
     {
-        int       msglen;
-        uint8_t * msg = buildHandshakeMessage( handshake, &msglen );
-
-        tr_peerIoWriteUint16( handshake->io, outbuf, msglen );
-        tr_peerIoWriteBytes( handshake->io, outbuf, msg, msglen );
+        uint8_t msg[HANDSHAKE_SIZE];
+        buildHandshakeMessage( handshake, msg );
+
+        tr_peerIoWriteUint16( handshake->io, outbuf, sizeof( msg ) );
+        tr_peerIoWriteBytes( handshake->io, outbuf, msg, sizeof( msg ) );
 
         handshake->haveSentBitTorrentHandshake = 1;
-        tr_free( msg );
     }
 
@@ -719 +711 @@
     if( !handshake->haveSentBitTorrentHandshake )
     {
-        int       msgSize;
-        uint8_t * msg = buildHandshakeMessage( handshake, &msgSize );
-        tr_peerIoWrite( handshake->io, msg, msgSize, FALSE );
-        tr_free( msg );
+        uint8_t msg[HANDSHAKE_SIZE];
+        buildHandshakeMessage( handshake, msg );
+        tr_peerIoWrite( handshake->io, msg, sizeof( msg ), FALSE );
         handshake->haveSentBitTorrentHandshake = 1;
     }
@@ -737 +728 @@
     char client[128];
     tr_torrent * tor;
-    const uint8_t * peer_id;
+    const uint8_t * tor_peer_id;
+    uint8_t peer_id[PEER_ID_LEN];
 
     if( EVBUFFER_LENGTH( inbuf ) < PEER_ID_LEN )
@@ -743 +735 @@
 
     /* peer id */
-    tr_peerIoReadBytes( handshake->io, inbuf, handshake->peer_id, PEER_ID_LEN );
-    tr_peerIoSetPeersId( handshake->io, handshake->peer_id );
+    tr_peerIoReadBytes( handshake->io, inbuf, peer_id, PEER_ID_LEN );
+    tr_peerIoSetPeersId( handshake->io, peer_id );
     handshake->havePeerID = TRUE;
-    tr_clientForId( client, sizeof( client ), handshake->peer_id );
+    tr_clientForId( client, sizeof( client ), peer_id );
     dbgmsg( handshake, "peer-id is [%s] ... isIncoming is %d", client,
             tr_peerIoIsIncoming( handshake->io ) );
@@ -752 +744 @@
     /* if we've somehow connected to ourselves, don't keep the connection */
     tor = tr_torrentFindFromHash( handshake->session, tr_peerIoGetTorrentHash( handshake->io ) );
-    peer_id = tor && tor->peer_id ? tor->peer_id : tr_getPeerId( );
-    peerIsGood = memcmp( handshake->peer_id, peer_id, PEER_ID_LEN ) != 0;
+    tor_peer_id = tor && tor->peer_id ? tor->peer_id : tr_getPeerId( );
+    peerIsGood = memcmp( peer_id, tor->peer_id, PEER_ID_LEN ) != 0;
     dbgmsg( handshake, "isPeerGood == %d", peerIsGood );
     return tr_handshakeDone( handshake, peerIsGood );
@@ -987 +979 @@
     /* send our handshake */
     {
-        int       msgSize;
-        uint8_t * msg = buildHandshakeMessage( handshake, &msgSize );
-        tr_peerIoWriteBytes( handshake->io, outbuf, msg, msgSize );
+        uint8_t msg[HANDSHAKE_SIZE];
+        buildHandshakeMessage( handshake, msg );
+
+        tr_peerIoWriteBytes( handshake->io, outbuf, msg, sizeof( msg ) );
         handshake->haveSentBitTorrentHandshake = 1;
-        tr_free( msg );
     }
 
@@ -1107 +1099 @@
 {
     const uint8_t * peer_id = isConnected && handshake->havePeerID
-                              ? handshake->peer_id
-                              : NULL;
-    const int       success = ( *handshake->doneCB )( handshake,
-                                                      handshake->io,
-                                                      isConnected,
-                                                      peer_id,
-                                                      handshake->
-                                                      doneUserData );
+                            ? tr_peerIoGetPeersId( handshake->io )
+                            : NULL;
+    const int success = ( *handshake->doneCB )( handshake,
+                                                handshake->io,
+                                                isConnected,
+                                                peer_id,
+                                                handshake->doneUserData );
 
     return success;
@@ -1167 +1158 @@
       && ( !tr_peerIoReconnect( handshake->io ) ) )
     {
-        int       msgSize;
-        uint8_t * msg;
+        uint8_t msg[HANDSHAKE_SIZE];
+
         dbgmsg( handshake, "handshake failed, trying plaintext..." );
-        msg = buildHandshakeMessage( handshake, &msgSize );
+        buildHandshakeMessage( handshake, msg );
         handshake->haveSentBitTorrentHandshake = 1;
         setReadState( handshake, AWAITING_HANDSHAKE );
-        tr_peerIoWrite( handshake->io, msg, msgSize, FALSE );
-        tr_free( msg );
+        tr_peerIoWrite( handshake->io, msg, sizeof( msg ), FALSE );
     }
     else
@@ -1222 +1212 @@
     else
     {
-        int       msgSize;
-        uint8_t * msg = buildHandshakeMessage( handshake, &msgSize );
+        uint8_t msg[HANDSHAKE_SIZE];
+        buildHandshakeMessage( handshake, msg );
+
         handshake->haveSentBitTorrentHandshake = 1;
         setReadState( handshake, AWAITING_HANDSHAKE );
-        tr_peerIoWrite( handshake->io, msg, msgSize, FALSE );
-        tr_free( msg );
+        tr_peerIoWrite( handshake->io, msg, sizeof( msg ), FALSE );
     }