Changeset 8611

Timestamp:

Jun 4, 2009, 3:52:54 PM (13 years ago)

Author:

charles

Message:

(trunk libT) fix potential permissions headache when saving json/benc files

File:

• trunk/libtransmission/bencode.c (modified) (5 diffs)

trunk/libtransmission/bencode.c

@@ -19 +19 @@
 #include <string.h>
 
-#include <sys/types.h> /* open() */
-#include <sys/stat.h> /* open() */
-#include <fcntl.h> /* open() */
 #include <locale.h>
 #include <unistd.h> /* close() */
@@ -38 +35 @@
 #ifndef ENODATA
  #define ENODATA EIO
-#endif
-
-#ifndef O_BINARY
- #define O_BINARY 0
 #endif
 
@@ -1542 +1535 @@
 {
     int err = 0;
-    int fd = open( filename, O_CREAT|O_WRONLY|O_TRUNC|O_BINARY );
-
-    if( fd < 0 )
+    FILE * fp = fopen( filename, "wb+" );
+
+    if( fp == NULL )
     {
         err = errno;
@@ -1557 +1550 @@
         while( !err && EVBUFFER_LENGTH( buf ) )
         {
-            if( evbuffer_write( buf, fd ) == -1 )
+            if( evbuffer_write( buf, fileno(fp) ) == -1 )
             {
                 err = errno;
@@ -1568 +1561 @@
             tr_dbg( "tr_bencToFile saved \"%s\"", filename );
         evbuffer_free( buf );
-        close( fd );
+        fclose( fp );
     }