Changeset 8849

Timestamp:

Jul 27, 2009, 6:48:21 PM (13 years ago)

Author:

charles

Message:

(trunk gtk) possible fix for #2267

File:

• trunk/gtk/icons.c (modified) (2 diffs)

trunk/gtk/icons.c

@@ -19 +19 @@
 get_static_string( const char *s )
 {
-    static GHashTable *static_strings = NULL;
-    const char *result;
-
-    if ( s == NULL )
-        return NULL;
-
-    if ( static_strings == NULL )
-        static_strings = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, NULL);
-
-    if ( ! g_hash_table_lookup_extended( static_strings, s, (gpointer) &result, NULL )) {
-        result = g_strdup( s );
-        g_hash_table_insert( static_strings,
-                             (gpointer) result,
-                             GINT_TO_POINTER( 1 ));
-    }
-
-    return result;
+    static GStringChunk * static_strings = NULL;
+
+     if( s == NULL )
+         return NULL;
+
+     if( static_strings == NULL )
+         static_strings = g_string_chunk_new( 1024 );
+
+    return g_string_chunk_insert_const( static_strings, s );
 }
 #endif
@@ -216 +208 @@
         return pixbuf;
     }
-        
+
     pixbuf = _get_icon_pixbuf( icon, icon_cache->icon_size, icon_cache->icon_theme );
-    g_hash_table_insert( icon_cache->cache, (gpointer) key, g_object_ref( pixbuf ));
+    if( pixbuf != NULL )
+        g_hash_table_insert( icon_cache->cache, (gpointer) key, g_object_ref( pixbuf ) );
         
     return pixbuf;