Changeset 8930 for trunk/libtransmission/torrent.c

Timestamp:

Aug 14, 2009, 2:41:59 PM (13 years ago)

Author:

charles

Message:

(trunk libT) revision to r8910 for #2162: check to see if a field's value has actually changed before setting the "dirty" flag.

File:

• trunk/libtransmission/torrent.c (modified) (8 diffs)

trunk/libtransmission/torrent.c

@@ -117 +117 @@
     assert( tr_isDirection( dir ) );
 
-    tr_bandwidthSetDesiredSpeed( tor->bandwidth, dir, KiB_sec );
-
-    tr_torrentSetDirty( tor );
+    if( tr_bandwidthSetDesiredSpeed( tor->bandwidth, dir, KiB_sec ) )
+        tr_torrentSetDirty( tor );
 }
 
@@ -137 +136 @@
     assert( tr_isDirection( dir ) );
 
-    tr_bandwidthSetLimited( tor->bandwidth, dir, do_use );
-
-    tr_torrentSetDirty( tor );
+    if( tr_bandwidthSetLimited( tor->bandwidth, dir, do_use ) )
+        tr_torrentSetDirty( tor );
 }
 
@@ -154 +152 @@
 tr_torrentUseSessionLimits( tr_torrent * tor, tr_bool doUse )
 {
-    assert( tr_isTorrent( tor ) );
-
-    tr_bandwidthHonorParentLimits( tor->bandwidth, TR_UP, doUse );
-    tr_bandwidthHonorParentLimits( tor->bandwidth, TR_DOWN, doUse );
-
-    tr_torrentSetDirty( tor );
+    tr_bool changed;
+
+    assert( tr_isTorrent( tor ) );
+
+    changed = tr_bandwidthHonorParentLimits( tor->bandwidth, TR_UP, doUse );
+    changed |= tr_bandwidthHonorParentLimits( tor->bandwidth, TR_DOWN, doUse );
+
+    if( changed )
+        tr_torrentSetDirty( tor );
 }
 
@@ -180 +181 @@
     assert( mode==TR_RATIOLIMIT_GLOBAL || mode==TR_RATIOLIMIT_SINGLE || mode==TR_RATIOLIMIT_UNLIMITED  );
 
-    tor->ratioLimitMode = mode;
-    tor->needsSeedRatioCheck = TRUE;
-
-    tr_torrentSetDirty( tor );
+    if( mode != tor->ratioLimitMode )
+    {
+        tor->ratioLimitMode = mode;
+        tor->needsSeedRatioCheck = TRUE;
+
+        tr_torrentSetDirty( tor );
+    }
 }
 
@@ -199 +203 @@
     assert( tr_isTorrent( tor ) );
 
-    tor->desiredRatio = desiredRatio;
-
-    tor->needsSeedRatioCheck = TRUE;
-
-    tr_torrentSetDirty( tor );
+    if( (int)(desiredRatio*100.0) != (int)(tor->desiredRatio*100.0) )
+    {
+        tor->desiredRatio = desiredRatio;
+
+        tor->needsSeedRatioCheck = TRUE;
+
+        tr_torrentSetDirty( tor );
+    }
 }
 
@@ -1792 +1799 @@
     assert( tr_isPriority( priority ) );
 
-    tor->bandwidth->priority = priority;
-
-    tr_torrentSetDirty( tor );
+    if( tor->bandwidth->priority != priority )
+    {
+        tor->bandwidth->priority = priority;
+
+        tr_torrentSetDirty( tor );
+    }
 }
 
@@ -2056 +2066 @@
 
 void
-tr_torrentSetActivityDate( tr_torrent * tor,
-                           time_t       t )
+tr_torrentSetActivityDate( tr_torrent * tor, time_t t )
 {
     assert( tr_isTorrent( tor ) );
@@ -2063 +2072 @@
     tor->activityDate = t;
     tor->anyDate = MAX( tor->anyDate, tor->activityDate );
-    tr_torrentSetDirty( tor );
 }